uninstall cmd questions | Dagger | Page 1

zenith vortex Nov 20, 2024, 1:16 PM

#

and if we do resolve the git dependency, and lets say that git repo has been deleted the resolve itself will fail.

we can handle the scenario by possibly checking for error msg but it adds the complexity to the code.

#

as a simple workaround - I could just return the msg saying "version %q was requested to be uninstalled but the installed version is %q"

raw atlas Nov 20, 2024, 1:20 PM

#

ah woops i forgot about this 🤔

#

yeah, we do actually need this logic

#

hm hm hm

#

what i would just do is match the version using the reverse of the logic that finds that tag

#

GitHub

A programmable CI/CD engine that runs your pipelines in containers - jedevc/dagger

#

so essentially, if i try and uninstall @v0.3.0, then match */v0.3.0

zenith vortex Nov 20, 2024, 1:22 PM

#

ah right, i was just typing that as a potential workaround

#

👍 - I'll try that out

raw atlas Nov 20, 2024, 1:23 PM

#

as long as we have a test that makes sure that it works, that approach feels like the best to me

zenith vortex Nov 20, 2024, 1:23 PM

#

yeah i will add a test for it

#uninstall cmd questions