private go module is breaking dagger

[deep compass]

Hi, I am unable to resolve this issue so hopefully reaching out to maybe get some help. Essentially my golang service uses a private module hosted on github. Having this in the root go.mod has completely broken dagger. The directory containing dagger has its on go.mod/sum file and I am using go.work. The structure is like the following:

|- dagger/
  - go.mod
  - go.sum
  - main.go
|- cmd/
  |- service1
    - main.go
|- pkg/
  |- foo/
    - foo.go
- go.mod <- contains the private module reference
- go.sum
- go.work

I've stripped out everything from dagger/main.go but getting the following: on any dagger call

Error: input: module.withSource.initialize resolve: failed to initialize module: failed to call module "services-foo" to get functions: call constructor: process "go build -o /runtime ." did not complete successfully: exit code: 1

Stderr:
internal/dagger/dagger.gen.go:17:2: github.com/foo/bar@v0.0.0-20241003134503-1005ef8b342d: invalid version: git ls-remote -q origin in /go/pkg/mod/cache/vcs/3ad0407fede9804847d8af0ca1762538df78a9d4576bacbd52dec9cdf79066f0: exit status 128:
        fatal: could not read Username for 'https://github.com': terminal prompts disabled

Im not even trying to build the application, which I would have expected as I would need to pass the container the SSH_AUTH_SOCK

Im at a loss as to resolve this - even tried vendoring.

[hollow sorrel]

@deep compass something seems odd here. Any chance you have a Dagger Cloud trace we can see?

[deep compass]

Yeah - how would you like it sent? Apologies I dont use Discord

[hollow sorrel]

the link to your Cloud trace should be enough 🙏

[deep compass]

https://dagger.cloud/amwill04/traces/68b78a3658233062f867becae7a4a4cf

Thanks for taking a look. As soon as I remove any reference to code from the private module and run go mod tidy to remove the reference in go.mod it works as expected

[deep compass]

Other context that might be useful: I’m using defaultDir and ignore for source

[hollow sorrel]

np, checking now @deep compass . Sorry, was in a meeting before

@deep compass mind sharing what's in your go.work?

ok, think I've found the issue

it's related to this issue: https://github.com/dagger/dagger/issues/8123

cc @keen sparrow @torpid plover

@deep compass can you try adding this to your dagger.json?

  "exclude": [
    "go.work"
  ]

that should unblock you until that issue is finalized

the problem is that some of your local project files are incorrectly being processed by the Go module runtime and trying to download private dependencies incorrectly.

[deep compass]

@hollow sorrel - thats worked like a charm. Thank you very much. Really appreciate the response. If I may ask a follow up question as Im only just starting to play with dagger - I currently use the following:

// Test runs unit tests as denoted by testing.Short()
func (m *FooApp) Test(
    ctx context.Context,
    // The source directory containing the go.mod file
    // +optional
    // +defaultPath="."
    // +ignore=["*", "!pkg/**/*.go", "!cmd/**/*.go", "!go.mod", "!go.sum", "!vendor/**/*"]
    src *dagger.Directory,
) (*TestResult, error) {
    //
        return &TestResult{}, nil
}

Should I be making use of this exclude within the dagger.json file? Even its just to point me to some docs.

Again, thank you!

[hollow sorrel]

defaultPath should generally be "/" as you usually want it to target the root of your repo. You can then use the "ignore" pragma so the client doesn't send unnecessary files to the engine. More about that here: https://docs.dagger.io/manuals/developer/functions/#directories-and-files

LMK if that makes sense of if it's still confusing

[keen sparrow]

I'll try this out to ensure this scenario is handled correctly in the PR for this issue