@Erik Sipsma just noticed a weird thing | Dagger | Page 1

quiet vessel Sep 27, 2024, 4:09 PM

#

Hi @shy elm , the flake you are trying to debug, is it in dagger_up_test? I recently refactored that code and fixed some flakes related to port reuse

shy elm Sep 27, 2024, 4:09 PM

#

yeah, the flakes are still happening, upon occasion they timeout

#

but that's been happening before+after your refactors

quiet vessel Sep 27, 2024, 4:10 PM

#

do you happen to have a trace for one of these flakes?

#

oh I see the URL in issue

#

one thing I am noticing is that all the tests are getting interrupt after 5s... but we set the timeout to 3m

shy elm Sep 27, 2024, 4:21 PM

#

See the dosignal before the start of the loop

#

That should be it?

quiet vessel Sep 27, 2024, 4:33 PM

#

yeah, that doSignal seems to run soon after. but with that tests should fail more often

#

i am wondering if with refactor something changed in terms of interrupt signal 🤔

#

the logic seems like: send interrupt, then try term and then kill.

#

if you want to defer this to me, I can take a look as I still have this fresh in my mind

quiet vessel Sep 29, 2024, 5:21 AM

#

I've opened https://github.com/dagger/dagger/pull/8593 with the possible fix

GitHub

fix(ci): fix the flake in dagger up testsuite by rajatjindal · Pull...

#

before this fix, it seems the tests were not running at all (because of interrupt being sent).

#

i've tested this by executing a few times, and also by making them fail (by changing the expected msg) to ensure they are actually running and passing

quiet vessel Sep 29, 2024, 5:59 AM

#

and also it seems that the issue was introduced during refactoring of tests to use test-matrix.

#@Erik Sipsma just noticed a weird thing