#hello folks, when adding a new field to

1 messages · Page 1 of 1 (latest)

lyric atlas
#

on trying to reproduce this issue locally, its reproducible if I run:

dagger call -m . check --targets=sdk/php

but works as expected when I run:

hack/with-dev dagger call -m . check --targets=sdk/php

#

@tough zealot @karmic wasp - oh, do we need to add another dagql.Func with a different View for WithExec for this change?

tough zealot
#

can you share a link/code-snippet to what you're trying to do?

#

when adding new features you should add them to all the views, as long as it's reasonable to do so imo

tough zealot
#

why is php trying to access that field? it seems like a bug in the codegen

#

cc @median dock any ideas? it seems like the codegen for the importable client is being used in the module maybe?

#

or are the tests not using the dev engine that we set?

#

no that doesn't appear to be it at least

#

2 weird things are happening

  • why is php explicitly populating that field? it shouldn't be passing it if the user hasn't set it?
  • why doesn't the engine see that field?
lyric atlas
#

doh. specifically this:

on trying to reproduce this issue locally, its reproducible if I run:

dagger call -m . check --targets=sdk/php

but works as expected when I run:

hack/with-dev dagger call -m . check --targets=sdk/php

tough zealot
#

bleh

#

okay the php test setup is wrong

#

the tests all need to accept a dev engine

#

this is what go/python/typescript all do

#

lemme spin this into the php channel

#

i put a message in #php

#

the php tests are broken, so don't block on this

#

it's not views related fyi