#Env variable interpolation in more funct...
1 messages · Page 1 of 1 (latest)
in the example of WihtNewFile, there's a current debate if we should expand variables in the path, the contents of the file, or both.
Any thoughts?
I'm initially inclined to have a single flag to set expansion and expand on everything.
agreed, i think if we're doing expansion it makes sense to do it across all the required string args
though, i wish we just had a generic expand function that would do this on strings/lists/etc.
(sadly, this breaks the chain)
I'll wait for Helder to chime-in as well. In the meantime, I will make changes for other functions.
thank you for your feedback on this.
I replied in the issue.
Thank you Helder. I see that you have suggested to expand only path.
FWIW, that is what I was thinking as well, but I would need help from you folks to help us reach a final decision so that I can make that change accordingly.
I'm also fine with moving forward to expanding only the path if the flag is called ExpandPath. So I guess we can implement that first as it seem to be what's currently hurting. cc @lunar shore ?
Yup sgtm 🎉