🚀 v0.13.0 - 11th September 2024

[surreal aspen]

👋

✨ v0.13.0 - 10th September 2024

As discussed with <@&946480760016207902> internally, we're gonna try and go for next for v0.13.0 - no super big changes to land, though I'm currently clearing through the milestone of stuff I'd really like to get in

https://github.com/dagger/dagger/milestone/51

I'm on PTO on 9th/10th, so won't be around to run the release - so someone else will need to take this one

as always, anything that we want done for v0.13.0 takes priority over other stuff, so please ping me for reviews etc 🙂

[silk birch]

It's been a while since I ran a release, happy to take this one 💪

There is a breaking change which I want to do for the Helm chart. Putting the PR together now.

[twin mango]

Hey! I'm back from PTO too so ready to help on anything 😄

[surreal aspen]

https://github.com/dagger/dagger/pull/8149 is ready-to-review fyi - it's all erik's commits now, but i can't review my own pr

the issue i was tracking down in here is so much trickier than i thought - see #1281246101487353917.

so i'm gonna split that out

[surreal aspen]

would appreciate any reviews on the pr's that i have open on the milestone - since i'm on holiday monday/tuesday, i only have today/tomorrow to resolve any issues:
https://github.com/dagger/dagger/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Aopen+milestone%3Av0.13.0+author%3Ajedevc

[twin mango]

Hey @tropic solar @civic spade, could I get a review on https://github.com/dagger/dagger/pull/8362 so I can merge it asap.
This absolutely needs to be part of 0.13

[twin mango]

@civic spade Regarding context directory, are we sure that relative path should lead to the directory container the dagger.json or not? I'm still writing the 0.13 blog post but I'm not sure what to write on this part

If I need to update the path resolution, I'll need to merge a PR and indeed update the tests, let me know asap please 🙏

[twin mango]

@civic spade ^

[civic spade]

@twin mango there seemed to be consensus, but it's not just a question for me - @tropic solar @clear otter do you still feel we should revert the behavior, from "relative path start from source dir" to "relative path start from module root dir"?

As a reminder the argument was:

• It's useful (and requested) to access the module root
• There's no reliable way to get module root
• There's already dag.CurrentModule().Source() to access module source

[clear otter]

I'm inclined to make that revert, yes

[maiden mirage]

Yeah, me too.

[civic spade]

Thanks @maiden mirage, didn't want to ping you too late

[twin mango]

Alright! I'll do the PR today

[twin mango]

@surreal aspen I did the check for the TS drop commonJS in favor of module: https://github.com/dagger/dagger/pull/8237#issuecomment-2338852872

Seems like it's not specifically breaking anything, I also pushed the script I used (it's really a quick & dirty script but it does the job)

[twin mango]

@maiden mirage Hey 😄
Very important PR to include in the release https://github.com/dagger/dagger/pull/8391 because it changes the behaviour of context directory.
@bold arch Blog post should be updated in consequences too, the relative path actually point to the location of the dagger.json and no longer the module source's code

[silk birch]

I can see that a bunch of PRs for this release are still very much in flight: https://github.com/dagger/dagger/milestone/51

I have one coming up that fixes https://github.com/dagger/dagger/pull/8381 (we cannot release without this fix).

I think that it's OK to wait one more day. Tomorrow is the last day that I can run this release.

[maiden mirage]

Most are from Justin and he already agreed to push a few of them. Waiting for tomorrow SGTM.

[twin mango]

I'm still fighting the CI to get my PR merge, I fixed https://github.com/dagger/dagger/pull/8237, I forget to update a version in the test.
For https://github.com/dagger/dagger/pull/8391, still fighting the CI, only 1 run left to merge it

[twin mango]

https://github.com/dagger/dagger/pull/8391 is merged 😄

[surreal aspen]

Tomorrow also sgtm, I'm back then
The features can all be delayed, the fixes shouldn't

8149 is from sipsma, but is in my pr (I wrote some tests for it - it lgtm, but needs another approval that isn't me otherwise it can't be merged)

8331 isn't too complex, just covers an edge case we weren't before, though not technically a recent regression, it's surprising no one has hit it before

8347 should be able to be merged now, vito approved it

[silk birch]

Done. Release notes fragment outstanding, but otherwise LGTM.

[silk birch]

Looking at 8237 now.

[silk birch]

8237 is OK to merge when all checks are green.

[silk birch]

8331 needs changie & maybe rebase, but otherwise LGTM.

[silk birch]

8347 needs changie, but otherwise LGTM. OK to merge as soon as all checks are green. Already approved.

[bold arch]

Could you suggest the edits that make sense in this document please? https://docs.google.com/document/d/1WmPov4tj04mpb7SYukDCT_2w_zkPGMjF4mZbj474sw8/edit

[twin mango]

Done

[twin mango]

Thanks a lot!

My last PR for the release is the context directory doc, I'll do my best to ship it tomorrow 😄

[surreal aspen]

hallo 👋 been merging prs, just waiting for tests to run on stuff

can't seem to merge https://github.com/dagger/dagger/pull/8389 🤔 (works now, huh)

[maiden mirage]

I'm trying to add the backwards compat for https://github.com/dagger/dagger/pull/8106 since it came up yesterday (https://discord.com/channels/707636530424053791/1283107857981509734). Already have the legacy test, just need to see how to switch to the old behavior based on the version in Go's codegen.

[silk birch]

There is one more Helm PR which I would like to get in before we cut this release: https://github.com/dagger/dagger/pull/8348#discussion_r1750138175

Also, I need to resolve https://github.com/dagger/dagger/pull/8381 so that it fixes the CLI publishing.

Putting those two PRs together now.

One down: https://github.com/dagger/dagger/pull/8406, one more to go. cc @surreal aspen

[surreal aspen]

Finally 🎉

[maiden mirage]

Added the compat layer and pushed. Waiting for checks to pass (and review).

[silk birch]

WDYT @surreal aspen https://github.com/dagger/dagger/pull/8381 ?

✨ v0.13.0 - 11th September 2024

[silk birch]

Reviewed & approved. This is the last one that we are waiting to merge before we can kick off the release.

Are you OK to run this release @surreal aspen ?

[surreal aspen]

i can, yes, still getting back on board though - anything i need to know?

[silk birch]

AFAIK, everything but that one PR above is merged & ready to go. Just a matter of going through the usual process.

[prime umbra]

If everything is green for https://github.com/dagger/dagger/pull/8365, might be nice to have it.

Otherwise I think we'll have a 0.13.1 pretty soon

Users are having issues with the ssh_auth_sock due to relative paths. If the PR is all green, might be worth having it. It's an incomplete fix just to try to fit in the release (reduced the scope and revised the pr)

If it fails then it's ok to skip

If too late it's ok too

[silk birch]

Anything else that we are missing from this release @maiden mirage ?

[silk birch]

Taking a look now.

[prime umbra]

I am in a Public train station, if someone can rebase it again if it is green, I cant take my computer out 🙏

[silk birch]

LGTM. Asked @surreal aspen for a second pair of eyes. If it looks good to him too, no reason why we couldn't merge & include it in this release.

[maiden mirage]

There's some deprecation removals for example but I've already pushed them to v0.14 so it's good to go on my end.

[prime umbra]

Mmmh, seems to have failed. Can't see the logs rn, it's ok, will be a patch release then

[silk birch]

Done.

[surreal aspen]

yeaa i'd rather this as well

[silk birch]

This one looks good to merge: https://github.com/dagger/dagger/pull/8106

OK to go ahead @maiden mirage ?

OK, all PRs & issues are now closed: https://github.com/dagger/dagger/milestone/51?closed=1

v0.13.0 is now yours to run @surreal aspen 🧑‍✈️

[surreal aspen]

will do

[silk birch]

This should be a quick review @surreal aspen @maiden mirage https://github.com/dagger/dagger/pull/8407

[surreal aspen]

prep pr here: https://github.com/dagger/dagger/pull/8408
going for lunch, will then merge and tag

[surreal aspen]

@maiden mirage do you want to follow-up with the python changes? i'm happy to hold until then

[maiden mirage]

Ok, should be quick, just need to try them out again.

[maiden mirage]

👉 https://github.com/dagger/dagger/pull/8410. Still missing a feature to easily reuse the previous constraints, but I'll leave that to the docs page. Not worth going into that detail in the change log.

[surreal aspen]

hm

typescript is failing https://github.com/dagger/dagger/actions/runs/10810619033/job/29988533169

cc @twin mango any insight into that?

i think this broke after merging https://github.com/dagger/dagger/commit/9e2ddb0cfcbdcf0fed30b7aca837dc7655794c35

but publish was broken so didn't notice

⚠️ blocking on this

[surreal aspen]

should be fixed by https://github.com/dagger/dagger/pull/8413

cc @tropic solar @maiden mirage 👀 ^

gr, it's still doing it https://github.com/dagger/dagger/actions/runs/10813627361/job/29998268031

https://github.com/dagger/dagger/pull/8415

it would be nice to daggerize these 😢

sorry @tropic solar 🙏

[twin mango]

Gj

Seems like I forget to bump that again, it's not the first time it's happening that changes on TS version breaks the CI, we should have some job to catch it

[surreal aspen]

grr

setup-bun has a bug

"use this syntax it says" 1.0.x - 1.1.x does not work though

looks like it's this maybe? https://github.com/oven-sh/setup-bun/issues/37

https://github.com/dagger/dagger/pull/8417
let's try again

anyone? 🙏

cc @tropic solar @maiden mirage sorry sorry sorry

if this one doesn't work, i'm going to have a little moment

thank you both ❤️

[tropic solar]

all in a day's work

[surreal aspen]

right, it works now

tagging

[civic spade]

for next time: context directory (flagship feature of this release) is completely undocumented. We should not have closed the issue, and therefore the release should have been held up.

[surreal aspen]

ah

https://github.com/dagger/dagger/pull/8339 should have been in the milestone

[civic spade]

right but closing issues before shipping docs is the root cause

I saw another instance of that just last week

[surreal aspen]

👍

can we make sure to call this out in #team/even team meeting, i think that's a good point, and we should make sure to not miss it

[quasi jewel]

yup! I will add it to the team agenda for this week. I would love to figure out the best way to ensure every issue has some type of docs improvement or addition done. I'll make an issue for the team offsite, so we can brainstorm some ways to do this.

[surreal aspen]

also, i think we can add a needs/docs tag, we already have a needs/changelog one

i can come up with an automated check for that one, but it's easy to add a tag for it right now so we don't forget it

added this right now: https://github.com/dagger/dagger/labels/needs%2Fdocs
we can keep updating our approach, but for now we can add this to prs to indicate that we need docs before merging/or as a follow-up to be opened before merging (cc @maiden mirage @placid forum @civic spade)

[civic spade]

the very first change we can make is to remember not to close issues until docs are shipped.

[surreal aspen]

helm pr here: https://github.com/dagger/dagger-for-github/pull/146

engine+cli+sdks+helm chart all done

@clear otter @balmy grotto @silk birch@prime umbra playground/cloud/daggerverse can all be updated

homebrew pr already opened: https://github.com/Homebrew/homebrew-core/pull/187126

improvement pr here: https://github.com/dagger/dagger/pull/8420

re-deployed docs as well, now deployed off of main

I think that should be everything I need to do right now, I need to head off for a bit in a few minutes (but can be back later if there are any unexpected 🔥s)

cc @quasi jewel @civic spade main part of the release here is done - all that should need doing is re-deploying the docs once the context dir docs are merged

[surreal aspen]

we may need some automation to make sure that issues aren't autoclosed - because github autolinks prs to issues, then merging the pr will auto-close the issue. feature request to disable this feature on github doesn't seem to have any interest/updates https://github.com/orgs/community/discussions/23476

hopping offline now

[mellow garnet]

i've been working on the docs today with tom, waiting for him to review my changes and check a couple of things and then we should be able to merge it

[twin mango]

Already reviewed 😄

[clear otter]

playground updated. Daggerverse PR here: https://github.com/dagger/dagger.io/pull/3959

[quasi jewel]

@twin mango when you get online tomorrow, can you do a final review on the context dir. docs PR? @mellow garnet will merge as soon as you do - https://github.com/dagger/dagger/pull/8339#issuecomment-2344616698

[twin mango]

alright!

I'll review right now so he can fix the CI before merging it

PR reviewed!

[mellow garnet]

Yup

I'm trying to get the CI green

[mellow garnet]

Merged and published https://docs.dagger.io/manuals/developer/functions#directories-and-files @twin mango @quasi jewel @surreal aspen

[surreal aspen]

🚀 v0.13.0 - 11th September 2024

[prime umbra]

same for https://docs.dagger.io/manuals/user/remote-repositories

[cunning agate]

Should this be working on macos? I've got v0.13 installed via brew and get the below.

$ dagger core container from --address=alpine terminal

✘ connect 17.8s
! start engine: failed to pull image: failed to run command: exit status 1
  ✘ starting engine 17.8s
  ! failed to pull image: failed to run command: exit status 1
    ✘ create 17.8s
    ! failed to pull image: failed to run command: exit status 1
      ✔ resolve image 1.8s
      ✔ exec docker ps -a --no-trunc --filter name=^/dagger-engine- --format {{.Names}} 0.2s
      ✘ exec docker inspect --type=image registry.dagger.io/engine:v0.13.0 0.0s
      ! failed to run command: exit status 1
      ┃ []                                                                                                                     
      ┃ Error response from daemon: No such image: registry.dagger.io/engine:v0.13.0                                           
      ✘ exec docker pull registry.dagger.io/engine:v0.13.0 15.8s
      ! failed to run command: exit status 1
      ┃ Error response from daemon: Head "https://registry.dagger.io/v2/engine/manifests/v0.13.0": Get "https://registry.dagger
      ┃ n?scope=repository%3Aengine%3Apull&service=ghcr.io": net/http: request canceled while waiting for connection (Client.Ti
      ┃ ceeded while awaiting headers)

[civic spade]

yes this should work. It looks like a networking error.

[cunning agate]

docker pull is working so that's interesting. Anyway, a me problem, I'll figure it out. Thanks! 🙂

[cunning agate]

Yeah seems to be a colima issue. Shame.

[civic spade]

@cunning agate were you able to get it to work?

[cunning agate]

Yep, swapped to docker desktop and all good. Thanks for checking 🙇‍♂️