Upgrade with Helm chart to 0.12.6 not working.

[dull raptor]

Hi,

I tried to upgrade from 0.12.5 to 0.12.6 today and it isn't working.

This is the log out of the pod. Edit: I realized later I only had a partial log.
#1279320089023348857 message

This is the k8s error:

Readiness probe failed: + echo '{ version }' + dagger query sh: dagger: not found

Any tips on what to do to fix would be greatly appreciated.

Scott

Rolled back to 0.12.5 and all is back to working.

[river swift]

cc @fallow saddle @winter rock

[river swift]

@dull raptor seems to work fine for me.

Just installed the latest helm chart in a kind cluster and the dagger pod seems to be healthy

    State:          Running
      Started:      Sat, 31 Aug 2024 23:14:56 -0300
    Ready:          True
    Restart Count:  0
    Readiness:      exec [sh -exc echo '{ version }' | dagger query] delay=5s timeout=30s period=15s #success=1 #failure=10
    Environment:    <none>
    Mounts:

[dull raptor]

Thanks for replying Marco. Did you do an upgrade or just an install?

[dull raptor]

This is the log from the pod.

[river swift]

I don't see any errors in that log file

[river swift]

helm upgrade --install

[dull raptor]

Yes, but did you have a running Dagger system beforehand? 🙂

[river swift]

No, first time install

[dull raptor]

Try installing 0.12.5 first, then upgrade to 0.12.6. See if it works.

[fallow saddle]

Hey scott!! Have you pinned down the engine image? Can you confirm the pod is running on v0.12.6?

[dull raptor]

@fallow saddle - Thanks for replying.

I had the engine version pinned to 0.11.1. I removed the version "tag" and now the upgrade was successful. Yay! 😄

However, I might need to pin in the future. What might be the issue with pinning that I can avoid so it will work?

[fallow saddle]

TL;DR: the dagger CLI binary is not available on engine images prior to v0.12.5: https://github.com/dagger/dagger/pull/8147

Allowing users to separate the engine version from the chart version brings this kinds of issues, were the chart makes an assumption of whats available in the image even though that is a moving target. We definitely need to be more careful moving forward

[dull raptor]

So, tagging versions isn't going to be supported? I guess I can live with that until it is a problem. 🙂 To be honest, I'm not sure why I had it tagged/ pinned to begin with.

[winter rock]

Thanks for spotting this @dull raptor ! I'm pretty sure that we should not allow specifying different versions for the Engine now that we cut a new Helm chart whenever we release a new Dagger version. I'm creating a GitHub issue for this now.

https://github.com/dagger/dagger/issues/8301

Just updated the description to make it clearer.

Would you be interested in submitting a PR @dull raptor ?

[dull raptor]

@winter rock - I believe the helm chart should still have an image tagging possibility, and the default in the helm chart should be "latest".

I'm also not an expert at all, so I'd rather leave it to the experts. 🙂

[winter rock]

Yes, specifying a custom image should be possible - I've updated the description which explains why.

No to setting a different app version from the chart version - the chart version now is the app version.

Also no to latest since this is a tag which changes and could introduce unexpected behaviour. For example, v0.13.0 is just around the corner, it will ship breaking changes, and then anyone running latest may get broken (depending on which features they use) as soon as that gets released.

Thank you for reporting the issue, we know how to make this better 👍

[dull raptor]

There you go. I'm glad you all are the experts and I'm in good hands. 😄