@marcosnils It is something that needs | Dagger | Page 1

round dragon Aug 22, 2024, 8:49 AM

#

@teal rain has a better understanding of it

teal rain Aug 22, 2024, 8:49 AM

#

Maybe something in the SDK; it currently only seems to cause an issue if the sdk adds a new dependency as that depedency isn't in the composer.lock so when the sdk does an install it's missed.

#

because the sdk isn't a real composer package, it isn't "locked" to a version, it's just copied in from the directory it was generated to.

#

The fix would be to include the composer.json of the sdk in the lock file somehow; detect changes and do an update for that dependency automatically if changed. This will require a composer plugin I think

round dragon Aug 22, 2024, 9:00 AM

#

@teal rain To be clear, which lock file wants to include it? The PhpSdk or the PhpSdkDev module?

#

I assume the PhpSdkDev module?

#

I have made an issue detailing this @turbid vine @teal rain
https://github.com/dagger/dagger/issues/8205

GitHub

PHP: Enforce parity between PhpSdk and PhpSdkDev dependencies · Iss...

When the dependencies of the PhpSdk update, the PhpSdkDev module does not. This is despite the PhpSdkDev module depending on the PhpSdk: dagger/sdk/php/dev/composer.json Lines 15 to 18 in ea6489e &...

#@marcosnils It is something that needs