feat: compute file digest by TomChv · Pu... | Dagger | Page 1

ivory crest Aug 8, 2024, 10:41 AM

#

@unkempt quest We are working on including PHPCS as part of the linting process.

I think maybe your issue might be related to this discussion: https://github.com/dagger/dagger/pull/8112#discussion_r1705925826

GitHub

PHP: Use phpcs for PhpSdkDev Linting by charjr · Pull Request #8112...

Add PHP Code Sniffer

Configured to lint against standards: PSR1 and PSR12

Can be called through the PhpSdkDev.Lint
Added to to Dev module in the same way as Python's Linting works.

#

I can't say for sure though, because we haven't added in PHPCS yet. But this is my first guess

unkempt quest Aug 8, 2024, 10:44 AM

#

Hmm is there an easy way to fix that bug on my PR?

ivory crest Aug 8, 2024, 10:44 AM

#

one second let me find the right lines.

unkempt quest Aug 8, 2024, 10:44 AM

#

Thanks!

ivory crest Aug 8, 2024, 10:46 AM

#

This line:
https://github.com/dagger/dagger/blob/b0d27e15843341643954a4e9ef0841cd785b78b3/dev/sdk_php.go#L102

Wants to be changed to this:

    content := fmt.Sprintf(
        "<?php\n\n/* Code generated by dagger. DO NOT EDIT. */return '%s';",
        version,
    )

GitHub

dagger/dev/sdk_php.go at b0d27e15843341643954a4e9ef0841cd785b78b3 ·...

An engine to run your pipelines in containers. Contribute to dagger/dagger development by creating an account on GitHub.

#

That's IF this is the same issue; if not, sorry for the red herring 😅

unkempt quest Aug 8, 2024, 10:50 AM

#

It doesn't look like it this: https://github.com/dagger/dagger/actions/runs/10300611973/job/28510367100?pr=8114

GitHub

feat: compute file digest · dagger/dagger@3f6f017

An engine to run your pipelines in containers. Contribute to dagger/dagger development by creating an account on GitHub.

#

Seems more like a formatting issue

#

But I don't see it locally, I'm rerunning the check just to verify, but last time it was good locally

ivory crest Aug 8, 2024, 10:52 AM

#

Ah! sorry I hadn't looked at the workflow

unkempt quest Aug 8, 2024, 10:52 AM

#

dagger call -m dev --source=.:default sdk php lint 

Full trace at https://dagger.cloud/Quartz/traces/7220935dbc6e6bad15f817570db60e52

✔ connect 1.1s
✔ initialize 8.0s
✔ prepare 1.2s
✔ daggerDev(
    source: ✔ ModuleSource.resolveDirectoryFromCaller(path: ".", viewName: "default"): Directory! 0.0s
  ): DaggerDev! 0.7s
✔ DaggerDev.sdk: DaggerDevSdk! 0.3s
✔ DaggerDevSdk.php: DaggerDevPhpsdk! 0.0s
✔ DaggerDevPhpsdk.lint: Void 21.5s

#

All good locally, that doesn't make sense

#

No changes when I regenerate the php client 😦

ivory crest Aug 8, 2024, 10:55 AM

#

Yeah apologies the fix I suggested is not what you need.

#

I'm just looking into it a bit more.

unkempt quest Aug 8, 2024, 10:58 AM

#

no problem, let me know 😄

#

Got a lot to do on other PR so no rush haha

ivory crest Aug 8, 2024, 11:05 AM

#

So your problem is that the sdk/php/generated directory has invalid linting on your branch.
Example: https://github.com/TomChv/dagger/blob/3f6f017b92dc3aa6f1be877f431440da764a293a/sdk/php/generated/Client.php#L149-L150

): GitRepository
{

This is what's in the main repository atm:
https://github.com/dagger/dagger/blob/b0d27e15843341643954a4e9ef0841cd785b78b3/sdk/php/generated/Client.php#L149

): GitRepository {

It should be all on one line like in the main repository.

If you remove your changes from:

sdk/php/generated/Client
sdk/php/generated/Container
sdk/php/generated/Directory
sdk/php/generated/Function_

That should solve all the linting issues

GitHub

dagger/sdk/php/generated/Client.php at b0d27e15843341643954a4e9ef08...

An engine to run your pipelines in containers. Contribute to dagger/dagger development by creating an account on GitHub.

GitHub

dagger/sdk/php/generated/Client.php at 3f6f017b92dc3aa6f1be877f4314...

A portable devkit for CI/CD pipelines. Contribute to TomChv/dagger development by creating an account on GitHub.

#

It may be that until I get the linting sorted properly, this may be an issue for anyone changing the generated dir.. so I'll try to get it sorted asap

unkempt quest Aug 8, 2024, 12:52 PM

#

Okay! Thanks!

unkempt quest Aug 8, 2024, 1:48 PM

#

@ivory crest It seems that it solved the issue but not completely, I still see an error in the CI:

https://github.com/dagger/dagger/actions/runs/10303294347/job/28518975288?pr=8114#step:3:932

On what schema the PHP sdk base its generationin the CI?