fix: print current directory without par... | Dagger | Page 1

subtle sandal Jul 19, 2024, 4:12 PM

#

Thanks so much for the contribution! Yes this is a good place to ask, we'll take a look!

#

I've actually been seeing this issue too lately, this is great.

I am just a bit confused on what \w was supposed to do, @south stirrup do you know?

south stirrup Jul 19, 2024, 4:16 PM

#

looks like this: https://man.archlinux.org/man/bash.1#PROMPTING - but maybe it only works for bash and not sh?

#

\w
    the value of the PWD shell variable ($PWD), with $HOME abbreviated with a tilde (uses the value of the PROMPT_DIRTRIM variable)

patent zinc Jul 19, 2024, 4:17 PM

#

Yes thats it. It seems like not all versions of sh support it.

#

The sh shipped in alpine supports \w but not the sh shipped in debian images

subtle sandal Jul 19, 2024, 4:35 PM

#

Does your PR work the same in sh and bash? Not sure if you tested it already.

south stirrup Jul 19, 2024, 4:59 PM

#

Not sure if that PR will work as-is or if it'll just literally put $(pwd | sed "s|^$HOME|~|") in the prompt thinkies

patent zinc Jul 22, 2024, 3:42 PM

#

I have not tested by building a new dagger engine but I have tested by setting the PS1 variable in multiple containers (alpine, debian, golang, ubuntu)

#fix: print current directory without par...