golangci config | Dagger | Page 1

strange glen Jul 17, 2024, 10:49 AM

#

@rocky plover heads up I'm going to push a small commit on top of that PR, dealing with corner cases in how the config file is passed

#

shouldn't conflict with the Severity-related changes

rocky plover Jul 17, 2024, 10:53 AM

#

yeah i'm also still working on it, so just don't force-push 😄

strange glen Jul 17, 2024, 10:56 AM

#

are you touching the Report() function?

rocky plover Jul 17, 2024, 11:00 AM

#

nah just fixing linting errors now

strange glen Jul 17, 2024, 11:04 AM

#

I can take that whole task if you'd rather focus on something else

#

This seems like something I can do

#

(and also I introduced the bug in the first place)

rocky plover Jul 17, 2024, 11:05 AM

#

yeah, sure, go for it 🎉

#

i'm working on the --compat flag now

strange glen Jul 17, 2024, 11:06 AM

#

Anything left for you to push?

rocky plover Jul 17, 2024, 11:09 AM

#

nope!

#

note, there's some weirdness with jobs that timeout on that pr, investigating that issue separately

strange glen Jul 17, 2024, 11:10 AM

#

Note: I'm going to keep the current behavior of disabling all overrides, but will setup the files in the container so that it's easy to change that

#

(this involves following the tool's recommendation of using $HOME/.golangci.yml as a default, hence my running into lack of env expansion and filing an issue about that

strange glen Jul 17, 2024, 12:06 PM

#

I'm still working on this, struggling with bad train internet

#golangci config