#Upgrading modules to 0.12

1 messages · Page 1 of 1 (latest)

dawn crest
#

🧵

#

Overall:

  • My code is affected by the breaking changes, which always adds friction, but they are all superficial, and most feel like they are improving my code. In particular WithNewFile() is massively simplified which feels nice 🙂

  • Compat mode is magical

  • If I wasn't intimately familiar with the breaking changes and compat mode, I might not understand what is going on. In particular if compat mode kicks in, I might not realize there are pending breaking changes that I have to deal with

  • dagger develop auto-updates my daggerVersion. Pro: it addresses the previous point by forcing me to deal with breaking changes in my module. Con: sometimes when I run dagger develop I don't actually want to deal with the breaking changes just this second.

#

I got bitten by this last point (dagger develop interference) today, I started an unrelated refactoring, ran dagger develop, then realized that I had been mixing 0.12-related changes into my refactoring. Had to go back and pick them out, annoying.

#

FYI @lethal bloom @boreal thunder I know you're aware of this. Just continuing the "log" here to collect real world data

dawn crest
#

Actually I'm kind of stuck

#

TLDR developing with Dagger 0.12 in a codebase that targets 0.11, is a PITA right now

#

In the context of our own pipelines @boreal thunder , I'm going to give up, and just rebase all my PRs in flight on top of the 0.12 upgrade PR. Not worth the trouble to target 0.11. I think we should take this into account for the compat DX

boreal thunder
#

i've been fixing up the 0.12 upgrade pr

dawn crest
#

(granted, the extra internet latency makes all this extra frustrating)

boreal thunder
#

sorry, i'm a bit distracted today, i think we have a pretty big bug somehow in 0.12, going to try and understand how

#

we somehow see a lot of job hangs after bumping the engine

dawn crest
#

Well that's obviously more important 👍

#

Should I plan for the 0.12 upgrade PR to be merged today? If so, I'll rebase everything on that to save time

#

I might even combine PRs, it's getting a little tiring to juggle so many small PRs

boreal thunder
#

sgtm

dawn crest
#

@boreal thunder just to confirm, dagger develop with Dagger 0.12 will always generate the 0.12 bindings, correct? In other words my 0.11 code may work in dagger call and dagger functions, but I can't make the IDE error for it go away, correct?

#

In that case then yes we absolutely need a --compat=VERSION flag to dagger develop

boreal thunder
#

let's move that discussion into ^

lethal bloom
#

Yesterday I used /dev (v0.11) depending on /sdk/python/dev (v0.12) without issue. Basically discarded the engineVersion change after dagger develop, but mostly just repeated dagger -m dev use sdk/python/dev to update the bindings from that dependency without updating engineVersion.

dawn crest
#

what's dagger use??

boreal thunder
#

alias to dagger install