#🚀 v0.11.9 - 24th June 2024

1 messages · Page 1 of 1 (latest)

exotic pasture
#

Turns out there is indeed a fix worthy of a patch release before v0.12.0: https://github.com/dagger/dagger/commit/6708971d052bad4d9ea3c3f19077e7ed81a43939

Super nasty bug since it means that engines will only prune local cache when the engine container starts up, so worth jumping through some extra hoops to release ASAP imo.

There have been a commit on main since v0.11.8 that are breaking (https://github.com/dagger/dagger/commit/87a0f1a74a763c2bdf6c2a2ab99fc39cda96917a), so I think we'll need to go with the separate branch approach @jed mentioned here #1254757484057464975 message

Next step for me is to do a dry run of RELEASING.md in my head to verify there won't be any gotchas. Since we rely on git tags I don't expect any, but worth a double check.

Provided that's all good to go I'm happy to run this release today, but also realize that I can't get feedback from others in different time zones right now, so if there's any preferences to just wait until my tomorrow I can defer until then and just get the branch setup in the meantime. Let me know

cc @sterile junco @crisp sandal @torn flax @abstract hedge @neon parrot @abstract sundial @shut barn

#

Also note to self to add changlog for the fix during release, forgot to run changie again

abstract hedge
#

I can't comment on the releasing process itself (who/how/when), but on the decision to release / no-release a 0.11.9 based on this patch, it seems like a no-brainer "yes". We can't afford to not have that fix in an easy-to-consume release for 2+ weeks

#

And IMO there will be other fixes like that before we get to 0.12 in the current timeframe

#

Since we are already stuck with breaking changes in main, the only way forward for patch releases is with backport-branches, so might as well start developing that muscle

#

The other alternative is to revert the 2 breaking commits for now

exotic pasture
#

I think the branch approach is likely simpler overall. The fix is so small that it easily will rebase ontop of v0.11.8 and I'd rather keep this minimalistic. There's other non-breaking commits on main that I'm sure are fine but would rather keep the sources of potential surprise to a minimum

abstract hedge
#

Oh I see, you don't even want to pull in anything else from main after 11.8

#

I would just go ahead and do it, seems like a no brainer to me

#

and a big help for those encountering this particular issue in prod

exotic pasture
shut barn
abstract hedge
exotic pasture
shut barn
#

No problem, it's an edge case I'm not sure any users has hit before so it's okay to delay

#

Very specific to typescript syntax etc

#

I updated the PR with the right milestone

sterile junco
#

Sgtm 🙂 I'm happy to release tomorrow if you don't get to it today

exotic pasture
#

Okay made the separate branch, set to same commit as v0.11.8 and sent out this PR with the cherry pick and release notes: https://github.com/dagger/dagger/pull/7741

Taking notes on the steps so far so I can bootstrap a new section in RELEASING.md for this process once all said and done

sterile junco
#

I don't think there's anything tagging related that should be an issue

exotic pasture
exotic pasture
#

Ah well speak of the devil, many/most of the GHA jobs on that PR are stuck in Queued? https://github.com/dagger/dagger/pull/7741

Not sure if this is due to being merged into a non-main branch or separate issue. I'll wait a little bit. Worst case I can either run the checks locally or something dumb like opening a temp separate PR that's against main so they can run

#

Oh, the jobs might be stuck because they are saying Requested labels: dagger-v0-11-6-16c-nvme...

#

Wonder if I should include the "improve releasing during v0.11.8" commit as a cherry pick too? Will check and push if so.

#

Good example of the kinks to work out here 😄

sterile junco
#

Mmm that would make sense, otherwise we're releasing using v0.11.7 instead

#

Technically no reason we can't just probably best to use the latest

exotic pasture
#

Otherwise I'll just manually resolve the conflict, seeing if I can manage to avoid that though

#

Okay yeah cherry-picking that one avoided manual resolution, pushed all that to the PR and it looks like jobs are running now (some SDK tests are queued but one is running so probably expected they just need to wait)

exotic pasture
#

Apparently we don't have a rule that enforces a PR approval when merging to non-main branches? So I can technically merge, but would prefer 👀 to double check if anyone has a sec. It's all nice and green now https://github.com/dagger/dagger/pull/7741

#

thanks @crisp sandal!

#

Hm looks like CI doesn't run on non-main branches after merge. That's not ideal because there's a couple workflows that still only run there (macos tests come to mind, will double check for others).

I think I can manually trigger those actions against a branch? Will do that if so. Otherwise, I'll probably just go ahead as is since the fix is so small and non-platform-specific that it's not worth fretting over. Just something to note for the "improve releasing during v0.11.9" PR that comes after this.

#

publish is good, but the autogenerated SDK bump PR is all messed up: https://github.com/dagger/dagger/pull/7745

It was originally against main, but at the moment we want to merge into the release-v0.11.9 branch, but when I changed the base of that PR it has all the commits from main, not just the release-v0.11.9 branch...

I think what I'll do is:

  • Manually create the correct bump engine version PR against the release-v0.11.9 branch, merge that
  • After this release is done, merge the bump engine version PR into main too since we want it there too once all said and done
crisp sandal
#

I'm still around for reviews if something gets stuck anyhow

exotic pasture
exotic pasture
exotic pasture
#

All green there ✅

#

Go is all nice and released.

Moved onto Python, tagged locally but on push got this error?

sipsma@dagger_dev:~/repo/github.com/sipsma/dagger$ git push "${DAGGER_REPO_REMOTE:?must be set}" sdk/python/${PYTHON_SDK_VERSION}
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To https://github.com/dagger/dagger.git
 ! [remote rejected]     sdk/python/v0.11.9 -> sdk/python/v0.11.9 (refusing to allow an OAuth App to create or update workflow `.github/workflows/_sdk_check.yml` without `workflow` scope)
error: failed to push some refs to 'https://github.com/dagger/dagger.git'

What's very odd is this is exactly the same steps as pushing the go sdk tag+push (just s/go/python), which worked fine???

#

I noticed my remote for the main dagger repo uses https rather than ssh, so I guess I'll try switching that temporarily in case that's somehow related (gonna switch back after this since I greatly prefer less privileges when it comes to the main repo...)

#

Huh yeah using git@github.com:dagger/dagger.git as the remote instead worked 🤷‍♂️

exotic pasture
#

SDKs and helm chart are done, homebrew and nix flake also updated.

cc'ing @abstract sundial @vestal gull @ruby anvil for updating Playground, Daggerverse, and Cloud (know it's off hours, this is just what RELEASING.md tells me to do 🙂 )

Will send out the dagger-for-github PR now

#

Just need to forward port the sdk+ci engine version bump PRs and send out some updates to RELEASING.md for this whole process. I'll fix what I can and for some of the more involved problems (i.e. sdk bump PR not working, some workflows hardcoding "main", etc.) I'll open up issues for now since I want to get to the integ test coverage for this whole bug asap.

Overall even though there were some bumps I'm honestly pretty happy with how it went given it was somewhat uncharted territory. All of the issues were easy to workaround, which is a good sign our whole release process is sufficiently flexible to handle stuff like this 🚀

exotic pasture
exotic pasture
#

Started updating RELEASING.md with the differing instructions for this process but very far from done; honestly kind of tricky to figure out the best way to present it comprehensibly while also not duplicating tons of instructions where the process is the same 🤔 https://github.com/dagger/dagger/pull/7748

Have to IRL for now though so will finish tomorrow

torn flax
vestal gull
vestal gull
exotic pasture
exotic pasture
#

🚀 v0.11.9 - 24th June 2024