#Test failure: terminal timeout

1 messages · Page 1 of 1 (latest)

polar monolith
#

@sinful egret, I guess this is in your radar but tui: navigation, scrolling, optimizations was only rebased on top of attachable terminal sessions in main so both PRs were green but main is failing on TestModuleDaggerTerminal/directory because fe.rows seems to be nil in frontend_pretty.go#L741:

=== FAIL: core/integration TestModuleDaggerTerminal/directory (87.09s)
    multi.go:85: cat test
    multi.go:85: panic: runtime error: invalid memory address or nil pointer dereference
    multi.go:85: [signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0xac05a4]
    multi.go:85:
    multi.go:85: goroutine 1 [running]:
    multi.go:85: github.com/dagger/dagger/dagql/idtui.(*frontendPretty).goEnd(...)
    multi.go:85:     /app/dagql/idtui/frontend_pretty.go:741

    ...

    multi.go:85:     /app/cmd/dagger/main.go:280 +0x348
    module_terminal_test.go:376:
            Error Trace:    /app/core/integration/module_terminal_test.go:376
            Error:          Received unexpected error:
                            read |0: i/o timeout
            Test:           TestModuleDaggerTerminal/directory
    suite_test.go:309:
sinful egret
#

ah yea saw that on one of my PRs and applied a local fix, I'll pull it out, it's small. test just needs to wait for a prompt before typing input, since the TUI is interpreting it before it goes away. (also tweaked code to avoid the panic)