Merging Rust PRs | Dagger | Page 1

#

Hey! Sorry about the poor progress on these, feel free to poke here if you're frustrated about progress - there's always a lot of github notifications, and sometimes stuff falls through the cracks 😄

#

Feel free to directly request my reviews on any specific ones in the future.

#

For each PR, the number of people needing to get involved depends - I tend to play by ear, for the Rust SDK, I'm happy with just one dagger team person having seen it and approved it

#

For stuff affecting the core engine, the more eyes, the better 😄

#

I've merged the graphql update: https://github.com/dagger/dagger/pull/7036 (nice work on the serde serializer)

#

https://github.com/dagger/dagger/pull/6959 seems to have a couple unintended changes, would like to make sure that they are (but the meat of the PR looks right to me)

#

https://github.com/dagger/dagger/pull/7038 still doesn't look right - the linter is now failing - i think this is due to https://github.com/dagger/dagger/pull/7038/commits/863399babf2750be90ce20b4917adefa383e639d (but again, aside from this, lgtm)

#

if you can get a fixup for those before your talk, i'll be around all day (eu hours) - so can merge those as soon as comments resolved, etc 🙂

#Merging Rust PRs