lean mountain
Hi,
Is there an idiomatic way in Dagger to get the exit code from a WithExec operation? In my case I have a binary that returns a non-zero exit code, e.g.
ctr, err := cli.Container().From(image).WithExec([]string{"mybinary", "--exit-code"}).Sync(ctx)
I was trying to cast the err into a dagger.ExecError to inspect for the exit code but apparently err is nil.
vestal wigeon
WithExec returns a *Container which does not necessarily have a concept of exit code.
I am not 100% sure, but I think you may need to run WithExec with a few additional options https://pkg.go.dev/dagger.io/dagger#ContainerWithExecOpts
My immediate thought though is to run WithExec($?) as the last step because this should give you the exit code of the previously executed step.
With all that being said, can you tell me more about what you are trying to do? One of the main benefits of having first class primitives like Files, Directories, Binaries, containers, Services etc... is that you don't have to rely only on exit codes to make complex pipelines.
tranquil shoal
If that binary does indeed return a non-zero exit code, that code should return a dagger.ExecError. Can you share more details? What does --exit-code do? It’s not printing it to stdout is it?
lean mountain
I'd like my Dagger func to analyze a container image and return an error if it contains vulnerabilities. In this case, the func takes an image tarball (file path) and uses docker scout cves archive://image.tar --exit-code . The stdout shows the result of the analysis and if there're vulns, the exit code returned is 2.
jagged current
I'd like my Dagger func to analyze a container image and return an `error` if it...
hey Felipe! this seems to work:
func (m *Lele) Test(ctx context.Context, image string, hubToken *Secret) int {
c := dag.Scout().Cves("marcosnils", hubToken, image)
_, err := c.Sync(ctx)
var eerr *ExecError
if errors.As(err, &eerr) {
return eerr.ExitCode
}
return 0
}
I've forked your scout module and added the --exit-code argument to the WithExec for it to work
If I run that I get a 2 exit code from that function
LMK if that works
lean mountain
Thanks @jagged current, it was a silly mistake on my side, all good now 👍
One last thing, do you happen to know why I'm seeing this error in the GH workflow run? [1]
ERROR: required flag(s) "docker-scout-hub-password", "tarball-path" not set
I've specified both values in the GH workflow in my PR [ 2].
It works fine locally but not in the GH workflow 😅
jagged current
One last thing, do you happen to know why I'm seeing this error in the GH workfl...
Hmm I'm on mobile but I think it's because you don't seem to be setting the DOCKER_SCOUT_HUB_USER env variable in the dagger action?
I might be missing something since my screen is a bit small but have you checked that?