Exit(1) and exporting directory | Dagger | Page 1

clear saffron Jan 10, 2024, 3:53 PM

#

Hey, we have a e2e test script that sometimes exit's with code 1. We'd like to export a test report directory after that but it doesn't seem to work. Here's a minimal repro of what we found:

package main

import (
    "context"
    "dagger.io/dagger"
    "os"
)

func main() {
    ctx := context.Background()
    client, err := dagger.Connect(ctx, dagger.WithLogOutput(os.Stderr))

    if err != nil {
        panic(err)
    }
    dir := client.Directory().WithNewFile("test.py", `
print("exiting")
exit(1)
`)

    ctr := client.Container().From("python").
        WithDirectory("app", dir).
        WithWorkdir("app").
        WithExec([]string{"python3", "test.py"})

    ctr.Directory("").Export(ctx, "test-export")
}

I'd expect the directory export still to work even if the test.py fails. If I do exit(0) the export works.

Is this expected? Am I missing something?

Thanks!

#

If this is a bug in Dagger I'm happy to open issue to Github. But first checking here that it's not a user error 🙂

edgy rivet Jan 10, 2024, 4:35 PM

#

Hey @clear saffron 👋 Yeah what's happening is expected, since the test fails the pipeline will exit before making it to the export. One way around this is documented here: https://docs.dagger.io/cookbook/#continue-using-container-after-command-execution-fails

Cookbook | Dagger

Filesystem

clear saffron Jan 10, 2024, 5:59 PM

#

Thanks! Has it always been this way. I recall us needing manually check failing execs previously (~year ago when I started using Dagger). Might be that we just didn't know what we were doing back then 😄

edgy rivet Jan 10, 2024, 6:08 PM

#

We used to have a ExitCode() function, so we had a lot of examples that would show something like if ctr.ExitCode() != 0, but that actually didn't work because if the pipeline failed it would never make it to the ExitCode for the same reason it doesn't get to Export 😅

#Exit(1) and exporting directory