Python optional params | Dagger | Page 1

tender cradle Nov 9, 2023, 5:35 PM

#

Yes, optional params are supported but they're based on having a default or not, not by whether it allows None (which is what Optional[str] does).

#

For you to get that error it means it failed to undo the union in non_optional which is tested in https://github.com/dagger/dagger/blob/9ba00b59ddd6a15346408d98717614b93956161a/sdk/python/tests/modules/test_utils.py#L26.

#

Do you mind showing how you're defining that?

undone forge Nov 9, 2023, 6:09 PM

#

I've since switched Optional[str] to str | None = None which works fine

tender cradle Nov 9, 2023, 6:12 PM

#

Just by that? Ok that's a bug then, it should be equivalent, thanks for letting us know 🙂

undone forge Nov 9, 2023, 6:13 PM

#

No other changes to get that working

tender cradle Nov 9, 2023, 6:16 PM

#

Ok, so I didn't know about this:

>>> get_origin(str | None)
<class 'types.UnionType'>
>>> get_origin(Optional[str])
typing.Union

#

One is a UnionType, the other is a Union 😐

undone forge Nov 9, 2023, 6:20 PM

#

I didn't know about that either

#Python optional params