multiple modules

[random cedar]

Making a thread to track down the weirdness with multiple modules so we're not duping effort (cc @fast atlas @hoary sage)

So far I've learned there's something going wrong with the CurrentModule() call happening as part of the runtime. I've verified we're running the correct runtime, but you get back this cursed result when you inspect the ModuleID it returns:

query {
  module(id:"core.Module:..."){
    name
    objects {
        asObject {
        name
      }
    }
  }
}

{
  "data": {
    "module": {
      "name": "foo",
      "objects": [
        {
          "asObject": {
            "name": "Bar"
          }
        }
      ]
    }
  }
}

So it looks like we ran the bar runtime, but when it called CurrentModule() it got back the foo module and started popping its objects/types onto it.

[random cedar]

gottem

the fix

it was mutating the *core.Context directly before, which was most definitely causing some spooky action

Took me way too long to realize I had Bad Stuff cached and I needed to buildctl prune to even let it attempt to run the fix, since this is all intentionally out-of-band of regular caching

I've been bit by this before, I wonder if we should make core.Context a non-pointer (cc @fast atlas)

[fast atlas]

Oof, yeah that's no fun. I can't immediately think of any reason to not de-pointer it

[random cedar]

push fixed!

er...fix pushed

[hoary sage]

Eyyy nice 🎉 I can't believe I poked around for a while day on this 😢