#go mod replace
craggy shoal
It's because the generated code needs to use a package that was previously under sdk/go/internal/: https://github.com/dagger/dagger/tree/main/sdk/go/internal/querybuilder
That's moved to sdk/go/querybuilder now, but we don't have a published dagger.io/dagger with that change (it's only on the zenith* branches). But even if we did publish, it'd still be a little weird to have an otherwise fully-generated client library depend on an arbitrary version of our 'vanilla' SDK package.
lean vault
Would it make sense to just inline the whole thing in the codegen? To make it standalone?
craggy shoal
Yeah that's the most likely solution at this rate
I'm a little wary of just how much code we're generating, but don't have any better ideas atm, maybe it's fine
lean vault
craggy shoal
zenith-functions PR is +26k lines, mostly generated, it was 30k before 🙀
makes me fear for monorepos with a bunch of separate modules
it'll be a boon for people that get paid per line of code at least
lean vault
Does that mean dagger mod init will drop 26k lines of generated code in each module?
craggy shoal
nah it's not that bad. looks like it's around 3.6k per module
and the querybuilder/ package is 664 total lines, so that's a drop in the bucket
the thought of 'minified go' just crossed my mind, somewhere rob pike has felt a disturbance in the force
lean vault
IMO if the UX and architecture are sound, we can gradually improve the content that flows through it