#I pushed some fixes to the above branch

1 messages · Page 1 of 1 (latest)

sacred lichen
#

Oh nice, thanks! Hopefully that fixes the behavior we saw on macos too (that was fixed by restarting docker desktop for some reason). It's weird because I think I may have hit that freeze exactly twice on Linux, but I was also changing stuff at the time so I wasn't sure what was what.

The buffer approach looks good, I was wondering at the time if we'd need to do something like that but once it started working consistently for me figured it wasn't necessary

#

Also sounds good about just merging your branch

unreal jetty
#

There might be a way to simplify the implementation, that's just what I landed on after a few failed attempts haha. Only arrived on the 'single reader' idea after exhausting every other option 😅

sacred lichen
#

I have been figuring that ultimately it would probably be simplest to just update the upstream grpchijack implementation to have real implementations of the deadline methods rather than dummy ones.

#

And in the long term hopefully we can just move off grpc entirely to reduce the nesting insanity a couple levels