#Import Rust SDK - https://github.com/dagger/dagger/pull/5148
vivid rapids
Discussing on a GitHub issue/PR keeps all the context together, and easier to find, but this works too for one offs. Definitely better than DMs!
I am going to check the state of https://github.com/dagger/dagger/pull/5148 to see what else is left before we can merge it. Everything that we can leave for a follow-up, we should. Big discussions and big PRs tend to move slower. I'm all for small incremental improvements. All good 🦀
Import Rust SDK - https://github.com/dagger/dagger/pull/5148
gray wasp
If we want to cut as much as possible then I guess the only thing is only to make sure the build/test doesn't take 19 minutes. The rest can wait
The rest should work
vivid rapids
Would this help? https://github.com/dagger/dagger/pull/5148#issuecomment-1556215102
I've left a bunch of comments for a bunch of other files. This feels close now.
gray wasp
Great comments. I've added some answers, etc. in short i will remove rust/.github/ as the other ci jobs take over this and they shouldn't be needed anymore 😄
gray wasp
@vivid rapids fyi, you probably want to have the token extracted from an official dagger.io crates.io account 😄
I just need an email from you and then I can add it as owner of the crate: dagger-sdk https://crates.io/crates/dagger-sdk
vivid rapids
I just created the Dagger CI account on crates.io @gray wasp FWIW https://lib.rs/~dagger-ci
gray wasp
An invite should be sent now
vivid rapids
Accepted!
gray wasp
You should be able to extract a personal token then. But you probably already got that far
vivid rapids
Yes, I am re-running the failing job: https://github.com/dagger/dagger/actions/runs/5060909667/jobs/9109615681 . It shouldn't publish anything, only when we tag with sdk/rust/v** . My aim is to make the main branch be green again.
I've just spotted a problem. Fixing it now. PR coming up shortly.
I cancelled that workflow, it should not have run.