github releases | Dagger | Page 1

sage sigil Nov 9, 2022, 1:38 AM

#

🧵

#

It makes sense to me that SDK versions become less important over time. Kind of a detail you worry about only when messing with your go.mod

tender salmon Nov 9, 2022, 2:03 AM

#

that's ok, but what's going to happen when the CLI lands? the SDK artifacts in the dagger/dagger repo are not very relevant since the SDK's are fetched through each language package managers. But in the case of the CLI, I'd expect some users to download the tarballs from the github releases. If that's the case, the engine and the CLI releases will clash

worn crane Nov 9, 2022, 2:06 AM

#

No strong opinion yet, I’d default by making them the same version.

Having different versions adds headaches. I think for SDKs it’s warranted but less so for a CLI

#

Then again I could be convinced otherwise

tender salmon Nov 9, 2022, 2:07 AM

#

@worn crane I added my opinions about versioning here: https://github.com/dagger/dagger/issues/3347#issuecomment-1307458315

TL;DR I think it's ok if we make them have the same MAJOR, but I see an advantage if they can drift in the MINOR and PATCH versions

#

particularly since it will happen that the CLI will require a release because of a fix or new feature that doesn't require an engine release.

#github releases