#Container add `build` by vito · Pull Re...

1 messages · Page 1 of 1 (latest)

modest coral
#

Is this how this feature should work?

query MyQuery {
  git(url: "https://github.com/dagger/dagger") {
    branch(name: "v0.2.x") {
      tree {
        id
      }
    }
  }
}
#
  container {
    build(
      context: "eyJsbGIiOnsiZGVmIjpbIkdxZ0JDaVZuYVhRNkx5OW5hWFJvZFdJdVkyOXRMMlJoWjJkbGNpOWtZV2RuWlhJamRqQXVNaTU0RWljS0ZHZHBkQzVoZFhSb2FHVmhaR1Z5YzJWamNtVjBFZzlIU1ZSZlFWVlVTRjlJUlVGRVJW..."
      dockerfile: "Dockerfile"
    ) {
      exec(args: ["version"]) {
        stdout {
          contents
        }
      }
    }
  }
}
tropic junco
#

looks like it

modest coral
#
{
  "data": {
    "container": {
      "build": {
        "exec": {
          "stdout": {
            "contents": "dagger devel () linux/arm64\n"
          }
        }
      }
    }
  }
}
#

but I was surprised that the dagger command was implicit

tropic junco
#

we loose some chaining compared to Directory { build } (you need to stitch 2 queries) but the latter form opened questions around extension points; do we support multiple kinds of build? Who decides available build backends? Is this how extenions will work in the future? etc

modest coral
#

or maybe that's the ENTRYPOINT

lyric whale
#

probably sets ENTRYPOINT

tropic junco
#

entrypoint probably

tropic junco
#

I found my totem animal gif

#

wait a second..

lyric whale
#

didn't know these medal emojis existed, but they're perfect

modest coral
#

especially the 2nd place

tropic junco
#

@modest coral I wouldn't know about that one. I heard it's nice but have never seen it

modest coral
#

@tropic junco what was the name of my 1st grade teacher? I'm waiting...