#especially now that i can see that a

1 messages · Page 1 of 1 (latest)

hearty sable
#

Yep it's exactly that: https://github.com/dagger/cloak/blob/31f71daaaac9a08a1a9ea73da207b4d6ffef2261/core/filesystem/filesystem.go#L110-L120

We need to do a bit better there since the strings grow crazy long. I have a branch sitting around locally that I need to clean up where I tried compressing them. It helps a little bit, but not a really good solution. I tried switching them to be hashed IDs but soon realized it doesn't work with caching: https://github.com/dagger/cloak/issues/12#issuecomment-1230578506

uncut anvil
#

hm yeah that's tricky. it'd be a shame to introduce state for this. ideally we can kick the can down the road as much as possible. maybe we'll have different problems by then 🙂

#

there's a good chance this won't end up being a bottleneck in reality anyhow (vs the actual builds people are running)

hearty sable
#

Oh totally, the performance concern is a far ways away if ever. The most immediate thing is more that the long strings pollute output when e.g. an error occurs (and trying to truncate them is suprisingly hard to handle every case for)