You should make a thread on discord tbh | SpigotMC | Page 1

round stream May 17, 2022, 1:34 PM

#

here we go

#

I've done something similar previously and it was ok

#

https://www.spigotmc.org/threads/1-17-1-world-generator-api.521870/#post-4256785

SpigotMC - High Performance Minecraft

Resource - 1.17.1 World Generator API

Recently spigot pushed a new world generator API. Which gives developers more possibly and tools to code a custom world generator. As well as fixes...

#

How do I synchronize ? Do I have to put he key word on each child method ?

plucky scaffold May 17, 2022, 1:38 PM

#

Just the ones that will be called from biomeprovider

round stream May 17, 2022, 1:39 PM

#

public synchronized Biome getBiome(int x, int z){
        count++;
        System.out.println(count);
        return biomes.get(voronoi.getPixels()[x + Voronoi.SIZE /2][z + Voronoi.SIZE /2]);
    }```

#

nop it keeps crashing but the number changed

plucky scaffold May 17, 2022, 1:41 PM

#

Changed to?

round stream May 17, 2022, 1:41 PM

#

we went back 2

#

12221

plucky scaffold May 17, 2022, 1:41 PM

#

Lol

round stream May 17, 2022, 1:41 PM

#

Just restarted, still 12221 on the thread swap

plucky scaffold May 17, 2022, 1:42 PM

#

Are there any other methods you're calling?

round stream May 17, 2022, 1:42 PM

#

let's see from the beginning

#

WorldCreator wc = new WorldCreator(GameSettings.WORLD_NAME);
        wc.biomeProvider(new CustomBiomeProvider());
        System.out.println("0");
        wc.createWorld();
        System.out.println("1");```

#

it starts with this

plucky scaffold May 17, 2022, 1:43 PM

#

Right and in custombiomeprovider

round stream May 17, 2022, 1:43 PM

#

package net.johnpoliakov.ultrapower.utils.world;

import org.bukkit.block.Biome;
import org.bukkit.generator.BiomeProvider;
import org.bukkit.generator.WorldInfo;
import org.jetbrains.annotations.NotNull;

import java.util.ArrayList;
import java.util.List;

public class CustomBiomeProvider extends BiomeProvider {

    private final ArrayList<Biome> biomes = new ArrayList<>();
    private final MapReader mapReader = new MapReader();

    public CustomBiomeProvider() {

        for(BiomesEnum biome : BiomesEnum.values()){
            addBiome(biome.getBiome());
        }

    }

    private void addBiome(Biome biome) {
        this.biomes.add(biome);
    }

    @Override
    public @NotNull Biome getBiome(@NotNull WorldInfo worldInfo, int x, int y, int z) {

        // Plains in 150 blocks radius from 0:0
        if ((Math.pow(x, 2) + Math.pow(z, 2)) < Math.pow(150, 2))
            return Biome.PLAINS;

        // void if outside the border
        if(x >= 2048 || x <= -2048 || z >= 2048 || z <= -2048)
            return Biome.THE_VOID;

        // read from voronoi
        return mapReader.getBiome(x, z);

    }

    @Override
    public @NotNull List<Biome> getBiomes(@NotNull WorldInfo worldInfo) {
        return biomes;
    }
}

#

then the MapReader

#

package net.johnpoliakov.ultrapower.utils.world;

import org.bukkit.block.Biome;

import java.util.HashMap;

public class MapReader {

    private final Voronoi voronoi;
    private final HashMap<Integer, Biome> biomes = new HashMap<>();
    private int count = 0;

    public MapReader(){

        voronoi = new Voronoi(2, 150);
        for(BiomesEnum biome : BiomesEnum.values()){
            biomes.put(biome.getColor(), biome.getBiome());
        }

    }
    public synchronized Biome getBiome(int x, int z){
        count++;
        System.out.println(count);
        return biomes.get(voronoi.getPixels()[x + Voronoi.SIZE /2][z + Voronoi.SIZE /2]);
    }
}```

#

mmmmm

#

now I'm back to 12223

plucky scaffold May 17, 2022, 1:48 PM

#

I'm guessing that number is jist telling us abt how long it takes for the new thread to kick in

#

Try printing every 10th number

round stream May 17, 2022, 1:48 PM

#

but if you take a look to the post I linked, that's basically the same thing

#

I don't understand why it crashes

plucky scaffold May 17, 2022, 1:48 PM

#

Sounds dumb bit it'll probably go up

#

My guess was that there is some sort of deadlock

#

But i dont think i know enough to be able to help further

#

I think you should add to your post that it stops generatijg and freezes the server when the worker thread starts generation

round stream May 17, 2022, 1:49 PM

#

plucky scaffold Try printing every 10th number

nop we stop at 12220

plucky scaffold May 17, 2022, 1:49 PM

#

Weird

round stream May 17, 2022, 1:51 PM

#

I'm gonna try something

#

instead of getting the color from the array

#

I'm gonna pick it from the image buffer

#

still crashing

#

ok

#

solved I guess

plucky scaffold May 17, 2022, 1:56 PM

#

It works?

round stream May 17, 2022, 1:56 PM

#

gne

#

so it crashes, I tried with an area between -1024:-1024/1024:1024 instead of -2048:-2048/2048:2048

#

I reach 1180830

#

still on the 10th number print

#

but it crashes

plucky scaffold May 17, 2022, 1:58 PM

#

Bruh

#

Does it crash on switching tjreads again?

round stream May 17, 2022, 1:58 PM

#

nop

#

it did a long part on the worker thread

plucky scaffold May 17, 2022, 1:59 PM

#

That's just concurrency i guess

round stream May 17, 2022, 1:59 PM

#

from 122230 to 1180830 it's on the worker thread

plucky scaffold May 17, 2022, 1:59 PM

#

What changes when you change the size?

round stream May 17, 2022, 1:59 PM

#

and the method is still synchronized

#

I can generate more blocks I guess

#

let's try whith 512

plucky scaffold May 17, 2022, 2:07 PM

#

When you stored the pixels in a concurrenthasmap that didn't work?

round stream May 17, 2022, 2:15 PM

#

nop

plucky scaffold May 17, 2022, 2:15 PM

#

Can i have your voroni class

#

I wanna try it myself

round stream May 17, 2022, 2:15 PM

#

sure

#

https://www.toptal.com/developers/hastebin/letucuzufi.cpp

Hastebin: Send and Save Text or Code Snippets for Free | Toptal®

Hastebin is a free web-based pastebin service for storing and sharing text and code snippets with anyone. Get started now.

#

with 512 size map I can reach 407433

#

but still crash

#

it's stupid

plucky scaffold May 17, 2022, 2:27 PM

#

Do a bukkit.ismainthread check

#

If it's not just return void

round stream May 17, 2022, 2:27 PM

#

euh ok

#

wtf

#

it's...

#

wait

plucky scaffold May 17, 2022, 2:27 PM

#

Working?

round stream May 17, 2022, 2:27 PM

#

need to recheck but yeah

plucky scaffold May 17, 2022, 2:28 PM

#

What did u change?

round stream May 17, 2022, 2:28 PM

#

there was an error on my coord

#

I saw it with a smaller map size

plucky scaffold May 17, 2022, 2:29 PM

#

Ohh that's why it kept crashing at the same number

round stream May 17, 2022, 2:30 PM

#

yep

plucky scaffold May 17, 2022, 2:31 PM

#

What was wrong with the coord tho?

#

Like why wasn't there just a npe or something

#

Something froze all server threads

round stream May 17, 2022, 2:33 PM

#

out of size I was checking negative coord on the image because I was adding only half ot it's size to compensate negative coord instead of it's fullsize

#You should make a thread on discord tbh