Recipes | SpigotMC | Page 1

patent plume Nov 27, 2021, 9:44 AM

#

List<Recipe> recipes = Bukkit.getRecipesFor(playerMenuUtility.getItemToCraft()); has 6 recipes in it while I registered only one ShapedRecipe for my custom item.

        System.out.println(playerMenuUtility.getItemToCraft().getItemMeta().getDisplayName());
        System.out.println(recipes.size());

[11:42:04] [Server thread/INFO]: test
[11:42:04] [Server thread/INFO]: 6

#

When I iterate through it - ShapedRecipe returns me my registered recipe (9 diamonds), but ShapelessRecipe returns me 9 diamond blocks

idle lichen Nov 27, 2021, 10:10 AM

#

show yoru recipe code

patent plume Nov 27, 2021, 10:10 AM

#

idle lichen show yoru recipe code

    public static void registerCustomItemsRecipes() {
        Main.getInstance().getConfigManager().getCustomItems().getConfigurationSection("CustomItems").getKeys(false).forEach(item -> {
            List<String> matrix = Main.getInstance().getConfigManager().getCustomItems().getStringList("CustomItems." + item + ".Craft.Matrix");
            ShapedRecipe shapedRecipe = new ShapedRecipe(new NamespacedKey(Main.getInstance(), item.toLowerCase()), ItemUtils.getCustomItemFromConfig(item).getItemStack());
            shapedRecipe.shape(matrix.get(0),
                               matrix.get(1),
                               matrix.get(2));
            Main.getInstance().getConfigManager().getCustomItems().getConfigurationSection("CustomItems." + item + ".Craft.Ingredients").getKeys(false).forEach(ingredient -> {
                String customItemName = Main.getInstance().getConfigManager().getCustomItems().getString("CustomItems." + item + ".Craft.Ingredients." + ingredient + ".CustomItem");
                if(customItemName != null) {
                    TWDItem twdItem = ItemUtils.getCustomItemFromConfig(customItemName);
                    shapedRecipe.setIngredient(ingredient.charAt(0), new RecipeChoice.ExactChoice(twdItem.getItemStack()));
                } else {
                    Material material = Material.valueOf(Main.getInstance().getConfigManager().getCustomItems().getString("CustomItems." + item + ".Craft.Ingredients." + ingredient + ".Material").toUpperCase());
                    shapedRecipe.setIngredient(ingredient.charAt(0), material);
                }
            });
            shapedRecipes.add(shapedRecipe);
            Bukkit.addRecipe(shapedRecipe);
        });
    }

idle lichen Nov 27, 2021, 10:10 AM

#

and yrou config

#

for the items

patent plume Nov 27, 2021, 10:11 AM

#

CustomItems:
  TestItem:
    Name: 'test'
    Material: 'diamond'
    Lore: []
    Tier: 0
    Craft:
      Matrix:
        - 'XXX'
        - 'YYY'
        - 'ZZZ'
      Ingredients:
        X:
          Material: 'diamond'
        Y:
          Material: 'diamond'
        Z:
          Material: 'diamond'

idle lichen Nov 27, 2021, 10:15 AM

#

This path is invalid String customItemName = Main.getInstance().getConfigManager().getCustomItems().getString("CustomItems." + item + ".Craft.Ingredients." + ingredient + ".CustomItem");

patent plume Nov 27, 2021, 10:15 AM

#

idle lichen This path is invalid `String customItemName = Main.getInstance().getConfigManage...

yeah, but I have an else statement

#

                if(customItemName != null) {
                    TWDItem twdItem = ItemUtils.getCustomItemFromConfig(customItemName);
                    shapedRecipe.setIngredient(ingredient.charAt(0), new RecipeChoice.ExactChoice(twdItem.getItemStack()));
                } else {
                    Material material = Material.valueOf(Main.getInstance().getConfigManager().getCustomItems().getString("CustomItems." + item + ".Craft.Ingredients." + ingredient + ".Material").toUpperCase());
                    shapedRecipe.setIngredient(ingredient.charAt(0), material);
                }

#

the shaped recipe works fine, but idk why there is 6 recipes registered for my item

idle lichen Nov 27, 2021, 10:17 AM

#

Material.matchMaterial not Material.valueOf

patent plume Nov 27, 2021, 10:17 AM

#

and diamond blocks in the shapeless recipe

patent plume Nov 27, 2021, 10:17 AM

#

idle lichen `Material.matchMaterial` not `Material.valueOf`

what is the difference?

idle lichen Nov 27, 2021, 10:17 AM

#

matchMaterial is the correct one to use when searching by name

#

you also don;t need to uppercase the string when using matchMaterial

patent plume Nov 27, 2021, 10:19 AM

#

ok, I will test it now

idle lichen Nov 27, 2021, 10:20 AM

#

what is this TWDItem?

patent plume Nov 27, 2021, 10:21 AM

#

idle lichen what is this `TWDItem`?

the class for my custom items

#

still 6 recipes

#

and diamond blocks

#

https://imgur.com/a/rpLKmXP

idle lichen Nov 27, 2021, 10:22 AM

#

Then check if yoru ItemStacks are the same in ShapedRecipe shapedRecipe = new ShapedRecipe(new NamespacedKey(Main.getInstance(), item.toLowerCase()), ItemUtils.getCustomItemFromConfig(item).getItemStack()); and TWDItem twdItem = ItemUtils.getCustomItemFromConfig(customItemName);

patent plume Nov 27, 2021, 10:23 AM

#

idle lichen Then check if yoru ItemStacks are the same in `ShapedRecipe shapedRecipe = new S...

I can't, cause I don't use any custom items in this shape

idle lichen Nov 27, 2021, 10:23 AM

#

ah

patent plume Nov 27, 2021, 10:23 AM

#

Only the result is an custom item

idle lichen Nov 27, 2021, 10:23 AM

#

ok I was confusing yoru result

patent plume Nov 27, 2021, 10:24 AM

#

I can debug all the objects of the recipes list

#

if u need it

#

or something else

idle lichen Nov 27, 2021, 10:25 AM

#

You must have something else that is registering a recipe for a diamond

#

I see nothing in teh code you have shown that would do it

patent plume Nov 27, 2021, 10:25 AM

#

well, I actually don't

#

see

#

if I remove the check of ShapelessRecipe

#

it shows diamonds

#

not diamond blocks

idle lichen Nov 27, 2021, 10:27 AM

#

check for shapelsss? I've seen no shapeless

patent plume Nov 27, 2021, 10:27 AM

#

yeah

#

here is my method

#

https://pastebin.com/eSPb7uC2

#

[12:29:07] [Server thread/INFO]: test
[12:29:07] [Server thread/INFO]: 6
[12:29:07] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftBlastingRecipe@3eaa826b
[12:29:07] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftBlastingRecipe@6bdae8d0
[12:29:07] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftFurnaceRecipe@59cef8e1
[12:29:07] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftFurnaceRecipe@f1905bd
[12:29:07] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftShapedRecipe@65ca67ef
[12:29:07] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftShapelessRecipe@59ea9fee

idle lichen Nov 27, 2021, 10:29 AM

#

ah ok

#

those are all different recipes which can produce a diamond

#

you only added the shaped one

#

if you don;t register any recipe you should see one less

#

but you will still have some

#

as diamond blocks can make diamonds

patent plume Nov 27, 2021, 10:32 AM

#

yeah, but there are 9 diamond blocks

#

or did I understand u wrong

idle lichen Nov 27, 2021, 10:32 AM

#

comment out the line in yoru code Bukkit.addRecipe(shapedRecipe);

#

then see how many recipes it shows

patent plume Nov 27, 2021, 10:32 AM

#

k

#

did u mean that if I check it for itemstack then I should override all it's default crafts?

#

and should I use NamespacedKey instead

patent plume Nov 27, 2021, 10:35 AM

#

idle lichen then see how many recipes it shows

[12:34:47] [Server thread/INFO]: test
[12:34:47] [Server thread/INFO]: 5
[12:34:47] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftBlastingRecipe@45b34a67
[12:34:47] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftBlastingRecipe@2063e25c
[12:34:47] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftFurnaceRecipe@3a01d436
[12:34:47] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftFurnaceRecipe@554e49e4
[12:34:47] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftShapelessRecipe@af1c158

idle lichen Nov 27, 2021, 10:35 AM

#

5 recipes without yours

patent plume Nov 27, 2021, 10:35 AM

#

yes

idle lichen Nov 27, 2021, 10:35 AM

#

those are default recipes

patent plume Nov 27, 2021, 10:35 AM

#

how can I remove them

#

for this item

idle lichen Nov 27, 2021, 10:36 AM

#

you would be better registering a custom item recipe than using a straight diamond

patent plume Nov 27, 2021, 10:36 AM

#

wdym

idle lichen Nov 27, 2021, 10:36 AM

#

ie you would not want to prevent players converting diamond blocks back into diamonds

patent plume Nov 27, 2021, 10:36 AM

#

no

idle lichen Nov 27, 2021, 10:37 AM

#

your recipe created a diamond

#

from 9 diamonds

#

just with a custom name?

patent plume Nov 27, 2021, 10:37 AM

#

with a custom name and custom nbt tags

#

https://imgur.com/a/suvuZAs

idle lichen Nov 27, 2021, 10:39 AM

#

does ItemUtils.getCustomItemFromConfig(item).getItemStack() return the correct item with name and NBT?

#

AND its teh exact same item that thsi returns? playerMenuUtility.getItemToCraft()

#

If those two methods do return teh correct ItemStack it would tend to indicate an issue with getRecipesFor

#

however that would be unlikely

patent plume Nov 27, 2021, 10:42 AM

#

idle lichen AND its teh exact same item that thsi returns? `playerMenuUtility.getItemToCraft...

ig yes

idle lichen Nov 27, 2021, 10:43 AM

#

in that case I'd suggest changing to use ```
getRecipe
@Nullable
public static Recipe getRecipe(@NotNull
NamespacedKey recipeKey)
Get the Recipe for the given key.

Parameters:
recipeKey - the key of the recipe to return
Returns:
the recipe for the given key or null.```

patent plume Nov 27, 2021, 10:43 AM

#

will I have the possibility to support the legacy versions using this?

idle lichen Nov 27, 2021, 10:44 AM

#

I've no idea how far back that is supported

#

set your api version and try it

#

check playerMenuUtility.getItemToCraft() make sure it is returning the correct ItemStack

patent plume Nov 27, 2021, 10:45 AM

#

ok, I will check it now

idle lichen Nov 27, 2021, 10:48 AM

#

it seems like getRecipesFor is returning ANY recipe that produces that ItemStack. It seems to be ignoring any meta

patent plume Nov 27, 2021, 10:51 AM

#

System.out.println(playerMenuUtility.getItemToCraft().equals(ItemUtils.getCustomItemFromConfig(nbtManager.getNBT(playerMenuUtility.getItemToCraft(), "twd_customItem"))));

[12:51:02] [Server thread/INFO]: false

#

oh

#

nvm

#

I should get an ItemStack

#

from TWDItem class

#

also

#

one sec

#

System.out.println(playerMenuUtility.getItemToCraft().equals(ItemUtils.getCustomItemFromConfig(nbtManager.getNBT(playerMenuUtility.getItemToCraft(), "twd_customItem")).getItemStack()));

[12:54:21] [Server thread/INFO]: true

patent plume Nov 27, 2021, 10:54 AM

#

idle lichen check `playerMenuUtility.getItemToCraft()` make sure it is returning the correct...

they are equal

idle lichen Nov 27, 2021, 10:56 AM

#

one sec I'll pull up the code for getRecipeFor

patent plume Nov 27, 2021, 10:56 AM

#

ok

idle lichen Nov 27, 2021, 10:58 AM

#

a quick test you could do, set teh durability on teh ItemStack you call getRecipeFor to -1 before you search

#

the javadoc is a little cryptic on its search

#

They may be using the durability as a flag to tell teh method to match all data or just material

patent plume Nov 27, 2021, 10:59 AM

#

@NotNull
public static List<Recipe> getRecipesFor(@NotNull
ItemStack result)
Get a list of all recipes for a given item. The stack size is ignored in comparisons. If the durability is -1, it will match any data value.

Parameters:
result - the item to match against recipe results
Returns:
a list of recipes with the given result

#

ok

#

one sec

patent plume Nov 27, 2021, 11:03 AM

#

idle lichen a quick test you could do, set teh durability on teh ItemStack you call getRecip...

u mean this?

        ItemStack item = playerMenuUtility.getItemToCraft();
        Damageable meta = (Damageable) item.getItemMeta(); {
            meta.damage(-1);
            item.setItemMeta((ItemMeta) meta);
        }

idle lichen Nov 27, 2021, 11:03 AM

#

https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/ItemStack.html#setDurability(short)

patent plume Nov 27, 2021, 11:04 AM

#

idle lichen <https://hub.spigotmc.org/javadocs/spigot/org/bukkit/inventory/ItemStack.html#se...

it's deprecated

idle lichen Nov 27, 2021, 11:04 AM

#

use it anyway, its only a test

patent plume Nov 27, 2021, 11:04 AM

#

k

patent plume Nov 27, 2021, 11:07 AM

#

idle lichen use it anyway, its only a test

nothing changed

#

[13:07:05] [Server thread/INFO]: test
[13:07:05] [Server thread/INFO]: true
[13:07:05] [Server thread/INFO]: 6
[13:07:05] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftBlastingRecipe@12420bdb
[13:07:05] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftBlastingRecipe@2dac34c
[13:07:05] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftFurnaceRecipe@642440a3
[13:07:05] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftFurnaceRecipe@34862fdf
[13:07:05] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftShapedRecipe@3698f647
[13:07:05] [Server thread/INFO]: org.bukkit.craftbukkit.v1_17_R1.inventory.CraftShapelessRecipe@620c837b

#

        ItemStack testItem = playerMenuUtility.getItemToCraft();
        testItem.setDurability((short) -1);

idle lichen Nov 27, 2021, 11:07 AM

#

no clue then. It seems to be getting recipes for teh Material and doesn;t care about any meta

patent plume Nov 27, 2021, 11:08 AM

#

ok, let's try to use the NamespacedKey

#

yeah, it works for NamespacedKey

#

ty, but anyways the question is how to use it without using the NamespacedKey

patent plume Nov 27, 2021, 11:17 AM

#

idle lichen no clue then. It seems to be getting recipes for teh Material and doesn;t care a...

https://www.spigotmc.org/threads/shapeless-crafting-recipe.347656/

#

he is using this method

#

and gets 1 recipe

idle lichen Nov 27, 2021, 11:19 AM

#

he's doing a shapeless recipe not shaped

#

there are also no other recipes that can make a Spruce sapling

patent plume Nov 27, 2021, 11:24 AM

#

yeah

#

😦

#Recipes