How to stop fall damage in an event? | SpigotMC | Page 1

strange frigate Sep 9, 2021, 1:07 PM

#

I want to make an event that teleports you back up 200 blocks when fallen through void and turns off your fall damage, checks the block under you and sets your hearts to half a heart. How can I implement the turn fall damage off in my event?

        Player player = event.getPlayer();
        if (event.getTo().getBlockY() == 0) {
            player.teleport(player.getLocation().add(0, 200, 0));
            //turn fall damage off

            if (player.getLocation().getBlock().getLocation().equals(-1)) {
                if (player.getLocation().getBlock().getType() != Material.AIR) {
                    player.setHealth(1);
                }
            }
        }

ripe axle Sep 9, 2021, 1:07 PM

#

Hello!

strange frigate Sep 9, 2021, 1:08 PM

#

yes! any help?

ripe axle Sep 9, 2021, 1:08 PM

#

I have one way to do that in my mind right now.

frail dragon Sep 9, 2021, 1:08 PM

#

Idk if it’s possible to rest fall distance like a method

ripe axle Sep 9, 2021, 1:09 PM

#

By creating a Set and put player on the Set and then you listen to the EntityDamageEvent, check If the damage is FALL, and then cancel it, and after you cancel it, remove player from the Set.

frail dragon Sep 9, 2021, 1:09 PM

#

However you could toggle the players fly ability like instantaneously toggle it on and off

strange frigate Sep 9, 2021, 1:10 PM

#

Ok.. ill try conclure's simpler solution first and see if it works

frail dragon Sep 9, 2021, 1:10 PM

#

Believe u might have to turn on allow flight

strange frigate Sep 9, 2021, 1:11 PM

#

wait i think i found a solution

#

if (player.getLastDamageCause().getCause() == EntityDamageEvent.DamageCause.FALL) {

#

now i have to find a way to cancel the event

ripe axle Sep 9, 2021, 1:13 PM

#

Yeah EntityDamageEvent, just what I said.

#

But you need to create a Set first.

strange frigate Sep 9, 2021, 1:13 PM

#

idk how to do that

ripe axle Sep 9, 2021, 1:15 PM

#

Have you ever used a List?

#

Set is basically a same thing as a List.

strange frigate Sep 9, 2021, 1:20 PM

#

o ok

ripe axle Sep 9, 2021, 1:21 PM

#

So you create a Set in the field and then when you teleport the player, add the player to the Set.

strange frigate Sep 9, 2021, 1:22 PM

#

What does the set have to contain?

ripe axle Sep 9, 2021, 1:23 PM

#

Player object, private final Set<Player> fallenPlayers = new HashSet<>();

strange frigate Sep 9, 2021, 1:23 PM

#

ok

frail dragon Sep 9, 2021, 1:23 PM

#

A set is like a list but it should guarantee no duplicates to exist within the same instance. This also means its methods such as contains, add and remove are faster than the similar methods to List, however it entirely depends on implementation.

strange frigate Sep 9, 2021, 1:24 PM

#

ok cool

ripe axle Sep 9, 2021, 1:24 PM

#

Thanks for that Conclure.

#

So when you teleport the player 200 blocks above, you add the player to the set.

strange frigate Sep 9, 2021, 1:25 PM

#

uhm how do i add the player to the set?

ripe axle Sep 9, 2021, 1:25 PM

#

Set#add(player)

strange frigate Sep 9, 2021, 1:26 PM

#

it says illegal character '#'

ripe axle Sep 9, 2021, 1:26 PM

#

This is to detect that the player is being teleported 200 blocks above, so on the EntityDamageEvent we can detect that the player will receive fall damage.

strange frigate Sep 9, 2021, 1:27 PM

#

shouldnt it be something like fallenPlayers.add(player)

ripe axle Sep 9, 2021, 1:27 PM

#

strange frigate it says illegal character '#'

It's to tell that the method add is part of Set basically.

#

Yes, you use . in the code.

strange frigate Sep 9, 2021, 1:28 PM

#

ripe axle Sep 9, 2021, 1:29 PM

#

Change the Set to the variable name.

strange frigate Sep 9, 2021, 1:29 PM

#

strange frigate shouldnt it be something like fallenPlayers.add(player)

ooo like that

ripe axle Sep 9, 2021, 1:29 PM

#

yes

#

exactly like that

strange frigate Sep 9, 2021, 1:30 PM

#

right now how should i go about cancelling the fall damage event? inside an already existing event?

ripe axle Sep 9, 2021, 1:30 PM

#

After do that, now you listen to EntityDamageEvent

#

Here's the pseudo code.

  @EventHandler
  public void damageEvent(EntityDamageEvent event){
    if player is inside the Set && damage cause is FALL
      cancel the damage and remove player from the Set
  }

strange frigate Sep 9, 2021, 1:32 PM

#

ok thank you

ripe axle Sep 9, 2021, 1:32 PM

#

But first of all, you need to check if the Entity on the event is a Player.

strange frigate Sep 9, 2021, 1:35 PM

#

ripe axle Here's the pseudo code. ```java @EventHandler public void damageEvent(Entity...

how would i check if the player is inside the set?

ripe axle Sep 9, 2021, 1:35 PM

#

Set#contains

strange frigate Sep 9, 2021, 1:35 PM

#

wait im being dumb

#

i think

#

Player nor player does not work in contains()

#

im using a different class for this event is that why?

ripe axle Sep 9, 2021, 1:38 PM

#

You can just merge the event to make it simplier.

#

I mean make the event on the same class.

#

I'm guessing you use PlayerMoveEvent for the location check and teleport?

strange frigate Sep 9, 2021, 1:39 PM

#

yes

ripe axle Sep 9, 2021, 1:40 PM

#

Yeah so, just move it so it's in the same class.

#

If you want it to be on different classes, take a look at Encapsulation.

strange frigate Sep 9, 2021, 1:42 PM

#

ripe axle Yeah so, just move it so it's in the same class.

um i dont know how to do that :/

ripe axle Sep 9, 2021, 1:43 PM

#

public class YourClass{

  private final Set<Player> fallenPlayers = new HashSet<>();
  
  @EventHandler
  public void onPlayerMove(PlayerMoveEvent event){
    anything here...
  }

  @EventHandler
  public void onEntityDamage(EntityDamageEvent event){
    anything here...
  }

}

#

So with that, you can access fallenPlayers on both event.

strange frigate Sep 9, 2021, 1:44 PM

#

yea but i still get an error for checking if the set contains the player e.g. fallenPlayers.contains(Player)

ripe axle Sep 9, 2021, 1:45 PM

#

What's the error about?

strange frigate Sep 9, 2021, 1:45 PM

#

*sorry Player with capital

strange frigate Sep 9, 2021, 1:45 PM

#

ripe axle What's the error about?

expression expected

ripe axle Sep 9, 2021, 1:45 PM

#

You need to get the Player object from the EntityDamageEvent.

strange frigate Sep 9, 2021, 1:46 PM

#

uhm there is apparently no method for getPlayer(); in EntityDamageEvent

ripe axle Sep 9, 2021, 1:47 PM

#

Yes, you need to turn getEntity into Player, you can do that by casting it.

#

But first you need to check if the entity is a Player.

strange frigate Sep 9, 2021, 1:47 PM

#

ohh ok

ripe axle Sep 9, 2021, 1:48 PM

#

You can do that by doing something like this.

// With this, we will not continue the code if the entity
// is not a player
if(!(event.getEntity() instanceof Player)){
  return;
}

strange frigate Sep 9, 2021, 1:49 PM

#

oh i said this:

        if (event.getEntityType() == EntityType.PLAYER) {
            Player player = (Player) event.getEntity();
            if (fallenPlayers.contains(player)) {
                event.setDamage(0);
            }
        }

ripe axle Sep 9, 2021, 1:49 PM

#

Yeah you can do that too.

strange frigate Sep 9, 2021, 1:49 PM

#

ok cool

ripe axle Sep 9, 2021, 1:50 PM

#

You can just cancel the event instead set the damage to 0.

#

Check if the damage is FALL
Remove the player from the Set after cancelling the damage.

strange frigate Sep 9, 2021, 1:52 PM

#

Voila! i hope xD

        if (event.getEntityType() == EntityType.PLAYER) {
            Player player = (Player) event.getEntity();
            if (fallenPlayers.contains(player) && event.getCause() == EntityDamageEvent.DamageCause.FALL) {
                event.setCancelled(true);
                fallenPlayers.remove(player);
            }
        }

ripe axle Sep 9, 2021, 1:52 PM

#

yup, that's it.

strange frigate Sep 9, 2021, 1:53 PM

#

right now even if i register the event class to my main class, all the events inside will work right? no registering every event one by one?

ripe axle Sep 9, 2021, 1:53 PM

#

yes

#

All events inside the class will work.

#

As long as you register the class/listener

strange frigate Sep 9, 2021, 2:00 PM

#

Alright it worked for the most part, but i want it to set the health of the player to 1 when he lands. I cant check isOnGround() because its deprecated.

ripe axle Sep 9, 2021, 2:01 PM

#

Set player health after you remove the player from the set.

strange frigate Sep 9, 2021, 2:01 PM

#

oh wait yea

ripe axle Sep 9, 2021, 2:01 PM

#

That means the player have reached the ground (when you removes them from the set)

strange frigate Sep 9, 2021, 2:08 PM

#

Ok it works thank you so much

ripe axle Sep 9, 2021, 2:08 PM

#

Always happy to help 🙂

#How to stop fall damage in an event?