Code runs as expected on one account, but not another when hosting 2 instances at one time | SpigotMC | Page 1

shy plank Aug 11, 2024, 12:11 AM

#

https://paste.md-5.net/weyagudicu.cs
i have 2 instances of minecraft running so i can test that code is compatible across multiple accounts. This code executes as expected on one, but on the other, it only displays the NullPointerException (which in this case is ignored)

#

and if i add a message to the nullpointerexception it runs it 100% of the time once the TextComponent is used

coral geyser Aug 11, 2024, 12:14 AM

#

Never, ever, catch NullpointerExceptions. Fix the exception.

shy plank Aug 11, 2024, 12:15 AM

#

coral geyser Never, ever, catch NullpointerExceptions. Fix the exception.

i dont know how to

coral geyser Aug 11, 2024, 12:15 AM

#

Send it, then we can help

#

Nullpointer almost always occur for fundamental design flaws. They are one of the best indicators that something is wrong with your design/code.

shy plank Aug 11, 2024, 12:18 AM

#

coral geyser Nullpointer almost always occur for fundamental design flaws. They are one of th...

give me one second. im gonna test a theory and if it doesnt work ill let you know

shy plank Aug 11, 2024, 12:22 AM

#

coral geyser Send it, then we can help

https://paste.md-5.net/wirofozige.cs

#

it always sends java if (!plugin.getPlayerToPunish().containsKey(player.getUniqueId().toString())) { MessageManager.playerBad(player, "You do not have anyone selected to punish"); return true; } to one account but to the other it displays as expected

coral geyser Aug 11, 2024, 12:23 AM

#

Would you mind doing a bit of refactoring with early escapes?
This code is quite unpleasant to read.
An early escape for example is:

if (!(sender instanceof Player player)) {
  return;
}

shy plank Aug 11, 2024, 12:26 AM

#

i know what they are, i just dont know where to use them for this code

solar silo Aug 11, 2024, 12:27 AM

#

For example in that code you just sent, the check here should be inverse with an early return

honest cloak Aug 11, 2024, 12:28 AM

#

okay @shy plank first thing. Print the stacktrace instead of sending the player a message. and send us the stacktrace

shy plank Aug 11, 2024, 12:30 AM

#

[19:29:45] [Server thread/WARN]:        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45)
[19:29:45] [Server thread/WARN]:        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:149)
[19:29:45] [Server thread/WARN]:        at org.bukkit.craftbukkit.v1_18_R2.CraftServer.dispatchCommand(CraftServer.java:826)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1957)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1796)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1777)
[19:29:45] [Server thread/WARN]:        at net.minecraft.network.protocol.game.PacketPlayInChat.a(PacketPlayInChat.java:46)
[19:29:45] [Server thread/WARN]:        at net.minecraft.network.protocol.game.PacketPlayInChat.a(PacketPlayInChat.java:1)
[19:29:45] [Server thread/WARN]:        at net.minecraft.network.protocol.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:31)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.TickTask.run(SourceFile:18)
[19:29:45] [Server thread/WARN]:        at net.minecraft.util.thread.IAsyncTaskHandler.d(SourceFile:157)
[19:29:45] [Server thread/WARN]:        at net.minecraft.util.thread.IAsyncTaskHandlerReentrant.d(SourceFile:23)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1190)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:1)
[19:29:45] [Server thread/WARN]:        at net.minecraft.util.thread.IAsyncTaskHandler.y(SourceFile:131)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.MinecraftServer.be(MinecraftServer.java:1169)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.MinecraftServer.y(MinecraftServer.java:1162)
[19:29:45] [Server thread/WARN]:        at net.minecraft.util.thread.IAsyncTaskHandler.c(SourceFile:140)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1146)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1051)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:304)
[19:29:45] [Server thread/WARN]:        at java.base/java.lang.Thread.run(Thread.java:842)```

honest cloak Aug 11, 2024, 12:31 AM

#

what;s line 83?

solar silo Aug 11, 2024, 12:31 AM

#

solar silo For example in that code you just sent, the check here should be inverse with an...


SomeMethod(){

  if(xyz){

  return;
  }

  if(!xyz){

  return;
  }

  if(!(xyz)){
  
  return;
  }


// Then follow with whatever operations
}```

honest cloak Aug 11, 2024, 12:32 AM

#

shy plank https://paste.md-5.net/weyagudicu.cs i have 2 instances of minecraft running so ...

instead of

if (sender instanceof Player) {
  dosomething();
}

if (!(sender instanceof Player))
  return;

dosomething();

shy plank Aug 11, 2024, 12:34 AM

#

honest cloak what;s line 83?

if (plugin.getPlayerToPunish().get(player.getUniqueId().toString()).equalsIgnoreCase(target.getUniqueId().toString()))

honest cloak Aug 11, 2024, 12:34 AM

#

shy plank ```if (plugin.getPlayerToPunish().get(player.getUniqueId().toString()).equalsIgn...

yeah so target is null

#

most likely

#

i kinda fixed ur code

#

https://paste.md-5.net/mobuwidiku.cs

shy plank Aug 11, 2024, 12:35 AM

#

it removes the player/target from the playerToPunish hashmap after the confirm command is executed

honest cloak Aug 11, 2024, 12:36 AM

#

PlayerToPunish may also be null

honest cloak Aug 11, 2024, 12:36 AM

#

shy plank ```[19:29:45] [Server thread/WARN]: at games.kingdoms.kingdoms.admin.puni...

you didnt even send this

#

the entire thing that is

shy plank Aug 11, 2024, 12:36 AM

#

idk. but that is line 83

honest cloak Aug 11, 2024, 12:37 AM

#

send the entire thing

#

the entire error

shy plank Aug 11, 2024, 12:39 AM

#

[19:29:45] [Server thread/WARN]:        at games.kingdoms.kingdoms.admin.punishCMD.ConfirmPunishment.onCommand(ConfirmPunishment.java:83)
[19:29:45] [Server thread/WARN]:        at org.bukkit.command.PluginCommand.execute(PluginCommand.java:45)
[19:29:45] [Server thread/WARN]:        at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:149)
[19:29:45] [Server thread/WARN]:        at org.bukkit.craftbukkit.v1_18_R2.CraftServer.dispatchCommand(CraftServer.java:826)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1957)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1796)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:1777)
[19:29:45] [Server thread/WARN]:        at net.minecraft.network.protocol.game.PacketPlayInChat.a(PacketPlayInChat.java:46)
[19:29:45] [Server thread/WARN]:        at net.minecraft.network.protocol.game.PacketPlayInChat.a(PacketPlayInChat.java:1)
[19:29:45] [Server thread/WARN]:        at net.minecraft.network.protocol.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:31)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.TickTask.run(SourceFile:18)
[19:29:45] [Server thread/WARN]:        at net.minecraft.util.thread.IAsyncTaskHandler.d(SourceFile:157)
[19:29:45] [Server thread/WARN]:        at net.minecraft.util.thread.IAsyncTaskHandlerReentrant.d(SourceFile:23)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1190)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:1)
[19:29:45] [Server thread/WARN]:        at net.minecraft.util.thread.IAsyncTaskHandler.y(SourceFile:131)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.MinecraftServer.be(MinecraftServer.java:1169)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.MinecraftServer.y(MinecraftServer.java:1162)
[19:29:45] [Server thread/WARN]:        at net.minecraft.util.thread.IAsyncTaskHandler.c(SourceFile:140)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1146)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1051)
[19:29:45] [Server thread/WARN]:        at net.minecraft.server.MinecraftServer.lambda$0(MinecraftServer.java:304)
[19:29:45] [Server thread/WARN]:        at java.base/java.lang.Thread.run(Thread.java:842)
[19:38:19] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 5559ms or 111 ticks behind```

honest cloak Aug 11, 2024, 12:39 AM

#

plugin.getPlayerToPunish().get(player.getUniqueId().toString())

#

the map does not have a mapping for the player uuid

#

don't use strings, just use uuids

#

Map<String,String> can be

#

Map<UUID,UUID>

shy plank Aug 11, 2024, 12:43 AM

#

honest cloak Map<UUID,UUID>

The problem is i dont know if the custom config class i use can restore uuids from the config

honest cloak Aug 11, 2024, 12:43 AM

#

UUID.fromString(uuidstring)

shy plank Aug 11, 2024, 12:43 AM

#

ah

#Code runs as expected on one account, but not another when hosting 2 instances at one time