#Add AsyncStructureGenerateEvent and BlockState creation / cloning

1 messages · Page 1 of 1 (latest)

crude atlas
#

Yeah I'll remove them, there is no sense to have both.

untold timber
#

ive got some other things in a review for the cb pr, just thought to ask on discord about this thing cause a convo on stash about it would've been way more drawn out

crude atlas
#

Yeah it takes just way longer to notice a message there

#

Was perfectly fine, if you have anything else that you want to mention feel free to DM / ping me again :)

#

I guess I'll rename the clone method to copy
I would rather not use unplacedCopy it is kind of unecessary long, if I would want to copy a block state it would be to save the state of the block and not to have a active link to the block which is the case with the actual instance

untold timber
#

oh, one think I did miss in my review (always right after you hit submit you find smth else). I think since you started before brushable blocks, you missed a loot table being set on a block. Check DesertPyramidStructure (or whatever its called with spigot mappings). When suspicious sand is placed, it then has its loot table set.

crude atlas
#

I'll check if it is fine or not

#

yeah you're right