prevent pdc item from being put in container | SpigotMC | Page 1

frail brook Jul 20, 2023, 4:57 AM

#

ive asked so many people, cant figure it otu

#

ive tried so many things dude

#

does anyone have a solution

#

the issue is the item being stopped part

#

wehn i put it in another container it bugs out and stays there

#

or does some other weird sht

dawn zinc Jul 20, 2023, 5:12 AM

#

cancel the movement between comtainers

dawn zinc Jul 20, 2023, 5:31 AM

#

add a tag to the item like immovable or smth the. on inventoryxhange event and the 9 thousand other ones check if the item has the PDC value, if it does, can le if it doesn't, leave jt

frail brook Jul 20, 2023, 5:37 AM

#

dawn zinc cancel the movement between comtainers

yea but every time i try it always becomes buggy

#

so

#

im currently using the inventory click event and inventory drag event

dawn zinc Jul 20, 2023, 5:38 AM

#

replace the item I. cursor with air

frail brook Jul 20, 2023, 5:38 AM

#

then that will delete the item ?

frail brook Jul 20, 2023, 5:42 AM

#

dawn zinc add a tag to the item like immovable or smth the. on inventoryxhange event and t...

ive tried that in like 82000 different ways but none of them work

#

they all are supper buggy

#

like it stops me from moving it in my inventory but sometimes doesnt etc etc

#

Ive asked so many people and even some pretty talented devs couldnt help

#

Older solutions dont work anymore and I don’t know what to do

dawn zinc Jul 20, 2023, 6:00 AM

#

    @EventHandler 
     public void onInventoryClick(final InventoryClickEvent e) { 
         if (!cancelGUIClicks) return; 
         try { 
             if (!(e.getClickedInventory()).getHolder().toString().toLowerCase().contains("com.bedless.spawnerplus.gui.utils.spinventoryholder")) 
                 return; 
             if (!e.getInventory().getViewers().contains(e.getWhoClicked())) return; 
             e.setCancelled(true); 
             if (!notifyEvents) return; 
             SpawnerPlusEventManager.callGUIClickEvent((Player) e.getWhoClicked(), e.getCurrentItem(), e.getClickedInventory()); 
         } catch (NullPointerException ex) { 
             //Do Nothing, Ignore 
         } 
     } 
  
     @EventHandler 
     public void onInventoryClick(final InventoryDragEvent e) { 
         if (!cancelGUIDrags) return; 
         try { 
             if (!(e.getInventory().getHolder().toString().toLowerCase().contains("com.bedless.spawnerplus.gui.utils.spinventoryholder"))) 
                 return; 
             if (!e.getInventory().getViewers().contains(e.getWhoClicked())) return; 
             e.getCursor().setType(Material.AIR); 
             e.setCancelled(true); 
         } catch (NullPointerException ex) { 
             //Do Nothing, Ignore 
         } 
     }

#

my canceling works fine

frail brook Jul 20, 2023, 6:31 AM

#

kk lemme try

#

this looks identical to mine but we'll see 😭

frail brook Jul 20, 2023, 6:40 AM

#

dawn zinc ```java @EventHandler public void onInventoryClick(final InventoryClic...

ok ok kinda works but i cant move it in my inventory and i can still move it to another container with my number keys

#

    @EventHandler
    public void onInventoryClick(final InventoryClickEvent e) {
        try {
            if (!isSoulItem(e.getCurrentItem())) return;
            if (!e.getInventory().getViewers().contains(e.getWhoClicked())) return;
            e.setCancelled(true);
        } catch (NullPointerException ex) {
            //Do Nothing, Ignore
        }
    }

    @EventHandler
    public void onInventoryClick(final InventoryDragEvent e) {
        try {
            if (!isSoulItem(e.getCursor())) return;
            if (!e.getInventory().getViewers().contains(e.getWhoClicked())) return;
            e.getCursor().setType(Material.AIR);
            e.setCancelled(true);
        } catch (NullPointerException ex) {
            //Do Nothing, Ignore
        }
    }```

#

this is my implementation

#

do u see anything worng

#

with it

dawn zinc Jul 20, 2023, 6:42 AM

#

there's more events, I just gave you a few

frail brook Jul 20, 2023, 6:43 AM

#

yeah but it should allow me to move it in my inventory

#

isnt that what the if (!e.getInventory().getViewers().contains(e.getWhoClicked())) return; is?

#

its not getting emitted

dawn zinc Jul 20, 2023, 6:43 AM

#

just check the docs what other events get triggered by an item moving and can cancel them using the method I gave you

dawn zinc Jul 20, 2023, 6:44 AM

#

frail brook isnt that what the `if (!e.getInventory().getViewers().contains(e.getWhoClicked(...

that checks if the player is viewing the given inventory

frail brook Jul 20, 2023, 6:44 AM

#

ohh

#

icic

#

alright but

#

how did u go about fixing the number keys?

frail brook Jul 20, 2023, 6:28 PM

#

dawn zinc that checks if the player is viewing the given inventory

okay okay, i have fixed everything but the number keys

when i use them i can still put it in the other container

    @EventHandler
    public void onClick(InventoryClickEvent event) {
        ItemStack currentItem = event.getCurrentItem();
        if (currentItem == null) return;

        ItemStack cursor = event.getCursor();
        if (cursor == null) return;

        Inventory clickedInventory = event.getClickedInventory();
        if (clickedInventory == null ) return;

        Player player = (Player) event.getWhoClicked();

        if (event.getClick().isShiftClick()) {
            if (clickedInventory == player.getInventory()) {

                if (currentItem != null && (isSoulItem(currentItem))) {
                    event.setCancelled(true);
                }
            }
        }

        if (clickedInventory != player.getInventory()) {
            ItemStack onCursor = event.getCursor();

            if ((isSoulItem(onCursor))){
                event.setCancelled(true);
            }
        }
    }

    @EventHandler
    public void onInventoryDrag(InventoryDragEvent event) {
        ItemStack dragged = event.getOldCursor();

        if (isSoulItem(dragged)) {
            int inventorySize = event.getInventory().getSize();

            for (int i : event.getRawSlots()) {
                if (i < inventorySize) {
                    event.setCancelled(true);
                    break;
                }
            }
        }
    }```

#

this is my code

#

i still acnt figure out how to prevent number keys

#

everything works besides that

dawn zinc Jul 20, 2023, 6:29 PM

#

gimme a few min making my coffee, the ill take a look at it

frail brook Jul 20, 2023, 6:29 PM

#

alr no worries!

dawn zinc Jul 20, 2023, 6:51 PM

#

reconstructed ur code

frail brook Jul 20, 2023, 6:56 PM

#

okay

dawn zinc Jul 20, 2023, 7:00 PM

#

Imma sit in a call while trying to figure this out if you wanna join me xD

frail brook Jul 20, 2023, 7:01 PM

#

kk

#

i will gimme sec

dawn zinc Jul 20, 2023, 7:01 PM

#

What inventory are you checking fore

#

found it already

frail brook Jul 20, 2023, 7:03 PM

#

gtg to the bathroom for a sec

#

i cant join the vc rn

#

my mom needs me to walk my pet

dawn zinc Jul 20, 2023, 7:07 PM

#

Foudn the Issue

#

frail brook Jul 20, 2023, 7:07 PM

#

OH

#

what

dawn zinc Jul 20, 2023, 7:07 PM

#

Why are you checking for a cetrain click type

frail brook Jul 20, 2023, 7:07 PM

#

so if its shiftclick i can prevent that

dawn zinc Jul 20, 2023, 7:07 PM

#

There are so many diff types of clicks

#

you are only preveting shiftlick

#

why not prevent all

frail brook Jul 20, 2023, 7:08 PM

#

true

#

yeah but even when i dont do that

#

it still doesnt prevent number key

#

the reason being

#

is because

#

number keying items

#

returns air

#

on botrh current item

#

and cursor

frail brook Jul 20, 2023, 7:10 PM

#

dawn zinc

i thought that plugin was only on vscode

dawn zinc Jul 20, 2023, 7:10 PM

#

theres a few for intellij

frail brook Jul 20, 2023, 7:10 PM

#

or are u using their website

#

i gotta walk my pet

dawn zinc Jul 20, 2023, 7:30 PM

#

Good thing

#

ive blocked hotkeys

#

but that include blocking any action with the item xD

#

You can move the item whie in the player Inventory

#

but not while in a chest

frail brook Jul 20, 2023, 7:32 PM

#

i think thats fine lol

#

but its not preferred

dawn zinc Jul 20, 2023, 7:33 PM

#

imma work on fixing it tho xD

frail brook Jul 20, 2023, 7:33 PM

#

okay thanks dude

#

ur a lifesaver

#

its been a year im not kiding

dawn zinc Jul 20, 2023, 7:34 PM

#

The way im doing it, is im checking the Inventory Holder, if the inventory has been registered by a Player, i ignore im going to ignore the cancel, if its a inventory registered by an external source or a blokc like a chest, im going to suppres the moving

frail brook Jul 20, 2023, 7:38 PM

#

maybe check if the movement is in the player inventory

#

instead of checking the invetnory the plaer is in

dawn zinc Jul 20, 2023, 8:48 PM

#

?paste

dim lindenBOT Jul 20, 2023, 8:48 PM

#

https://paste.md-5.net/

dawn zinc Jul 20, 2023, 8:48 PM

#

Im giving you the patch, that blocks all item movement, if the player is viewing another inv that isnt theres
https://paste.md-5.net/fokayiraxo.cs

#

@frail brook

frail brook Jul 20, 2023, 8:48 PM

#

im in hte vc

#

nice

#

thanks

#

1sec

#

thanks for doing that, message me if u find a way to allow the player to move it in their inv while viewing a container

#

number keys still allow u to move it in another container

#

wait nvm

#

wait yeah

#

it does

#

F

#

sad

frail brook Jul 21, 2023, 4:44 AM

#

dawn zinc You can move the item whie in the player Inventory

can u send me this version

dawn zinc Jul 21, 2023, 5:07 AM

#

you already have it

#

when you're in the player inventory, you can move the item

frail brook Jul 21, 2023, 5:29 AM

#

dawn zinc when you're in the player inventory, you can move the item

yeah but i can still move it into a non player inventory with number keys

dawn zinc Jul 21, 2023, 5:30 AM

#

What

#

it didn't work for me

#

I found issue

frail brook Jul 21, 2023, 5:32 AM

#

you found it?

#

what is it

#

on the inventorymoveitem event it never triggers in my experience

#

maybe thats it?

#

and yes i removed the if(event.getInventory().getHolder().toString().toLowerCase().contains("craftplayer{name=")) return;

dawn zinc Jul 21, 2023, 5:33 AM

#

Copy the marked try catch statment

dawn zinc Jul 21, 2023, 5:33 AM

#

frail brook and yes i removed the ` if(event.getInventory().getHolder().toString().to...

no

#

leave that

frail brook Jul 21, 2023, 5:34 AM

#

it was buggy when i had it

#

but ok

dawn zinc Jul 21, 2023, 5:34 AM

#

copy the marked code blocl

frail brook Jul 21, 2023, 5:34 AM

#

it still didnt work when i did that too

dawn zinc Jul 21, 2023, 5:34 AM

#

and replace e. getInventory

#

with e. get clicked inventory

frail brook Jul 21, 2023, 5:34 AM

#

OHH

#

damn

dawn zinc Jul 21, 2023, 5:34 AM

#

in one of them

frail brook Jul 21, 2023, 5:34 AM

#

i didnt see that

dawn zinc Jul 21, 2023, 5:35 AM

#

so you loop through both inventories

frail brook Jul 21, 2023, 5:35 AM

#

kk

dawn zinc Jul 21, 2023, 5:37 AM

#

that issue with removing the if you removed, wouldn't allow moving the item at all, not even in the players inv, when there not in a container

frail brook Jul 21, 2023, 5:38 AM

#

now with changing it to getClickedInventory

#

it literally doesnt allow me to move anything at all even if it isnt soulitem

#

and i can still move it with numberkeys

dawn zinc Jul 21, 2023, 5:38 AM

#

yep

#

idk what you broke.
.

frail brook Jul 21, 2023, 5:39 AM

#

heres my code

#

    @EventHandler
    public void onClick(InventoryClickEvent event) {
        ItemStack currentItem = event.getCurrentItem();
        if (currentItem == null) return;

        ItemStack cursor = event.getCursor();
        if (cursor == null) return;

        Inventory clickedInventory = event.getClickedInventory();
        if (clickedInventory == null ) return;


        if(event.getInventory().getHolder().toString().toLowerCase().contains("craftplayer{name=")) return;
        try {
            for (ItemStack item : event.getClickedInventory()) {
                if (isSoulItem(item)) event.setCancelled(true);
            }
        } catch (NullPointerException ex) {

        }
        if (currentItem != null && (isSoulItem(currentItem))) {
            event.setCancelled(true);
        }
        ItemStack onCursor = event.getCursor();
        if ((isSoulItem(onCursor))){
            event.setCancelled(true);
        }
    }

    @EventHandler
    public void onInventoryDrag(InventoryDragEvent event) {
        ItemStack dragged = event.getOldCursor();
        if (isSoulItem(dragged)) {
            int inventorySize = event.getInventory().getSize();
            for (int i : event.getRawSlots()) {
                if (i < inventorySize) {
                    event.setCancelled(true);
                    break;
                }
            }
        }
    }

    @EventHandler
    public void onItemInventoryChangeEvent(InventoryMoveItemEvent event){
        if(isSoulItem(event.getItem())) {
            Bukkit.getConsoleSender().sendMessage("triggered inventory change event | is item");
            event.setCancelled(true);
            return;
        }

        Bukkit.getConsoleSender().sendMessage("triggered inventory change event | no item");
    }```

dawn zinc Jul 21, 2023, 5:39 AM

#

well I know the issue

frail brook Jul 21, 2023, 5:40 AM

#

when u use number keys it returns air

#

on

#

cursor

dawn zinc Jul 21, 2023, 5:40 AM

#

it's because we're checking if an soul item is in the players inventory and if so were canceling

frail brook Jul 21, 2023, 5:40 AM

#

AND currentitem?

dawn zinc Jul 21, 2023, 5:40 AM

#

yes

frail brook Jul 21, 2023, 5:40 AM

#

dawn zinc it's because we're checking if an soul item is in the players inventory and if s...

true but what else can we do

#

since we cant even detect what their doing if they use number keys

dawn zinc Jul 21, 2023, 5:40 AM

#

we can

#

great idea

#

make an if statment

#

check if e.getClickType() == InventoryClick.HOTBAR_SWAP

#

it should be smth like tgat

frail brook Jul 21, 2023, 5:41 AM

#

yeah ive tried that but u acnt even detect what ur hotbar swapping

#

so that would remove hotbar swapping

dawn zinc Jul 21, 2023, 5:42 AM

#

you have to check the wiki, what click type get

frail brook Jul 21, 2023, 5:42 AM

#

fore verything

dawn zinc Jul 21, 2023, 5:42 AM

#

that would disable hot keys in the inventory

#

check the docs what click type gets triggered by a hotkey

frail brook Jul 21, 2023, 5:43 AM

#

its hotbarswap

#

u were right

dawn zinc Jul 21, 2023, 5:43 AM

#

put that around that if statement around the try and catch statments

#

so it will block hot key, if there is an soul item in the invebtory

frail brook Jul 21, 2023, 5:43 AM

#

im kinda tryna not do that though

#

because the player will always have a soul item and i use the hotkey thing alot

#

wait

#

wahts that one api

#

protocol lib

#

doesnt it like make spigot better or smt

dawn zinc Jul 21, 2023, 5:45 AM

#

it gives you packets

frail brook Jul 21, 2023, 5:45 AM

#

oh

dawn zinc Jul 21, 2023, 5:46 AM

#

if you add the if statement, it will only block the hot keys while you are viewing another inventory

#

you can move it without a problem if you are in ur own inv

frail brook Jul 21, 2023, 5:47 AM

#

do u think if i payed you or someone else some money, you or they could fix my problem and figure out a way to not do that?

dawn zinc Jul 21, 2023, 5:47 AM

#

I'd probably go about editing the source code of spigot if I'd have to fix it, but that would be rather unconventional

dawn zinc Jul 21, 2023, 5:48 AM

#

frail brook do u think if i payed you or someone else some money, you or they could fix my p...

You could try, but developers usually do commissions

frail brook Jul 21, 2023, 5:49 AM

#

i might pay someone like $5 to do it because it seems simple

#

this has been an ongoing problem for way too long

dawn zinc Jul 21, 2023, 5:53 AM

#

I think I found a fix

frail brook Jul 21, 2023, 5:53 AM

#

what

#

ok

#

i hate dynamically typed languages because im used to static ones 💀

dawn zinc Jul 21, 2023, 5:53 AM

#

but I'm not home rn

frail brook Jul 21, 2023, 5:53 AM

#

explain it to me

#

i could write it

dawn zinc Jul 21, 2023, 5:54 AM

#

I'll take a look when I'm home

frail brook Jul 21, 2023, 5:54 AM

#

alr

#

what time is it for u btw

dawn zinc Jul 21, 2023, 7:25 AM

#

9:25 AM

frail brook Jul 21, 2023, 7:26 AM

#

alr

dawn zinc Jul 21, 2023, 11:49 AM

#

my fix sdidnt work

#

rip

#

ur gna have to work wiht what you have

#prevent pdc item from being put in container