nms 😋😋 | SpigotMC | Page 1

hybrid shuttle Sep 17, 2022, 3:12 PM

#

ok so

#

alright uhh

austere knot Sep 17, 2022, 3:12 PM

#

one sec let me look up the CB collision code

hybrid shuttle Sep 17, 2022, 3:13 PM

#

yeah im doing that aswell

austere knot Sep 17, 2022, 3:16 PM

#

    @Override
    public void setCollidable(boolean collidable) {
        getHandle().collides = collidable;
    }```So now for the NMS

hybrid shuttle Sep 17, 2022, 3:16 PM

#

using 1.19 :D

#

the ServerLevel thingy has something related to collisio

#

CollisionGetter

#

or i could just

#

this.getbukkitentity.setcollidable(false)

#

((LivingEntity)this.getBukkitEntity()).setCollidable(false);

austere knot Sep 17, 2022, 3:20 PM

#

yes but you are using packets so there should be no BukkitEntity

hybrid shuttle Sep 17, 2022, 3:20 PM

#

the husk is still a BukkitEntity

#

the NPC isnt

austere knot Sep 17, 2022, 3:20 PM

#

not if you created it using packets

#

If you actually spawned it, then yes

hybrid shuttle Sep 17, 2022, 3:20 PM

#

i created the husk using actual spawn mechanisms

austere knot Sep 17, 2022, 3:21 PM

#

ok then it really exists so set it to not collidable

hybrid shuttle Sep 17, 2022, 3:21 PM

#

well now the npc cant collide with the husk

#

ok done

#

hold up lemme launch mc

#

ok uhh

#

nothing changed

#

ive noticed that the npcs spawn in the proper coordinates

#

and then get teleported somewhere else

#

and the husks are invisible

austere knot Sep 17, 2022, 3:36 PM

#

did you set the husks invisible?

hybrid shuttle Sep 17, 2022, 3:37 PM

#

nope

#

rejoining makes them appear

austere knot Sep 17, 2022, 3:37 PM

#

Also npcs spawning in the correct place and then teleporting points to your code moving them

hybrid shuttle Sep 17, 2022, 3:37 PM

#

wait

austere knot Sep 17, 2022, 3:37 PM

#

invisible when first spawned sounds like a lot of errors in your code

hybrid shuttle Sep 17, 2022, 3:38 PM

#

📎 npc.java

#

📎 zombei.java

#

top one is npc code

#

bottom is custom zombie class

austere knot Sep 17, 2022, 3:40 PM

#

um your spawn packet doesn;t actually spawn the NPC

hybrid shuttle Sep 17, 2022, 3:40 PM

#

its appearing tho

#

on the tab and on the screen

#

could you elaborate why

austere knot Sep 17, 2022, 3:42 PM

#

You likely also need to call addToWorld on the npc

#

nmsWorld.addNewPlayer(npc)

hybrid shuttle Sep 17, 2022, 3:43 PM

#

doesnt do anything

#

its the same

austere knot Sep 17, 2022, 3:45 PM

#

it also look like your pitch/yaw is also reversed

#

        this.setXRot(pitch);```

#

this is what I use instead of yrou send join packets

#

    private static void showAll(Npc npc) {

        ClientboundPlayerInfoPacket playerInfoAdd = new ClientboundPlayerInfoPacket(ClientboundPlayerInfoPacket.Action.ADD_PLAYER, npc);
        ClientboundAddPlayerPacket playerSpawn = new ClientboundAddPlayerPacket(npc);
        ClientboundRotateHeadPacket headRotation = new ClientboundRotateHeadPacket(npc, (byte) Math.floor(npc.getYHeadRot() * 256f / 360f));
        ClientboundPlayerInfoPacket playerInfoRemove = new ClientboundPlayerInfoPacket(ClientboundPlayerInfoPacket.Action.REMOVE_PLAYER, npc);
        
        // For Entities (packet based) require this packet for skins.
        //ClientboundSetEntityDataPacket entityData = new ClientboundSetEntityDataPacket(npc.getId(), npc.getEntityData(), true);

        for (Player player : Bukkit.getOnlinePlayers()) {
            ServerGamePacketListenerImpl connection = ((ServerPlayer) NMSUtils.getServerPlayer(player)).connection;
            connection.send(playerInfoAdd);        // Inform client this Entity exists.
            connection.send(playerSpawn);    // Spawn this entity on the client.
            //connection.send(entityData);    // EntityData (Packet based Entity) to show skins.
            connection.send(headRotation);
            connection.send(playerInfoRemove);    // Remove from servers tab list
        }
    }```

#

that last one for removing player info may mess with skins. I've not tested that fully

#

it removesd them from the Tab but skins are also pulled from there

hybrid shuttle Sep 17, 2022, 4:00 PM

#

alr imma try yours

austere knot Sep 17, 2022, 4:06 PM

#

I can;t see you updating the ServerPlayer location after its spawned. You just send calculated update packets

#

if the Zombie moves you can simply teleport the ServerPlayer to the same location. The client will extrapolate movement

hybrid shuttle Sep 17, 2022, 4:10 PM

#

what do i use for teleportation?

austere knot Sep 17, 2022, 4:10 PM

#

it has a bukkit entity so you can just teleport that

hybrid shuttle Sep 17, 2022, 4:10 PM

#

public void move(double x, double y, double z){
        ServerPlayer npc = instance;
        Bukkit.getOnlinePlayers().forEach(player -> {
            ServerGamePacketListenerImpl packetSender = ((CraftPlayer) player).getHandle().connection;
            packetSender.send(new ClientboundMoveEntityPacket.Pos(npc.getId(), (short) (x * 4096), (short) (y * 4096), (short) (z * 4096), true));
        });
    }```

#

oh

#

its still a packet entity tho

austere knot Sep 17, 2022, 4:10 PM

#

no its never a packet entity as you spawn it

hybrid shuttle Sep 17, 2022, 4:10 PM

#

the npc i mean

austere knot Sep 17, 2022, 4:11 PM

#

yes, your npc is a full blown entity

hybrid shuttle Sep 17, 2022, 4:11 PM

#

wow

austere knot Sep 17, 2022, 4:11 PM

#

you spawned it so its no longer a packet entity

hybrid shuttle Sep 17, 2022, 4:14 PM

#

nope it just does not move anymore

#

but it spawns and stays at the correct coordinates

#

so the move method probably may be the problem

#

public void move(Entity entity){
//        Bukkit.getOnlinePlayers().forEach(player -> {
//            ServerGamePacketListenerImpl packetSender = ((CraftPlayer) player).getHandle().connection;
//            packetSender.send(new ClientboundMoveEntityPacket.Pos(this.instance.getId(), (short) (x * 4096), (short) (y * 4096), (short) (z * 4096), true));
//        });
        this.instance.getBukkitEntity().teleport(entity);
    }```

#

npc.move(this.getBukkitEntity());

#

this is in the tick method

#

this is teh husk

#

hold up lemme try coords

#

yep they do not work

#nms 😋😋