theme.palette.mode always returns light even when dark theme used | Backstage | Page 1

versed oxide Aug 2, 2024, 3:31 PM

#

I had the following code (running on Backstage 1.27)

const labelTheme = useMemo(
    () => (theme.palette.mode === 'dark' ? darkLabelTheme : lightLabelTheme),
    [theme.palette.mode],
  );

When attempting to upgrade to 1.29.2 theme.palette.mode always returns light. I'm using useTheme from @mui/material/styles as I'm using MUI v5 components.

Any idea what's changed or how to fix this?

fleet juniper Aug 6, 2024, 9:02 PM

#

Hi @versed oxide, haven’t personally ran into this as I generally have avoided this pattern. I do think there was an issues logged about it.

versed oxide Aug 6, 2024, 9:02 PM

#

Hey good timing as I JUST resolved it

#

running yarn dedupe…

#

And downgrading mui to 5.14

#

From 5.15 but not sure which of the two fixed it yet

fleet juniper Aug 6, 2024, 9:04 PM

#

That sounds roughly what I remember about this.

#theme.palette.mode always returns light even when dark theme used