Node-API related segmentation fault | Deno | Page 1

harsh ruin Jul 26, 2023, 4:27 PM

#

Any idea what could be causing this crash? I'm using Node-API and the same module is working fine in Node.js. Can't figure out the exact part causing this to create a reproducible example 🤔

#

cc @dusk pilot any idea?

#

so it comes down to this specific part. Let me check what could be causing this in native land

harsh ruin Jul 26, 2023, 4:53 PM

#

So the error comes down to napi_create_external

#

seems that finalizer cb being null is not handled correctly in deno

dusk pilot Jul 27, 2023, 5:41 AM

#

oh huh

#

whats being finalized?

harsh ruin Jul 27, 2023, 7:59 AM

#

I created an external with no finalizer callback (nullptr) and

deno just treats it as normal c callback and goes ahead to call it sometime
node will check if its null then its not called

tawny sedge Jul 27, 2023, 8:13 AM

#

You never know if someone has placed a function at memory slot 0... (Apparently in some architectures it is a valid memory address.)

harsh ruin Jul 28, 2023, 7:32 AM

#

tawny sedge You never know if someone has placed a function at memory slot 0... (Apparently ...

that’s probably a case to not worry about 😆 in standard conforming C/C++ implementations, I guess it is possible to reliably set a function pointer to null.

#Node-API related segmentation fault