Deno Runtime Extension with JS File | Deno | Page 1

peak grotto Dec 17, 2022, 9:25 AM

#

When i include js files with

Extension::builder()
  .js(include_js_files!(prefix "prefix", "file.js")
  .build()

Do i need to call these js files somehow? Can't find any reference in the source code, would really appreciate your help 😄

ashen axle Dec 17, 2022, 12:54 PM

#

those will be ran at start up before the user code is ran iirc

peak grotto Dec 17, 2022, 1:32 PM

#

Doesn't look like it is doing anything with it. Tried console.log, deno.core.print, also tried calling something that doesn't exist to provoke a error from the runtime... but nothing... as if it would be ignored

ashen axle Dec 17, 2022, 1:53 PM

#

is it bound to any object in javascript like on the GlobalThis etc

peak grotto Dec 17, 2022, 1:56 PM

#

I think so, i tried this

"use strict";

((window) => {
  // then do stuff here like
  Deno.exit(-1);
  // or
  somethingThatDoesNotExist();
})(globalThis);

Like in other scripts from deno, but nothing happens

ashen axle Dec 17, 2022, 1:57 PM

#

Is that script you are adding via include file?

#

I believe your extension ops are bound on Deno.core.ops and then you should bind your js glue code via the following code

((window) => {
  const ops = window.Deno.core.ops;

  function yourFunc() {
    ops.your_op_call();
  }

  window.yourFunc = yourFunc;
})(globalThis);

peak grotto Dec 17, 2022, 1:59 PM

#

ashen axle Is that script you are adding via include file?

Yes

ashen axle Dec 17, 2022, 1:59 PM

#

ashen axle I believe your extension ops are bound on `Deno.core.ops` and then you should bi...

Now you should be able to just call yourFunc as it is in the global namespace

peak grotto Dec 17, 2022, 2:01 PM

#

ashen axle I believe your extension ops are bound on `Deno.core.ops` and then you should bi...

This is exactly what i am trying to do but it does not work xD
When i try to call my custom function it says its not defined

ashen axle Dec 17, 2022, 2:01 PM

#

weird

#

what is undefined btw

#

the op or the function you expose

peak grotto Dec 17, 2022, 2:03 PM

#

The function

#

yourFunc is not defined

#

When i use Deno.core.ops.... directly it works

ashen axle Dec 17, 2022, 2:04 PM

#

can you call the IIFE with (this) instead of globalThis

#

((window) => {
  const ops = window.Deno.core.ops;

  function yourFunc() {
    ops.your_op_call();
  }

  window.yourFunc = yourFunc;
})(this);

#

Like this

peak grotto Dec 17, 2022, 2:05 PM

#

I'll try

#

Same result

ashen axle Dec 17, 2022, 2:05 PM

#

what...

#

Then idk. It should work just like this?

peak grotto Dec 17, 2022, 2:09 PM

#

Maybe i did something wrong with bootstrapping and running:

fn create_main_worker() -> Result<MainWorker, Error> {
    let mut worker = MainWorker::bootstrap_from_options(
        deno_core::resolve_url_or_path(deno_core::DUMMY_SPECIFIER)?,
        Permissions::allow_all(),
        WorkerOptions {
            extensions: vec![
                Extension::builder()
                    .ops(vec![
                        op_get_header::decl()
                    ])
                    .js(include_js_files!(
                        prefix "prefix:idk",
                        "js/01_helpers.js",
                    ))
                    .build()
            ],
            ..Default::default()
        },
    );

    Ok(worker)
}

async fn run_worker() -> Result<(), Error> {
    let mut runtime = create_main_worker()?;
    let module = deno_core::resolve_url_or_path("bundle.js")?;

    runtime.execute_main_module(&module).await?;
    runtime.run_event_loop(false).await?;

    Ok(())
}

Also debugged it, and the script that is embedded is correct

#

Maybe because of the "dummy specifier"?

ashen axle Dec 17, 2022, 2:13 PM

#

you mean the "prefix:idk"

#

I don't think that matters

peak grotto Dec 17, 2022, 2:14 PM

#

i mean that i bootstrap the runtime with deno_core::DUMMY_SPECIFIER instead of the real script

ashen axle Dec 17, 2022, 2:14 PM

#

I don't think that should matter? not sure tho

peak grotto Dec 17, 2022, 2:15 PM

#

I will try with the real script

#

Still undefined

snow moon Dec 17, 2022, 2:36 PM

#

If you don't use snapshots you need to pass it as extensions_with_js

peak grotto Dec 17, 2022, 2:41 PM

#

snow moon If you don't use `snapshots` you need to pass it as `extensions_with_js`

Ok, i see this option in the JsRuntime but not in MainWorker, how do i pass this then?

snow moon Dec 17, 2022, 2:50 PM

#

errr, good question

#

@hearty ocean ?

hearty ocean Dec 17, 2022, 3:14 PM

#

uhh, lemme check

#

i didnt follow the entire discussion, but @peak grotto are you using deno_core or deno_runtime?

peak grotto Dec 17, 2022, 3:17 PM

#

deno_runtime

#

And MainWorker doesn't let you use extensions_with_js

#

Or at least, i couldn't see an option for this

hearty ocean Dec 17, 2022, 3:30 PM

#

@peak grotto from the looks of it you need to pass it to extensions then

peak grotto Dec 17, 2022, 3:31 PM

#

hearty ocean <@272808760336973824> from the looks of it you need to pass it to `extensions` t...

Yeah but the js then gets never executed, thats the main problem of this thread here

hearty ocean Dec 17, 2022, 3:31 PM

#

hmm

peak grotto Dec 17, 2022, 3:32 PM

#

Is there any workaround maybe?

hearty ocean Dec 17, 2022, 3:32 PM

#

are you using snapshot from snapshot?

peak grotto Dec 17, 2022, 3:33 PM

#

As far as i know i dont use any snapshots

peak grotto Dec 17, 2022, 3:33 PM

#

peak grotto Maybe i did something wrong with bootstrapping and running: ```rust fn create_m...

I bootstrap it like there

hearty ocean Dec 17, 2022, 3:35 PM

#

hmmm

#

what happens if you try to use an older deno_runtime version (ie 0.80.0)?

peak grotto Dec 17, 2022, 3:40 PM

#

Can't i use #[op] without depending on deno_core when deno_runtime is present? I don't know which version of deno_core i should use when using deno_runtime 0.80.0

hearty ocean Dec 17, 2022, 3:42 PM

#

deno_runtime re-exports deno_core

peak grotto Dec 17, 2022, 3:43 PM

#

Yeah but when not having deno_core in cargo.toml #[op] tells me: deno_core not present in Cargo.toml: CrateNotFound

hearty ocean Dec 17, 2022, 3:43 PM

#

huh 🤔 thats annoying

#

lemme get you the right core version

#

0.154.0

peak grotto Dec 17, 2022, 3:44 PM

#

hearty ocean huh 🤔 thats annoying

Yeah i never bothered, because it does seem to work when always using newest versions

peak grotto Dec 17, 2022, 3:44 PM

#

hearty ocean 0.154.0

Thanks 😄

peak grotto Dec 17, 2022, 3:50 PM

#

hearty ocean what happens if you try to use an older deno_runtime version (ie 0.80.0)?

Nothing changes (it doesn't seem to execute the script), but i do see the code inlined correctly (as always)

hearty ocean Dec 17, 2022, 3:50 PM

#

hm ok looking into it

peak grotto Dec 17, 2022, 3:50 PM

#

Thanks 🙂

peak grotto Dec 17, 2022, 4:56 PM

#

Could MainWorker not just expose the extensions_with_js Option?

hearty ocean Dec 17, 2022, 5:34 PM

#

yes.

#

https://github.com/denoland/deno/pull/17109

GitHub

fix(runtime): expose `extensions_with_js` from WorkerOptions by cro...

peak grotto Dec 17, 2022, 5:54 PM

#

Nice

peak grotto Dec 17, 2022, 7:07 PM

#

hearty ocean https://github.com/denoland/deno/pull/17109

Can you tell when I can expect this to be merged/released (i do see some failed pipelines)?

Also, should i open an issue about #[op] requiring deno_core to be in the cargo.toml, even if deno_runtime is present?

hearty ocean Dec 17, 2022, 7:08 PM

#

Can you tell when I can expect this to be merged/released (i do see some failed pipelines)?
possibly next week

#

Also, should i open an issue about #[op] requiring deno_core to be in the cargo.toml, even if deno_runtime is present?
cc @strong tundra

#Deno Runtime Extension with JS File