burnt moth
Hi everyone! This is my first solo project and I'd be really grateful for any feedback on how my code can be improved!
Netlify: https://rek-daily-dribble-7294.netlify.app/
Scrim: https://scrimba.com/learn-html-and-css-c0p/~01b/s0d5gr3kia/head
I've taken some pointers from some existing code reviews here.
In particular is there any way I can improve the conciseness of my code?
Thanks in advance 😄
grave grove
I can see you went through previous code reviews. Everything thats usually missing (bc it hasn't been taught yet I believe) you have. The alt attr on the img, you wrapped the form element, used input[type=email] instead of text. One h1.
Nice job! Which means I have room to dig into your css.
You've declared text align:center on thr body which means it inherits down (ad most text and font-* properties do). So no need to redeclare on h1 or p.
You could use inheritance to declare color: #121212 on the body as well and then wouldn't need to declare everywhere. A fun trick is that border color default to the currentColor so if you want it the same color this border: 1px solid; is the same as
body {
color: #121212;
}
img { border: 1px solid #121212;}
Also, h1 is display: block by default. (Same as div, h2-h6, p, section, article, etc).