#Octeracts tab opening without unlock
12 messages · Page 1 of 1 (latest)
Just unlocked Octeracts, and now EXALT is opening despite me not having unlocked that. I think this is caused by Penalties and Perks being merged into one tab?
@warm flume
a
I tried to be thorough in regards to where singularity.tab was being referenced and the knock on effects of penalties being merged in, most likely though I may have missed some errant unlock that reffers back to it. 
I can try taking another look when I get back home from work today.
to add to this, if i'm on the ambrosia tab and press down, i see a blank page
Pretty sure this is the culprit, in Tabs.ts:
return player.highestSingularityCount > 0
}, buttonID: 'toggleSingularitySubTab1' },
{ subTabID: 2, get unlocked () {
return player.highestSingularityCount > 0
}, buttonID: 'toggleSingularitySubTab2' },
{ subTabID: 3, get unlocked () {
return player.highestSingularityCount > 0
}, buttonID: 'toggleSingularitySubTab3' },
{ subTabID: 4, get unlocked () {
return Boolean(player.singularityUpgrades.octeractUnlock.getEffect().bonus)
}, buttonID: 'toggleSingularitySubTab4' },
{ subTabID: 5, get unlocked () {
return player.highestSingularityCount >= 25
}, buttonID: 'toggleSingularitySubTab5' },
{ subTabID: 6, get unlocked () {
return player.singularityChallenges.noSingularityUpgrades.completions >= 1
}, buttonID: 'toggleSingularitySubTab6'```
And changing to this should fix it:
return player.highestSingularityCount > 0
}, buttonID: 'toggleSingularitySubTab1' },
{ subTabID: 2, get unlocked () {
return player.highestSingularityCount > 0
}, buttonID: 'toggleSingularitySubTab2' },
{ subTabID: 3, get unlocked () {
return Boolean(player.singularityUpgrades.octeractUnlock.getEffect().bonus)
}, buttonID: 'toggleSingularitySubTab3' },
{ subTabID: 4, get unlocked () {
return player.highestSingularityCount >= 25
}, buttonID: 'toggleSingularitySubTab4' },
{ subTabID: 5, get unlocked () {
return player.singularityChallenges.noSingularityUpgrades.completions >= 1
}, buttonID: 'toggleSingularitySubTab5'```
Ah, yeah that'd do it
Been trying to look around as well for hotkeys and seeing how that shit works, to no avail
hopefully this would also fix the hotkeys?
I assume you're referring to this (https://discord.com/channels/677271830838640680/1117408027243462696), but the hotkeys are broken that way in all tabs, not just Singularity. That looks like a problem with keyboardTabChange (also in Tabs.ts) or something that's accesed by it.
Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.
https://github.com/Pseudo-Corp/SynergismOfficial/pull/515 PR made, ping for @spare flare whenever ya get the chance to merge (very smol fix so should be no issue with merging).