#Code Review and Upvote on github

3 messages Β· Page 1 of 1 (latest)

radiant geode
rich parcel
#

I think the task-tracker-cli.log shouldn't be included in the git repo.
I don't know why you put TaskStatus in a constants package - doesn't it fit better in domain (it's a part of your domain, right?)
Things like markInProgress could throw a TaskNotFoundException which I think you didn't catch.
I think it should be called getAllTasks/getTasksByStatus (plural).
You might want to consider making a defensive copy in TaskRepositoryImpl#getAllTask.

#

And while this doesn't matter in this case because you are always just doing one operation per invocation of the program, you are checking the entire task list for some operations (e.g. generateNewId() or getTaskById).