Java JDA add custom new API request optimisation | Java Community | Help. Code. Learn. | Page 1

knotty echo Jul 20, 2024, 5:14 PM

#

    private String avatar_decoration_asset_id(User u){

           RestActionImpl<String> restAction = new RestActionImpl<>(u.getJDA(), Route.Users.GET_USER.compile(u.getId()), (response, request) -> {

               DataObject json = response.getObject();
               if (json.isNull("avatar_decoration_data")){ return "none";}
               String id = json.getObject("avatar_decoration_data").getString("asset");
               return id;
           });

        try {
            return restAction.complete(true);
        } catch (RateLimitedException e) {
            System.out.println(e);
            return "none";
        }

    }

i need to find out if this is the optimal way, i guess no, cause i somehow need to make it .queue(); so i can iterate through user list. But here is the thing i dont get.

If i make a forloop and iterate throuhg the list and then use this as my queue, how the foorloop supposed to know that the queue was sent already

tribal vaultBOT Jul 20, 2024, 5:14 PM

#

⌛ This post has been reserved for your question.

Hey @knotty echo! Please use /close or the Close Post button above when your problem is solved. Please remember to follow the help guidelines. This post will be automatically closed after 300 minutes of inactivity.

TIP: Narrow down your issue to simple and precise questions to maximize the chance that others will reply in here.

knotty echo Jul 20, 2024, 5:14 PM

#

and if i make .queue(); the return type is void, so i cant get the string back. so how to fix it that it properly use the queue

royal scroll Jul 20, 2024, 5:16 PM

#

the queue method can take a Consumer as its argument

#

And today you learned how to use Consumers, so that's quite convenient

knotty echo Jul 20, 2024, 5:17 PM

#

yeah i use that usualy to delete the original message. but i dunno what else i should consume there 😄

#

like can i consume a return type there and if i would do that, i need to safe the "variable" somewhere

royal scroll Jul 20, 2024, 5:17 PM

#

If you want to return the result, it's better to stay with complete

knotty echo Jul 20, 2024, 5:18 PM

#

yeah but then it ratelimits and i cannot iterate throuhg whole list

royal scroll Jul 20, 2024, 5:18 PM

#

It will ratelimit even if you use queue, eventually

knotty echo Jul 20, 2024, 5:20 PM

#

mh ```java
restAction.queue(a -> return this, b -> {});

#

that doesnt work

royal scroll Jul 20, 2024, 5:20 PM

#

You can't return an object from lambda/anonymous class

#

But

#

You can make avatar_decoration_asset_id return RestAction

#

and then do avatar_decoration_asset_id(...).queue(obj -> {...});

#

That's a good compromise

knotty echo Jul 20, 2024, 5:22 PM

#

yeah thats confusing again, i can return the whole interface?

#

dont i need the RestActionImpl

royal scroll Jul 20, 2024, 5:22 PM

#

Of course you can

knotty echo Jul 20, 2024, 5:22 PM

#

or whats the point of the Impl

royal scroll Jul 20, 2024, 5:23 PM

#

Impl means Implementation (in that case)

#

That class implements RestAction

#

But if that's confusing for you, tou can just return RestActionImpl as well

#

Doesn't make any difference in that case

knotty echo Jul 20, 2024, 5:24 PM

#

    private RestAction avatar_decoration_asset_id(User u){

           RestActionImpl<String> restAction = new RestActionImpl<>(u.getJDA(), Route.Users.GET_USER.compile(u.getId()), (response, request) -> {

               DataObject json = response.getObject();
               if (json.isNull("avatar_decoration_data")){ return "none";}
               String id = json.getObject("avatar_decoration_data").getString("asset");
               return id;
           });

            return restAction;

    }

                for (Member member : guild.getMembers()) {
                    avatar_decoration_asset_id(member.getUser()).queue();
                }

#

i still need to parse the id somehow now

royal scroll Jul 20, 2024, 5:24 PM

#

That'll ratelimit quickly

#

You need to either do it in certain events, or only handle x users at a time

knotty echo Jul 20, 2024, 5:25 PM

#

yeah then i guess i keep the original with Listening on ONLINE status event

royal scroll Jul 20, 2024, 5:25 PM

#

Keep in mind that not all users change their status to ONLINE

#

Some are invisible

knotty echo Jul 20, 2024, 5:26 PM

#

yeah thats fine, i sitll have my Menue command

royal scroll Jul 20, 2024, 5:26 PM

#

Ideally you would want to listen to member joining events, and only iterate over all members once and never again

royal scroll Jul 20, 2024, 5:28 PM

#

knotty echo i still need to parse the id somehow now

Shouldn't be too hard

#

You get the asset id

#

In case of your user it's a_554b7c34f7b6c709f19535aacb128e7b

#

So the link will be https://media.discordapp.net/avatar-decoration-presets/a_554b7c34f7b6c709f19535aacb128e7b.png

#

Just do https://media.discordapp.net/avatar-decoration-presets/<asset>.png

#

And it'll be fine

knotty echo Jul 20, 2024, 5:30 PM

#

other question

#

how i can get the rhole JSON the same i get when debugging

#

printing the response doesnt work

#

printing the response.getObject gives error

royal scroll Jul 20, 2024, 5:33 PM

#

knotty echo printing the response doesnt work

How exactly doesn't it work?

#

It prints nothing?

knotty echo Jul 20, 2024, 5:34 PM

#

that only pritns httpresponse

#

and this give exception

royal scroll Jul 20, 2024, 5:38 PM

#

knotty echo and this give exception

try wrapping everything in your RestActionImpl in a try...catch and print a stack trace

knotty echo Jul 20, 2024, 5:40 PM

#

doesnt help

#

royal scroll Jul 20, 2024, 5:41 PM

#

I meant

#

Wrap what's inside

knotty echo Jul 20, 2024, 5:41 PM

#

i get the json in console tho

#

yeah it works

#

problem was i already had the bot running in background

#

so it replied twice

#

1 over the debug IDE and 1 over background bot

royal scroll Jul 20, 2024, 5:44 PM

#

So it works now?

knotty echo Jul 20, 2024, 5:44 PM

#

yep

#

thx i let this open here if i find another question regarding jda

royal scroll Jul 20, 2024, 5:48 PM

#

`kay

tribal vaultBOT Jul 21, 2024, 3:30 AM

#

💤 Post marked as dormant

This post has been inactive for over 300 minutes, thus, it has been archived.
If your question was not answered yet, feel free to re-open this post or create a new one.
In case your post is not getting any attention, you can try to use /help ping.
Warning: abusing this will result in moderative actions taken against you.

knotty echo Jul 21, 2024, 7:47 AM

#

its bit buggy, like it keeps adding the more i generate (even when i the last image only 4 hearts should be generated) and the algorithm/pattern needs be better
based on google the drawImage need a while to draw, so it only works ones per loop

knotty echo Jul 21, 2024, 8:19 AM

#

#

  public static final BufferedImage janna;
    static {
        try {
            janna = ImageIO.read(JannaBot.class.getResource("/janna.png"));
        } catch (IOException e) {throw new RuntimeException(e);}
    }

    public static final BufferedImage heart;
    static {
        try {heart = ImageIO.read(JannaBot.class.getResource("/heart.png")); 
        } catch (IOException e) {throw new RuntimeException(e);}
    }

    public static List<int[]> validAreas = new ArrayList<>(); //calculate valid positions on board
    static {
        for (int x = 32; x < 480; x += 32) {
            for (int y = 32; y < 480; y += 32) {
                validAreas.add(new int[]{x, y});
            }
        }
    }

    private void DropImage(TextChannel textChannel) {

        StringBuilder debug = new StringBuilder();
        BufferedImage input = janna;

        for (int i= ThreadLocalRandom.current().nextInt(6,10);i>0;i--){ //iterrer 6 to 9 random hearts
            int[] pos = validAreas.get(ThreadLocalRandom.current().nextInt(0,validAreas.size())); //grab positions
            int x = pos[0]+ThreadLocalRandom.current().nextInt(-8,9); //Seeder so the images not 100% centered at 32x32 positions
            int y = pos[1]+ThreadLocalRandom.current().nextInt(-8,9); //Seeder so the images not 100% centered at 32x32 positions
            debug.append(i+", x:"+x+" , y:"+y).append("\n"); //debug for the embed to see what positions

            while(!input.createGraphics().drawImage(heart,x,y, null)){ //draw the thing. (Here is the bugg i guess!)
              System.out.println("wait"); // actually never happen o.O so its fast enaugh
            };
        }
        try { ImageIO.write(input,"PNG",new File("outputIMG.png"));
        } catch (IOException e) { throw new RuntimeException(e); }

        File f = new File("outputIMG.png");
        EmbedBuilder embed = new EmbedBuilder();
        embed.setTitle("JANNA").setDescription(debug).setThumbnail("attachment://outputIMG.png");
        textChannel.sendMessageEmbeds(embed.build()).addFiles(AttachedFile.fromData(f)).queue(); //Send the embed
    }

knotty echo Jul 21, 2024, 10:30 AM

#

@dreamy idol so is this thing actually open now or not? i can stilll write here. can other see this

dreamy idol Jul 21, 2024, 10:31 AM

#

it is open

knotty echo Jul 21, 2024, 10:31 AM

#

oki, cause it said archived above ^^

dreamy idol Jul 21, 2024, 10:31 AM

#

and it was unarchived the moment you sent a message

#

If you want to upload an image without saving a file, you can use FileUpload.fromData with a byte[]: https://github.com/Java-Discord/JavaBot/blob/e59239f76cce22b6b984ea59bc6ae1aea9735ae7/src/main/java/net/discordjug/javabot/systems/user_commands/leaderboard/ExperienceLeaderboardSubcommand.java#L161

GitHub

JavaBot/src/main/java/net/discordjug/javabot/systems/user_commands/...

General utility bot for the Discord Java Community - Java-Discord/JavaBot

tribal vaultBOT Jul 21, 2024, 10:33 AM

#

dreamy idol If you want to upload an image without saving a file, you can use `FileUpload.fr...

		return new Pair<MessageEmbed, FileUpload>(builder.build(), FileUpload.fromData(bytes, "leaderboard.png"));

dreamy idol Jul 21, 2024, 10:33 AM

#

and then send it with addFiles() or similar: https://github.com/Java-Discord/JavaBot/blob/e59239f76cce22b6b984ea59bc6ae1aea9735ae7/src/main/java/net/discordjug/javabot/systems/user_commands/leaderboard/ExperienceLeaderboardSubcommand.java#L190-L194

GitHub

JavaBot/src/main/java/net/discordjug/javabot/systems/user_commands/...

General utility bot for the Discord Java Community - Java-Discord/JavaBot

tribal vaultBOT Jul 21, 2024, 10:33 AM

#

dreamy idol and then send it with `addFiles()` or similar: https://github.com/Java-Discord/J...

				Pair<MessageEmbed, FileUpload> messageInfo = buildExperienceLeaderboard(event.getGuild(), page, type);
				event.getHook().sendMessageEmbeds(messageInfo.first())
					.addFiles(messageInfo.second())
					.setComponents(buildPageControls(page, type))
					.queue();

knotty echo Jul 21, 2024, 10:33 AM

#

ok thx i will take a look

#Java JDA add custom new API request optimisation