need help why is alarm triggering twice | Java Community | Help. Code. Learn. | Page 1

oak estuary Jul 14, 2023, 12:56 PM

#

java ''
/*

Student Name: Peter Drakulic
Lab Professor: Professor Daniel Cormier
Due Date: June 16
Description: This Java class retrieves and formats the current local time.
*/
package assignment2;

/** AlarmClock extends Clock and handles alarm functionality,
*including setting and checking alarm times.

@author - Peter Drakulic
@version 1.1
@since java 20

@see "Clock class for detail"
*/
public class AlarmClock extends Clock
{
//creates variables alarmHours and alarmMinutes
int alarmHours;
int alarmMinutes;

/** This method sets the alarm time by assigning the provided values for hours

and minutes to the corresponding variables.
@param hours
@param minutes
*/

public void setAlarm(int hours, int minutes)
{
alarmHours = hours;
alarmMinutes = minutes;
}

   /**
  * The provided code snippet retrieves the current time,
  * compares it to a set alarm time, and if the current time has reached or surpassed the alarm time, 
  * it returns a string indicating the time followed by the word "Alarm."
  * @return String Return Hours and minutes and Alarm.
  */

public String getTime()
{
String clockHours = getHours();
String clockMinutes = getMinutes();
int clockHoursInt = Integer.valueOf(clockHours);
int clockMinutesInt = Integer.valueOf(clockMinutes);

   /*This code checks the time and alarm, 
   *resets the alarm if the condition is met, 
   *and returns the time with or without the "Alarm" suffix.
   */
  if (clockHoursInt >= alarmHours && clockMinutesInt >= alarmMinutes)
  {
  
      alarmHours = 0;
      alarmMinutes = 0;
      
      
       return clockHoursInt + ":" + clockMinutesInt + " Alarm";
  }
  else
  {
      return clockHoursInt + ":" + clockMinutesInt;
  } 
 
}

}

weary minnowBOT Jul 14, 2023, 12:56 PM

#

⌛ This post has been reserved for your question.

Hey @oak estuary! Please use /close or the Close Post button above when you're finished. Please remember to follow the help guidelines. This post will be automatically closed after 300 minutes of inactivity.

TIP: Narrow down your issue to simple and precise questions to maximize the chance that others will reply in here.

#

java ''
/*
* Student Name: Peter Drakulic
* Lab Professor: Professor  Daniel Cormier
* Due Date: June 16
* Description: This Java class retrieves and formats the current local time.
*/
package assignment2;

/** AlarmClock extends Clock and handles alarm functionality,
*including setting and checking alarm times.
* @author - Peter Drakulic
* @version 1.1 
* @since java 20
* @see "Clock class for detail" 
*/
public class AlarmClock extends Clock 
{    
	//creates variables alarmHours and alarmMinutes
	int alarmHours;
	int alarmMinutes;
	
	/** This method sets the alarm time by assigning the provided values for hours 
	* and minutes to the corresponding variables.
	* @param hours
	* @param minutes
	*/
	
	public void setAlarm(int hours, int minutes)
	{
		alarmHours = hours;
		alarmMinutes = minutes;
	}
	
	/**
	* The provided code snippet retrieves the current time,
	* compares it to a set alarm time, and if the current time has reached or surpassed the alarm time, 
	* it returns a string indicating the time followed by the word "Alarm."
	* @return String Return Hours and minutes and Alarm.
	*/
	public String getTime() 
	{
		String clockHours = getHours(); 
		String clockMinutes = getMinutes();
		int clockHoursInt = Integer.valueOf(clockHours);
		int clockMinutesInt = Integer.valueOf(clockMinutes);
		
		/*This code checks the time and alarm, 
		*resets the alarm if the condition is met, 
		*and returns the time with or without the "Alarm" suffix.
		*/
		if (clockHoursInt >= alarmHours && clockMinutesInt >= alarmMinutes)
		{
			
			alarmHours = 0;
			alarmMinutes = 0;
			
			
			return clockHoursInt + ":" + clockMinutesInt + " Alarm";
		}
		else
		{
			return clockHoursInt + ":" + clockMinutesInt;
		} 
		
	}
}

north arrow Jul 14, 2023, 1:01 PM

#

What exactly is happening?

#

And I don't see anything triggering here

oak estuary Jul 14, 2023, 1:02 PM

#

north arrow What exactly is happening?

this is output 08:57, Clock
08:57, WorldClock
8:57 Alarm, AlarmClock
8:57 Alarm, AlarmClock

#

why twice alarm

north arrow Jul 14, 2023, 1:03 PM

#

You haven't shared the code printing that

oak estuary Jul 14, 2023, 1:04 PM

#

north arrow You haven't shared the code printing that

one sec

weary minnowBOT Jul 14, 2023, 1:04 PM

#

north arrow Jul 14, 2023, 1:04 PM

#

that command is for formatting existing code

#

And I think that message is too long

oak estuary Jul 14, 2023, 1:05 PM

#

the bot is thinkin

#

/*

Student Name: Peter Drakulic
Lab Professor: Professor Daniel Cormier
Due Date: June 16
Description: AlarmClockDemo displays clocks with current time and class names.
*/
package assignment2;

/** The "AlarmClockDemo" class creates instances of different clocks

and displays their current time and class name.
@version 1.1
@since java 20

@see "AlarmClock class for detail"
*/
public class AlarmClockDemo
{

  public static void main(String[] args)
  {
        //The code creates an array of Clock objects and assigns a new Clock instance to the first element.
        Clock[] clocks = new Clock[4];
        clocks[0] = new Clock();
        
        //Creates a WorldClock object with a -4 hour time offset and adds it to the "clocks" array.
        WorldClock wClock = new WorldClock(-4);
        clocks[1] =  wClock;
        
        
        //This code creates an AlarmClock instance, sets the alarm to 17:01, and assigns it to the "clocks" array.
        AlarmClock aClock = new AlarmClock();
        aClock.setAlarm(8,36);
        clocks[2] = aClock;
        
        clocks[3] = aClock;
        
        
        //This loop prints the time and class name of each clock object in an array.
        for (int i = 0; i < clocks.length; i++) 
        {
            
           String time = clocks[i].getTime();
           System.out.println(time + ", " + clocks[i].getClass().getSimpleName());
             
        }
        
        
        
    
    
    
    
    
    
    
 }

}

north arrow Jul 14, 2023, 1:05 PM

#

oak estuary the bot is thinkin

probably because it cannot process a message

#

that command is a bit weird

weary minnowBOT Jul 14, 2023, 1:05 PM

#

/*
 * Student Name: Peter Drakulic
 * Lab Professor: Professor  Daniel Cormier
 * Due Date: June 16
 * Description: AlarmClockDemo displays clocks with current time and class names.
 */    
package assignment2;
    
/** The "AlarmClockDemo" class creates instances of different clocks 
 * and displays their current time and class name.
* @version 1.1 
* @since java 20
* @see "AlarmClock class for detail" 
*/
    public class AlarmClockDemo 
    {
        
        public static void main(String[] args)
        {
              //The code creates an array of Clock objects and assigns a new Clock instance to the first element.
              Clock[] clocks = new Clock[4];
              clocks[0] = new Clock();
              
              //Creates a WorldClock object with a -4 hour time offset and adds it to the "clocks" array.
              WorldClock wClock = new WorldClock(-4);
              clocks[1] =  wClock;
              
              
              //This code creates an AlarmClock instance, sets the alarm to 17:01, and assigns it to the "clocks" array.
              AlarmClock aClock = new AlarmClock();
              aClock.setAlarm(8,36);
              clocks[2] = aClock;
              
              clocks[3] = aClock;
              
              
              //This loop prints the time and class name of each clock object in an array.
              for (int i = 0; i < clocks.length; i++) 
              {
                  
                 String time = clocks[i].getTime();
                 System.out.println(time + ", " + clocks[i].getClass().getSimpleName());
                   
              }
              
              
              
          
          
          
          
          
          
          
       }
    
}

north arrow Jul 14, 2023, 1:06 PM

#

weary minnow ```java /* * Student Name: Peter Drakulic * Lab Professor: Professor Daniel C...

So you have your AlarmClock in the array twice

#

both clocks[2] and clocks[3] is your AlarmClock

oak estuary Jul 14, 2023, 1:07 PM

#

ok thanks

weary minnowBOT Jul 14, 2023, 1:07 PM

#

oak estuary ok thanks

If you are finished with your post, please close it.
If you are not, please ignore this message.
Note that you will not be able to send further messages here after this post have been closed but you will be able to create new posts.

oak estuary Jul 14, 2023, 1:10 PM

#

nnow i lost hte word alarm in the output

#

8:57 Alarm, AlarmClock

#

alarm is missing now

north arrow Jul 14, 2023, 1:15 PM

#

What exactly did you change?

oak estuary Jul 14, 2023, 1:15 PM

#

north arrow What exactly did you change?

removed clocks[3] = aClock;

north arrow Jul 14, 2023, 1:16 PM

#

Are you getting an error?

oak estuary Jul 14, 2023, 1:16 PM

#

north arrow Are you getting an error?

no but 8:57 Alarm, AlarmClock the word alarm is missing rn

north arrow Jul 14, 2023, 1:16 PM

#

What exactly is the output you get?

#

And is the program stopping?

oak estuary Jul 14, 2023, 1:17 PM

#

09:17, Clock
09:17, WorldClock
9:17, AlarmClock

north arrow Jul 14, 2023, 1:18 PM

#

I have an idea what could have gone wrong

#

You have that:

Clock[] clocks = new Clock[4];

#

but you only have 3 clocks, right?

oak estuary Jul 14, 2023, 1:18 PM

#

north arrow but you only have 3 clocks, right?

yeah

north arrow Jul 14, 2023, 1:19 PM

#

then maybe change it to

Clock[] clocks = new Clock[4];

#

I assume that in your loop, it fails because it is trying to access clocks[3] which is null

#

normally, that would show an error message but I assume your IDE suspends the program at that point

oak estuary Jul 14, 2023, 1:20 PM

#

north arrow I assume that in your loop, it fails because it is trying to access `clocks[3]` ...

now i got an error messsage

north arrow Jul 14, 2023, 1:21 PM

#

What's the error message?

oak estuary Jul 14, 2023, 1:22 PM

#

north arrow What's the error message?

Exception in thread "main" java.lang.NullPointerException: Cannot invoke "assignment2.Clock.getTime()" because "clocks[i]" is null
at assignment2/assignment2.AlarmClockDemo.main(AlarmClockDemo.java:41)

north arrow Jul 14, 2023, 1:22 PM

#

Can you show your current code again?

oak estuary Jul 14, 2023, 1:23 PM

#

Exception in thread "main" java.lang.NullPointerException: Cannot invoke "assignment2.Clock.getTime()" because "clocks[i]" is null
at assignment2/assignment2.AlarmClockDemo.main(AlarmClockDemo.java:41)

north arrow Jul 14, 2023, 1:23 PM

#

I feel like you didn't recompile the code properly

oak estuary Jul 14, 2023, 1:23 PM

#

/*

Student Name: Peter Drakulic
Lab Professor: Professor Daniel Cormier
Due Date: June 16
Description: This Java class retrieves and formats the current local time.
*/
package assignment2;

/** AlarmClock extends Clock and handles alarm functionality,
*including setting and checking alarm times.

@author - Peter Drakulic
@version 1.1
@since java 20
@see "Clock class for detail"
*/
public class AlarmClock extends Clock
{
//creates variables alarmHours and alarmMinutes
int alarmHours;
int alarmMinutes;

/** This method sets the alarm time by assigning the provided values for hours
- and minutes to the corresponding variables.
- @param hours
- @param minutes
  */
public void setAlarm(int hours, int minutes)
{
alarmHours = hours;
alarmMinutes = minutes;
}

/**
- The provided code snippet retrieves the current time,
- compares it to a set alarm time, and if the current time has reached or surpassed the alarm time,
- it returns a string indicating the time followed by the word "Alarm."
- @return String Return Hours and minutes and Alarm.
  */
  public String getTime()
  {
  String clockHours = getHours();
  String clockMinutes = getMinutes();
  int clockHoursInt = Integer.valueOf(clockHours);
  int clockMinutesInt = Integer.valueOf(clockMinutes);
  
  /*This code checks the time and alarm,
  *resets the alarm if the condition is met,
  *and returns the time with or without the "Alarm" suffix.
  */
  if (clockHoursInt >= alarmHours && clockMinutesInt >= alarmMinutes)
  {
```
  alarmHours = 0;
  alarmMinutes = 0;
  
  
  return clockHoursInt + ":" + clockMinutesInt + " Alarm";
```
  }
  else
  {
  return clockHoursInt + ":" + clockMinutesInt;
  }
}
}

north arrow Jul 14, 2023, 1:23 PM

#

I meant the main class

oak estuary Jul 14, 2023, 1:23 PM

#

/*

Student Name: Peter Drakulic
Lab Professor: Professor Daniel Cormier
Due Date: June 16
Description: AlarmClockDemo displays clocks with current time and class names.
*/
package assignment2;

/** The "AlarmClockDemo" class creates instances of different clocks

and displays their current time and class name.
@author - Peter Drakulic
@version 1.1
@since java 20

@see "AlarmClock class for detail"
*/
public class AlarmClockDemo
{

  public static void main(String[] args)
  {
        //The code creates an array of Clock objects and assigns a new Clock instance to the first element.
      Clock[] clocks = new Clock[4];
        clocks[0] = new Clock();
        
        //Creates a WorldClock object with a -4 hour time offset and adds it to the "clocks" array.
        WorldClock wClock = new WorldClock(-4);
        clocks[1] =  wClock;
        
        
        //This code creates an AlarmClock instance, sets the alarm to 17:01, and assigns it to the "clocks" array.
        AlarmClock aClock = new AlarmClock();
        aClock.setAlarm(17,1);
        clocks[2] = aClock;
        
        
        
        //This loop prints the time and class name of each clock object in an array.
        for (int i = 0; i < clocks.length; i++) 
        {
            
           String time = clocks[i].getTime();
           System.out.println(time + ", " + clocks[i].getClass().getSimpleName());
             
        }
        
        
        
    
    
    
    
    
    
    
 }

}

#

sent

north arrow Jul 14, 2023, 1:23 PM

#

yeah that's as expected

#

because Clock[] clocks = new Clock[4]; has space for 4 clocks

#

but you only put in 3

#

and when looping, you try to access all 4

#

which doesn't work as the last one doesn't exist

oak estuary Jul 14, 2023, 1:24 PM

#

so?

north arrow Jul 14, 2023, 1:24 PM

#

So you'd need to change the Clock[] clocks = new Clock[4] to Clock[] clocks = new Clock[3]

oak estuary Jul 14, 2023, 1:24 PM

#

thats not what i want

north arrow Jul 14, 2023, 1:24 PM

#

?

oak estuary Jul 14, 2023, 1:24 PM

#

this is my output 09:24, Clock
09:24, WorldClock
9:24, AlarmClock

#

what i want is

#

09:24, Clock
09:24, WorldClock
9:24, alarm AlarmClock

north arrow Jul 14, 2023, 1:25 PM

#

yes

oak estuary Jul 14, 2023, 1:25 PM

#

this is not working 09:24, Clock

#

if (clockHoursInt >= alarmHours && clockMinutesInt >= alarmMinutes)
{

        alarmHours = 0;
        alarmMinutes = 0;
        
        
        return clockHoursInt + ":" + clockMinutesInt + " Alarm";

north arrow Jul 14, 2023, 1:25 PM

#

and if you change the number of clocks to 3, you should get your expected output

oak estuary Jul 14, 2023, 1:26 PM

#

i literally did

north arrow Jul 14, 2023, 1:26 PM

#

and the issue is that it doesn't display the word alarm?

oak estuary Jul 14, 2023, 1:26 PM

#

no

#

it dosent

north arrow Jul 14, 2023, 1:28 PM

#

you have aClock.setAlarm(17,1); in your main

#

What is that supposed to do?

oak estuary Jul 14, 2023, 1:28 PM

#

get the current time

north arrow Jul 14, 2023, 1:28 PM

#

?

oak estuary Jul 14, 2023, 1:28 PM

#

get the current time

north arrow Jul 14, 2023, 1:29 PM

#

Should that not set the alarm time?

#

Also, what is Clock?

oak estuary Jul 14, 2023, 1:30 PM

#

huuh

north arrow Jul 14, 2023, 1:30 PM

#

I have no idea what your Clock class does

#

but setAlarm doesn't look like it would get the current time

#

it looks more like it would set the alarm time

oak estuary Jul 14, 2023, 1:31 PM

#

it does

#

one sec

north arrow Jul 14, 2023, 1:31 PM

#

oak estuary it does

so why did you say it would get the current time?

oak estuary Jul 14, 2023, 1:31 PM

#

it worked

#

had to put the current time in the brackets next to set alarm

#need help why is alarm triggering twice