Roguelike Dungeons <> BetterMineshafts strange interaction | YUNG GANG | Page 1

main leaf Nov 14, 2024, 9:17 AM

#

I've recently received this (long) github issue (it's long, skip it first pass): https://github.com/fnar/minecraft-roguelike/issues/95

It seems our mods have a strange interaction and I'm trying to get to the bottom of it.
https://spark.lucko.me/c4ue0a6JEU?hl=7480

Notably, RLD:FE employ's Forge's ChunkProvider.getNearestStructurePos() (https://spark.lucko.me/c4ue0a6JEU?hl=7220) which is invoking functions from RTG and BetterMineshafts under the hood.

I'm not familiar with BetterMineshafts in detail, so I'm curious if you have (Yung has) any top level insights around BM's behaviour before I start digging in more.

Thanks in advance.

marsh helm Nov 14, 2024, 8:21 PM

#

Sorry, but it's been so long since I touched 1.12, and worldgen has changed so much since then, that I really don't remember anything about how BM works on that version

#

taking a quick look at the code, it doesn't appear BM does anything special with regards to placement

main leaf Nov 14, 2024, 9:35 PM

#

Thanks for the response and for taking a look. 🙂 I'll dig in more when I have time.

Is 1.12 still supported (i.e. if I found an issue and submitted a PR, is there any chance it could merge)? (https://github.com/YUNG-GANG/YUNGs-Better-Mineshafts/tree/forge-1.12.2)

GitHub

GitHub - YUNG-GANG/YUNGs-Better-Mineshafts at forge-1.12.2

A long-awaited and much-needed Minecraft abandoned mineshaft overhaul! - GitHub - YUNG-GANG/YUNGs-Better-Mineshafts at forge-1.12.2

marsh helm Nov 16, 2024, 9:55 PM

#

normally I'd say no but I'll make an exception for you lol. Don't wanna ruin our mods' compatibility together

#Roguelike Dungeons <> BetterMineshafts strange interaction