How to update package -> module for latest zig

[grave zodiac]

I'm trying to update some existing code for the latest master. It tries to create a package, but am not sure what the new (module?) syntax should be?

https://github.com/ringtailsoftware/zig-embeddir/blob/main/build.zig#L22

   options.addOption([]const []const u8, "files", files.items);

    var pkg = std.build.Pkg{
        .name = "assets",
        .source = options.getSource(),
    };
    exe.addPackage(pkg);

This runs

    options.addOption([]const []const u8, "files", files.items);
    exe.step.dependOn(&options.step);

    _ = b.addModule("assets", .{
        .source_file = .{ .path = options.getSource().getPath(b) },
    });

But, gives me: thread 10136 panic: getPath() was called on a GeneratedFile that wasn't build yet. Is there a missing Step dependency on step 'options'?

[blazing leaf]

.source_file = options.getSource()

I'm not sure why you're exposing that module though, isn't it an internal options module?

[grave zodiac]

Yes, I don't know what I'm doing

[blazing leaf]

You should probably use createModule instead

Actually, in this case it seems like you're not making a package so it doesn't hugely matter either way

But basically addModule will expose the module to anything that depends on the package, whereas createModule will only create an internal module that won't be exposed to other packages

[grave zodiac]

Thanks, fixed and pushed. Now I know what to search for, this explains it https://devlog.hexops.com/2023/zig-0-11-breaking-build-changes/#modules

[blazing leaf]

(that's the new meaning of package, not the old one - ie. package manager package, not module)