indirect damage from players do not award mark charge on kill

[void fable]

i've noticed some relics (like threshing blade, swollen tick, miasmic toad, and most other relics that can kill enemies that the player doesn't directly hit) will not award players with the kills that would normally have been awarded to them
(unsure if this is intentional or an oversight but thought it'd be wise to report anyways)

the one that specifically made me bring this up is threshing blade. if one of the hits deals a killing blow to multiple enemies, you will only be rewarded mark charge for a single kill instead of for the multiple enemies that died to that one hit

[safe rivet]

from what i know, this is due to the function that handles hits, and it currently only checking for direct hits from a weapon

i think erthu has mentioned that we'll be getting a generic onEntityHit() function that responds to all damage at some point soon for modding, and i assume itll be the same for the base game

wait i just realized that it would be onEntityDeath() that it checks right?

hmm

i think the issue is that the damage from relics doesnt tell the game anywhere that you triggered it

so when it finds the source, the source is literally threshing blade, not you

oh wait lets go i just realized why souls are broken cause of looking thru this post

lets go