False alarm | Cloudflare Developers | Page 1

untold sail Jun 22, 2024, 6:05 PM

#

Cloudflare does not add or remove CORS headers to Workers

real kite Jun 22, 2024, 6:06 PM

#

I add them, it was working yesterday

untold sail Jun 22, 2024, 6:06 PM

#

Do you see the CORS headers on your response?

#

It may also be a preflight request so make sure that is handled - https://developer.mozilla.org/en-US/docs/Glossary/Preflight_request

MDN Web Docs

Preflight request - MDN Web Docs Glossary: Definitions of Web-relat...

A CORS preflight request is a CORS request that checks to see if the CORS protocol is understood and a server is aware using specific methods and headers.

real kite Jun 22, 2024, 6:09 PM

#

#

That hasn't been changed and was working yesterday

untold sail Jun 22, 2024, 6:09 PM

#

Look at the response, do you see the CORS headers?

real kite Jun 22, 2024, 6:10 PM

#

PM

untold sail Jun 22, 2024, 6:10 PM

#

Cloudflare Eng don't work weekends and definitely don't release on weekends. We also don't mess with responses

#

Best path is to debug and find the actual problem rather than point at a platform issue off the bat

real kite Jun 22, 2024, 6:13 PM

#

Hehe, might be that I'm throwing accusations since the experience last time where I was debugging for hours until contacting you so I'm a bit sour from that. Apologies if this is not on you, but I really haven't changed anything with the cors and like I said it was working yesterday so I have no idea.

I also noticed that you recently released a new version of itty-router-openapi that you renamed Chanfana https://github.com/cloudflare/chanfana

So I implemented a new worker yesterday with that pattern and it worked. Tested it in the chrome console using fetch() and got a response. Today when I test it it's not working.

GitHub

GitHub - cloudflare/chanfana: OpenAPI 3 and 3.1 schema generator an...

OpenAPI 3 and 3.1 schema generator and validator for Hono, itty-router and more! - cloudflare/chanfana

#

I will debug this until I find the problem and if it turns out to be on me, all I can do is humbly apologize.

#

Here's the implementation using Chanfana

#

😅

#

NM

#

Sorry

untold sail Jun 22, 2024, 6:19 PM

#

Trust me, if CORS broke for everyone we'd be in a big incident already haha

Many things that can explain what happened - it worked, was cached and then the code broke. You just forgot you did a change after the test, etc.

real kite Jun 22, 2024, 6:19 PM

#

Must be it. I humbly apologize 🙇‍♂️

untold sail Jun 22, 2024, 6:19 PM

#

Haha no worries

real kite Jun 22, 2024, 6:24 PM

#

Ok just for completion. I implemented a new worker and copied the wrangler.toml from my other endpoint, so it had the same name configuration and overwrote the old one and on top of that I applied the cors to the wrong endpoint as you can see in the screenshot. Had been working 18 hours yesterday so wasn't thinking clearly. Cloudflare is great 😁

#False alarm