#Bitrue Connector (NCP-8)

8 messages · Page 1 of 1 (latest)

vagrant kettle
#

This proposal is for adding Bitrue connector to Hummingbot codebase. With the recently approved HIP-37 which provides a bounty for CEX listing of HBOT on Bitrue exchange, this will be a great addition to the connectors.

Development work and PR by @bronze abyss

Github Link: https://github.com/hummingbot/hummingbot/pull/6761

GitHub

Before submitting this PR, please make sure:

Your code builds clean without any errors or warnings
You are using approved title ("feat/", "fix/", "docs/", "ref...

ancient swiftBOT
#

GG @vagrant kettle, you just advanced to level 1!

vagrant kettle
#

@bronze abyss The PR was closed because it doesn't have unit tests to meet Foundation guidelines. Are you able to add the unit tests and resubmit?

bronze abyss
#

Hey @vagrant kettle I open sourced 3 connectors at the same time. Was waiting to build unit tests starting with the connector which community shows interest. Now it’s bitrue

#

I will be available to build unit tests sometime in February 🙌

lean harness
#

@here I think I can help you guys to add missing ones like unit test for this connector

bronze abyss
#

Hey @lean harness, that would be a great help in getting the PR back up!

#

You can build unit tests and push to the above PR and we all can re-open the PR and submit the proposal again