#Merge kind of "urgent" Pull Request

6 messages · Page 1 of 1 (latest)

fervent notch
#

Hi, as of typescript@5, we can now set "moduleResolution": "bundler" which is nice. However, the @nestjs/cli package uses typescript@4.9.5. That is, we cannot configure this new option in our tsconfig.json file because we get an error:

ERROR in ./tsconfig.base.json:6:23
TS6046: Argument for '--moduleResolution' option must be: 'node', 'classic', 'node16', 'nodenext'.
    4 |                 "target": "ES2017",
    5 |                 "module": "ESNext",
  > 6 |                 "moduleResolution": "bundler",
      |                                     ^^^^^^^^^
    7 |                 "noEmit": true,
    8 |                 "baseUrl": "./",
    9 |                 "allowJs": false,

webpack 5.76.2 compiled with 1 error in 536 ms
 ELIFECYCLE  Command failed with exit code 1.

There is already a PR to fix it:
https://github.com/nestjs/nest-cli/pull/1986

Can this get please a priority to be merged?

GitHub

This PR contains the following updates:

Package
Change
Age
Adoption
Passing
Confidence

typescript (source)
4.9.5 -> 5.0.2

Release Notes

Microsoft/TypeScript
v5.0.2: TypeScript 5....

fervent notch
edgy bronze
fervent notch
#

@edgy bronze
Is there any ETA for this to be merged? All related tests were completed successfully

eager prism
# fervent notch <@132222189209518080> Is there any ETA for this to be merged? All related tests ...

At least for nest-cli you can see the build is failing.
Also, I believe this change has to be done in all repositories, not only cli/schematics (in core for example: https://github.com/nestjs/nest/pull/11293), which is a huge task.
I wouldn't be surprised if this required a new major release of nest, since it probably won't be backwards compatible. That said, I don't see this landing anytime soon (I might be mistaken though).

You can try hacking the overrides in package.json (https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides), but again, some of the core libs are failing with TS5, so things will break.