#[1.21.3] Progressive Block Breaking Sounds [CLIENT]

249 messages · Page 1 of 1 (latest)

solemn bear
#

I have a mod idea: Progressive Block Breaking Sounds. So, as you break a block, it's breaking sound pitch will get higher as you break it. The range of the pitch should be from 0.0 - 2.0.

solemn bear
#

bump

solemn bear
#

bump

frosty dock
#

Ping me in a few days to remind me to look at where the block breaking sound is played. I’m too busy right now, but now I’m curious.

void ermine
#

im interested, ill look into it

solemn bear
#

@frosty dock, the block breaking sound shall be emitted from the block itself, just modified to my idea.

solemn bear
#

Bump

solemn bear
#

bump

solemn bear
#

@frosty dock, still up to doing this?

frosty dock
#

Sorry I didn’t get to this yet; I’ll look at it tonight. I’ve been pretty busy.

solemn bear
#

Oh, ok.

frosty dock
#

Notes:
MultiPlayerGameMode.continueDestroyBlock
SoundType.getHitSound

#

Any ideas for a short name for this mod?

frosty dock
# solemn bear Oh, ok.

It looks like this wouldn't be that bad; it might only be a single mixin! However, to create the project, I'd need a name for the mod. Any suggestions?

frosty dock
solemn bear
#

hmm...

#

pitched-mining-progress?

frosty dock
#

"Pitch Progress" might work. It's not particularly catchy, though.

solemn bear
#

Are you going to publish the future .jar?

#

More mod name suggestions from the top of my head:

#

No.2: Pitchy Break

#

No.3: Sound King

#

No.4: Sound Status

frosty dock
frosty dock
solemn bear
#

Alright, that shall do.

frosty dock
#

Oh, hang on. I need to make sure this isn't technically classified as a cheat.

solemn bear
#

Oh alright.

frosty dock
#

So, what do you plan to use this for?

solemn bear
#

Honestly, this was just a random idea that I liked that I came up with at the top of my head. I just like little QOL related things.

frosty dock
#

Oh, wait. 1.21.3.

#

I'll need to roll back the version a bit, but that shouldn't be a problem at all.

#

I doubt anything drastic changed regarding this.

main flint
frosty dock
#

Very true.

#

But, the entire mod is one mixin.

#

Hmm... I wonder what happens when you give it a negative pitch?

#

Now I just want to find out.

solemn bear
#

👀

#

Send me a vid of the build with negative pitch values pls

frosty dock
solemn bear
#

k

#

𝓣𝓱𝓮·𝓦𝓱𝔂·𝓔𝓿𝓮𝓷·𝓗𝓸𝔀

#

Font paste test

#

lol

#

@main flint

frosty dock
#

I'm not touching that because I'd probably break stuff.

main flint
main flint
solemn bear
#

lol

frosty dock
#

Because this works perfectly well back to at least 1.20.1.

main flint
#

Just mark fmj compatible

#

Assuming java version also is

frosty dock
#

Oh, that works? Cool.

#

In which versions did the Java version change?

main flint
#

!!java

opal stratusBOT
#
Adoptium (AdoptOpenJDK)

Java 21 for Minecraft 1.20.5 and later
Java 17 for Minecraft 1.17 to 1.20.4
Java 8 for Minecraft 1.16 and earlier

main flint
#

So take 17

#

It's the lcd

frosty dock
#

Also, what syntax does the fabric.mod.json use for version ranges?

main flint
#

And array is and

frosty dock
#

Wait, wouldn't I need to use the highest common version?
Edit: never mind, it's currently well after midnight.

main flint
#

It's confusing, but reasonable

#

And is in one string

#

Or is array

#

So put two predicates in one string, separated by a space

#

minecraft: ">=1.20.1 <=1.21.4"

#

java:">=17"

#

And be sure to build against java 17

frosty dock
#

How would I change that in IntelliJ, by the way?

main flint
#

Otherwise you'll get class files that are too new for the 17 jvm

#

Between the two settings panes

#

There is one under build and deployment

#

Gradle

#

And there is one under project settings somewhere

#

And then you also need to change the two specified in build.gradle edit:two

frosty dock
#

Okay, let's see if this works. Reloading Gradle...

#

Oh, I also need to change the one in the mixins file.

main flint
frosty dock
#

I must have messed something up, but I'm not sure what.

#

Other than that, though, works fine on 1.18!

#

Any idea what I might have done wrong?

#

There is this in the log: Class path entries reference missing files: C:\Users\*****\Documents\GitHub\indicative-pitch\build\classes\java\main - the game may not load properly!

main flint
#

I have no clue, but I've seen it in some fail somewhere

main flint
frosty dock
#

Ah well, I don't really care about 1.18 much anyways.

#

1.20.1 should be fine. Now, to see if that works still...

#

Much better.

main flint
frosty dock
#

I have no idea who that is, it's just the splash text.

main flint
#

He's an American cartoon character

#

From before my time

frosty dock
# solemn bear lol

I've finished the mod. It should be compatible with versions 1.20.1 through 1.21.5.

#

Thanks for the help, The·Why·Even·How, as always.

#

Should I just upload it here, or would you rather it be checked by CurseForge and/or Modrinth first?

#

I still need to create a logo for it, so I won't upload it to CurseForge/Modrinth tonight; I can probably do that tomorrow if I don't forget.

main flint
#

-# I should have time to incessantly ping you every 10 minutes /j

frosty dock
#

Was I pinging you too much or something? Sorry.

main flint
#

Oh no

#

I only get visual pings for discord, not haptic or auditory

#

If I'm looking, I meant to see it. If not, it can wait until I look

solemn bear
frosty dock
frosty dock
#

This feels so wrong for some reason.

main flint
frosty dock
#

Yeah, that would be even crazier.

#

Well, it's submitted for review on CurseForge and Modrinth.

solemn bear
#

Very creative with the music note

frosty dock
#

I'll let you know when it's up, though it'll probably be a while.

void ermine
#

how can the jar use both java 17 and java 21 versions?

frosty dock
#

I tested it, it works.

#

(At least, it should. Please try to prove me wrong.)

void ermine
#

huh. interesting.

frosty dock
#

If you get a chance to play around with it, let me know what you think!

solemn bear
#

Alright, thanks!

solemn bear
#

Ok, so I tried out the mod, and it works very nicely! But there is one thing... ...My initial expectation for the mod was for the block breaking sound to start at a pitch of 0.0 (lowest). Currn tly, it plays the normal sound pitch when starting to break a block. Is it ok if you add this?

#

@frosty dock

frosty dock
main flint
#

-# stupid vanilla

frosty dock
#

I thought I'd sent a message about that, let me see if I can find it.

solemn bear
#

I understand. Ok. Thanks anyways! The mod still rocks!

frosty dock
#

For some reason, vanilla clamps the sound between 0.5 and 2.0.

#

I don't want to change this, because there may be vanilla (or other mod!) behavior depending on it.

solemn bear
#

k

frosty dock
#

The best solution I can think of is to create my own SoundInstance class, mixin to play that one instead, and then mixin to calculatePitch to detect my custom class.

solemn bear
#

Hmm.. alr

#

Also, when the block breaks, its pitch is default. Is this also a factor of the vanilla limitation?

frosty dock
#

Oh, did you want that to change too? I didn't realize.

#

I thought you just wanted the breaking tone to shift.

solemn bear
#

Yeah, it would be great for the pitch to be affected for the breaking sound, too. I beleive the mining sound pitch change will be more noticable because of the original vanilla limitation of the mining sound, with the destroyed block pitch changed.

frosty dock
#

The thing is, the sound when the block finishes breaking will always be higher pitched - is that what you want?

#

I feel like that might get annoying.

solemn bear
#

Yes, that is what I want. If you feel like it will get annoying for other users, you can just upload the jar here if you want.

solemn bear
#

How's the progress, @frosty dock? Just curious...

#

👀

frosty dock
main flint
#

-# ... 3 Hours later

frosty dock
main flint
frosty dock
#

It's done shockingly well so far; I guess I got lucky this time. We'll have to see if it continues past this initial popularity surge.

main flint
frosty dock
#

I'm not exactly in this for the money... which is good, since I won't be getting that much!

solemn bear
#

Hey, @frosty dock, do you think you can get the mod done today?

frosty dock
#

I'm looking into it. It's turning out to be more complicated than I thought, and I've had a lot of real-life commitments. At this point, I'd just recommend being patient - I'll get it done as soon as I can, but real-life stuff (like the robot that needs to be built by next Wednesday) has to come first.

solemn bear
#

Ok, sorry. I will be patient and only await your message.

frosty dock
#

(And also to Modrinth, but there's little hope of that being finished reviewing anytime soon as even the initial file hasn't finished.)

#

Let me know if this version functions to your satisfaction.

frosty dock
solemn bear
#

Yeah lol

frosty dock
#

Also, let me know if there are any other features you want so I can work on them if I have time. I don't know if I can predict when I will have time.

solemn bear
#

Alright, will maybe think of some.

solemn bear
#

Ok, so v1.1.0 crashed - just to report...

frosty dock
solemn bear
#

I will provide you with one soon.

frosty dock
#

Sorry for not responding sooner, by the way.

solemn bear
#

oh its ok

frosty dock
#

Hey, maybe I can get this fixed tonight. That would be great.

#

I might not be able to, depending on how complicated it is.

solemn bear
frosty dock
#

Great, I'll take a look.

#

That's what I expected. I didn't fully test this, since you were in a hurry, so I apparently made a faulty assumption.

#

For now I'll use a more targeted version; it won't be compatible over as wide a range as the other one was.

#

This will be quicker.

solemn bear
#

I really don't want to hurry you; please take your time.

frosty dock
#

Ugh, now I have to figure out how to change the Java version back again.

frosty dock
#

Let me know if this one crashes.

solemn bear
#

Alright. Thanks!

frosty dock
#

Hopefully CurseForge reviews this one as quickly as it did the last one.
Honestly, the change that broke the older version is one I'm perfectly fine with... before 1.21.2, level events such as block breaking were handled in the renderer, of all places!

frosty dock
solemn bear
#

Alright, I will check it out!

main flint
frosty dock
#

It might still be pending when Silksong releases.
-# That's a lot less dramatic of a claim now than it was a few weeks ago.

solemn bear
#

MOD WORKS ✅ - THANK YOU!

frosty dock
#

Awesome!

frosty dock
solemn bear
#

Hmm... that seems like an interesting idea. Ok, go for it if you'd like, I am already very satisfied.

#

Thanks anyways!

frosty dock
#

Uploaded a new version with that change to CurseForge. You're under no obligation to try it out; I'm just playing around to see what I like best at the moment. This whole project is a really cool idea; thank you for suggesting it to begin with.

#

(I'm also signing off for the evening)

solemn bear
#

Yo... Soo, @frosty dock, I just had another mod idea.... ..like just random, but related to this mod's nechanics in a way...

solemn bear
#

So, when you start to mine a block, an action bar message appears (formatted in a cool color), that shows how many minutes and seconds are left until you will break the block (estimated). Action bar format: "Mining <block> | Breaks in: XXmin XXs".

#

Yeah

#

Perhaps a ding sound plays onc e you have broken a long-to breack block like obsidian, etc

#

Once the block is broken, the action bar turns green, and says: "Broken <block>!"

#

So, this is just an idea that popped out of my head, just want to contribute to the community, no hurries.

frosty dock
#

Hmm… while that would be doable, I honestly think that would get really annoying. Imagine the message spam if you were mining through weaker blocks like dirt and stone!

solemn bear
#

hmm good point

frosty dock
#

It would also take up a decent bit of prime real estate on the screen.

solemn bear
#

i see...

#

alright

main flint
#

Maybe it could only show the message for blocks harder than bedrock?

frosty dock
#

Bedrock?

solemn bear
#

There isn;t a block harder than bedrock lol

#

or is there...

#

lol lmao

frosty dock
solemn bear
#

Barrier blocks have a harder blast res or no...

#

Are there any operator blocks harder in terms of blast res than bedrock...?

frosty dock
#

I have no idea. I don’t think you can even break bedrock with explosions.

waxen lion
#

You need an insane explosion

frosty dock
waxen lion
#

I cant say no

solemn bear
#

OOOH

#

I have another idea.

#

This one will leverage the recource pack loading bar

#

If you look at an entity, the bar's value will be based on the hp of the entity'

#

can be toggled with /togglehpbar

#

idk

frosty dock
#

So it sets the boss bar to whatever you’re looking at?

waxen lion
solemn bear
#

Actualy, I meant the recource pack loadin bar, but since you mentioned it, yes, a Boss ba4r should be nice.The title of the bar should be: "<Entity> | HP: X.X". Color of bossbar: white.

#

I have never seen a client-sided boss bar before for hp tracking

#

Is this possible?

waxen lion
#

It is kind of a bad idea imo. If you have access to the rendering why use a bossbar? Just place the bar dynamically over the enemy

solemn bear
#

Yeah, I know; I just have seen a lot of thos types with 3-d rendering, but I just thought a boss bar would be cool.

solemn bear
#

So, @frosty dock, how do you feel about this idea?

frosty dock
#

I don’t know. It’s a very cool idea, and could probably even be purely server-side since boss bars are a vanilla feature. However, there’s already mods like Jade that show you the health of things you’re looking at. I don’t know if I could do a better job than they did.

solemn bear
#

Understood. How hard do you think it will be to use the vanilla bar on the CLIENT side?

frosty dock
#

I haven’t got a clue, sorry.

solemn bear
#

Ok.

frosty dock
# solemn bear Ok.

Thought you might be interested to know - the mod is now available on Modrinth.

#

(It sure took long enough)

solemn bear
#

Ok lol

solemn bear
#

Hey, @frosty dock is it ok if you provide credit to "@solemn bear on Discord" on Modrinth for this mod idea (maybe for curseforge, too)?

frosty dock
#

I could do that.

solemn bear
#

Oh ok that would be great, thanks

frosty dock
#

Done.

solemn bear
#

Alright, thanks!

solemn bear
#

Yooo, @frosty dock... its been a long time, and I'm wondering if you still mod. So if you do and have the desire and time to, can you make a version for entities? So the mod works like this: as an entity's hp gets lower, its damage sound pitch gets higher, simple. That's all I wanted to say. Hope you're doing well.