1.20 Update to fabricshieldlib or an alternative library/method of implementing shields

[iron turret]

as above.

[iron turret]

even better, integrate in to fabric api 🙂

[analog turret]

what does fabric shield lib have that fapi doesn’t? i know parts of fabric shield lib have been included into fapi before

[iron turret]

dont think it has, why would the shield wiki entry be about using fsl?

[ocean raptor]

That page hasn't been touched since 1.16

[iron turret]

THIS PAGE SHOULD WORK FOR 1.17-1.19

far too much bloat on the library tbh, requires about 10 other mods.

[iron turret]

necro.. still needs picking up, library seems dead, no easy way of adding shields to the game with functioning cooldowns, fapi does not do this..

[ocean plover]

Multi-Item-Lib can do shields, not sure if it has been updated to 1.20 though

[iron turret]

will check that out

doesnt look like it 😦
could have done with this for another mod a while back though!!

[ocean plover]

@iron turret It's not a library, but you might want to keep your eye on the way Guarding mod (which is in the public domain) implements their netherite shield. https://github.com/Team-Abode/guarding/
Theirs has a fancy trim render so I'm not sure if it exactly what you want though https://cdn.discordapp.com/attachments/1076907582205206670/1116490836683804793/sneakpeek.mp4

[ruby tundra]

trims on shields is cool

[summer wigeon]

I originally used Fabric Shield Lib to work on Guarding, but I found it to be rather limiting at times.

Some of the mixin injection points that were used to handle events for blocking, disabling were unreliable.

So I decided to include a sort of psuedo API that would be built into Guarding.

[fluid crown]

Hello, I am one of the developers for FabricShieldLib. We're sorry for our mod being outdated, but our new releases have been stalled because there is currently a crash that happens due to another mod whose creator has not responded to the issue at all, which has been open since April. Additionally @mint lance and I have both been busy for the last few months. We hope to get caught up, backported, and have the wiki updated by the end of August. Again, sorry for the massive delay.

[iron turret]

any update?

@fluid crown

[fluid crown]

No updates from the crashing mod's owner, and we are just 1-2 other things away from release

We have been trying tk contact that person since may, but they haven't even responded to the issue on the repository despite being active on other repos

[iron turret]

what is the deal with the crashing mod?

[iron turret]

@fluid crown - which mod and why does it prevent shield lib from being updated? 🙂

[fluid crown]

MOBZ reborn

[iron turret]

why should another random mod impact a library mod? 😛
and its not even in 1.20

[iron turret]

decided to go it alone..

shields are a pain!

[fluid crown]

It's one of the bugs causing crashes and is an open issue on the github, we want to resolve them before releasing a new version, as we assured the bug reporters that we would fix it in the next update

[fluid crown]

Yeah they are a pain. Good job figuring them out!

Imma talk with the owner of the lib and see if we might release the new update without the mobz reborn crash fix, but im not sure

[hollow wind]

I'm the author of mobz reborn, I cannot port mobz to 1.20.1, because the shield lib is not available.

[hollow wind]

It is supposed to be a part of fabric api since the very beginning...

[fluid crown]

We haven't been able to port our lib since an open issue is a crash caused by your mod

[iron turret]

you can port it, just implement shields yourself

[hollow wind]

Adding new shields requires mixin, and two mixins with that type cannot coexist

thats why we need the lib

im not sure if it is still true in 1.20.1

[fluid crown]

This is the crash I'm mentioning btw https://github.com/rikka0w0/MobZReborn/issues/35

If u can fix that, we can probably update and port the lib by tues-wed

[iron turret]

dont use overrides :S

[fluid crown]

It's the abstract causing the issue

The mixin is declared abstract which causes the crash

[iron turret]

that Metal shield could just extend FabricShield and apply the same 2 settings

[hollow wind]

I shouldn't use abstract class here?

[fluid crown]

From the crash logs, it seems that is causing the issue

[hollow wind]

I remember when I was new to mixin, I saw a tutorial that mentioned we should make all mixin classes abstract...

[fluid crown]

But also that mixin is unnecessary, since both of the things you are trying tk change can be set when creating the item

[hollow wind]

Minecraft 1.19.2 + Fabric Shield Lib 1.7?

[fluid crown]

I think that was our last update yeah

[fluid crown]

Since cooldown ticks is a setting when creating the item and the banner support is dependent on if you use fabricshielditem or fabricbannershielditem

[hollow wind]

I will try to fix that

[hollow wind]

Oh, the fix is actually super simple...He renamed the method...the lowercase d now becomes a capital D....

[iron turret]

but overriding in mixins is bad for compatability

[hollow wind]

I have to do it this way, my item class cannot directly implement FabricShield interface, because my mod also has a forge version...

I really hope there is a cross-loader cross minecraft version API modding framework exists...

[fluid crown]

so it wont work if you makr this extend "FabricShieldItem"?

[iron turret]

if hes extending shielditem why even using FSL ?

[fluid crown]

yeah.. that too

[fluid crown]

I've updated the library, will release tomorrow afternoon since its getting late for me already

[fluid crown]

Also the wiki will get fixed as soon as I get the new systems explained to me by the owner of the lib

[fluid crown]

1.20.2 port is now released, this can now be closed.

[hollow wind]

https://github.com/StellarWind22/Fabric-Shield-Lib/issues/159

The 1.20.2 port is buggy

[fluid crown]

I swear we've had that issue before, let me check the past bugs

[hollow wind]

I had a look at the code, the usage of ClassTinkerers looks identical to Chocohead's example

[fluid crown]

Found it, it was issue 82, which was resolved here: https://github.com/StellarWind22/Fabric-Shield-Lib/pull/101, maybe we can look into what the other person did

I'll look more into it in the morning, it's getting kinda late

[fluid crown]

Was this only happening on 1.20 or on the other versions too?

[hollow wind]

I tested it in 1.20.2, looks like the problem is specific to the development env, i cannot reproduce it in a normal client

[fluid crown]

yeah i think thats what also happened last time this bug was around. maybe it never left and we were just lucky to encounter it since then

[hollow wind]

it may have something to do with the ClassTinker, now I dont think it is a problem on our end

[fluid crown]

yeah thats also very possible

[cedar frost]

Hello! Idk where to ask, but can I bundle this mod into mine? Or I can only make it as dependency

[fluid crown]

We would prefer for it to be a dependency as it helps support us and our work