GetComponent null, why? | Official Unity Discord | Page 1

honest ingot Jan 10, 2022, 2:13 PM

#

Testing with cs var test = _playerPanel.transform.Find( "Vertical Group" ); var test2 = test.Find("Name"); var test3 = test2.GetComponent<TextMeshPro>( ); and test and test2 is good but test3 returns null. What am I missing? Name does have the TextMeshPro :|

#

celest stag Jan 10, 2022, 2:13 PM

#

TextMeshProUGUI i think or whatever the name is for it

rocky marten Jan 10, 2022, 2:14 PM

#

Isn’t it textmeshprogui or something else long like that

past current Jan 10, 2022, 2:14 PM

#

or TMP_Text

#

this whole thing is bad though. Don't use find.

honest ingot Jan 10, 2022, 2:14 PM

#

Ah yeah you're probably right. Just noticed TextMeshPro seems to be for 3d objects while UI might have its own

past current Jan 10, 2022, 2:14 PM

#

if you have the ref to playerPanel, you can directly ref the other ones too.

honest ingot Jan 10, 2022, 2:14 PM

#

past current if you have the ref to playerPanel, you can directly ref the other ones too.

how?

past current Jan 10, 2022, 2:15 PM

#

how have you referenced _playerPanel ?

honest ingot Jan 10, 2022, 2:15 PM

#

I store a ref at start with _playerPanel = GameObject.Find( "PlayerPanel" );

past current Jan 10, 2022, 2:15 PM

#

Fuck

#

bin it off.

honest ingot Jan 10, 2022, 2:15 PM

#

Thought storing a ref was more efficient 😳

past current Jan 10, 2022, 2:16 PM

#

[SerializeField] private GameObject playerPanel;
[SerializeField] private TextMeshProUGUI name;

honest ingot Jan 10, 2022, 2:16 PM

#

🤔 I don't understand anything

#

I'm 1 month into unity so might need a link explaining what's going on

rocky marten Jan 10, 2022, 2:17 PM

#

https://cdn.discordapp.com/attachments/497874004401586176/927950795146674186/image0.gif

#

The gif is old but the process is the same

#

Putting what Don posted earlier, you can create a slot in the inspector that you can drag into

#

Then you don’t have to use .Find

honest ingot Jan 10, 2022, 2:18 PM

#

Oh right, thought that was only for Public variables

past current Jan 10, 2022, 2:18 PM

#

serialize field exposes it to the inspector, but is private to this class

honest ingot Jan 10, 2022, 2:18 PM

#

Oh that's awesome. thanks!

past current Jan 10, 2022, 2:18 PM

#

9/10 things you write as public... shouldnt be public

honest ingot Jan 10, 2022, 2:18 PM

#

I agree

#

Totally forgot about this, need to refactor a bunch of code now lol

past current Jan 10, 2022, 2:20 PM

#

basically. if you have any type of Find in your code, you're doing it wrong

rocky marten Jan 10, 2022, 2:20 PM

#

I don’t believe there’s a performance cost but idk

honest ingot Jan 10, 2022, 2:20 PM

#

Yeah me neither since I store refs and don't call find every frame

#

but cleaner to just have them init at compiletime i guess

past current Jan 10, 2022, 2:20 PM

#

honest ingot Yeah me neither since I store refs and don't call find every frame

what happens if you change the name of the object?

#

your code is now broken

#

its unscalable

honest ingot Jan 10, 2022, 2:21 PM

#

very true

#

I will have to use Find when working with prefab properties tho?

past current Jan 10, 2022, 2:22 PM

#

No

honest ingot Jan 10, 2022, 2:22 PM

#

or maybe not if the script is from the prefab I suppose

past current Jan 10, 2022, 2:22 PM

#

Also no

rocky marten Jan 10, 2022, 2:23 PM

#

The only time I ever use find/FindObjectOfType is when using DDOL since it breaks it from the hierarchy meaning I can’t drag reference it

#

I wonder if there’s a better way but idk

honest ingot Jan 10, 2022, 2:24 PM

#

hmm, not showing up in editor?

past current Jan 10, 2022, 2:25 PM

#

Then you have errors

honest ingot Jan 10, 2022, 2:25 PM

#

haha very true

#GetComponent null, why?