Camera obstruction check | Official Unity Discord | Page 1

ancient mirage Dec 26, 2021, 2:05 PM

#

Here is my camera obstruction check code:

public class StayInView : MonoBehaviour
{
    [SerializeField] private GameObject PlayerObject;
    [SerializeField] private Transform OldPosition;
    
    [SerializeField] private LayerMask TerrainMask;
    private Cinemachine.CinemachineVirtualCamera Vcam;
    private Cinemachine.CinemachineTransposer transposer;

    private Vector3 NewPosition = new Vector3(0, 10, -6);

    private void Awake()
    {
        Vcam = GetComponent<CinemachineVirtualCamera>();
        transposer = Vcam.GetCinemachineComponent<CinemachineTransposer>();
        
    }

    private bool IsObstructed()
    {
        Vector3 DirToTarget = (PlayerObject.transform.position - transform.position).normalized;
        float DistToTarget = Vector3.Distance(transform.position, PlayerObject.transform.position);
        
        Debug.DrawLine(OldPosition.position, PlayerObject.transform.position);
        if (!Physics.Raycast(OldPosition.position, DirToTarget, DistToTarget, TerrainMask)) return true;
        
        return false;
    }

    private void FixedUpdate()
    {
        if (!IsObstructed())
        {
            Vcam.transform.rotation = Quaternion.Euler(90, 0, 0);
            
            transposer.m_FollowOffset = new Vector3(0, 10, -1.5f);
        }
        else
        {
            Vcam.transform.rotation = Quaternion.Euler(60, 0, 0);
            
            transposer.m_FollowOffset = new Vector3(0, 10, -6);
        }
    }
}

#

Normal Camera:

#

Camera If Obstruction Is found

#

If the object is less that 4 thick then the camera will switch between these two views every frame

#

OldPosition is the position the camera would be in if it wasn't in top down mode and this is where the raycast is sent from

#

public class FindOldCamPos : MonoBehaviour
{
    [SerializeField] private Transform PlayerPos;
    [SerializeField] private Vector3 NewPos;

    // Update is called once per frame
    private void Update()
    {
        Vector3 playerpos = PlayerPos.position;
        
        transform.position = playerpos + NewPos;
    }
}

#

ancient mirage Dec 26, 2021, 2:54 PM

#

round wedge Dec 26, 2021, 4:49 PM

#

ancient mirage Here is my camera obstruction check code: ```cs public class StayInView : MonoBe...

What is OldPosition? I don't see you setting it anywhere

ancient mirage Dec 26, 2021, 4:49 PM

#

Oldposition is an empty gameobject that hovers above the player

#

its in the position of the normal camera view

#

and set through the inspector

round wedge Dec 26, 2021, 4:50 PM

#

I see. Its a child of the player right?

ancient mirage Dec 26, 2021, 4:51 PM

#

its not a child

#

#

it moves to its position every update because I didn't want it to rotate

#

the script I sent FindOldCamPos is attached to it

round wedge Dec 26, 2021, 4:52 PM

#

Okay that makes sense. Sorry, missed that script+screenshot entirely when I was reading

ancient mirage Dec 26, 2021, 4:53 PM

#

in this screen shot, the camera is alternating every frame even though the obstruction should be detected

#

as you can see the raycast is hitting the obstacle

#

object 1 has the problem but object 2 does not and it works as intended

#

I know it is caused by the thickness of the wall but I don't know why

round wedge Dec 26, 2021, 4:57 PM

#

Can you check the collider on the faulty wall?

#

If it correctly represents the wall

ancient mirage Dec 26, 2021, 4:57 PM

#

I know for sure that the collider is exact to the wall and it is on the right layer

#

round wedge Dec 26, 2021, 4:59 PM

#

ancient mirage Here is my camera obstruction check code: ```cs public class StayInView : MonoBe...

Sanity check, can you move the logic in FixedUpdate() to LateUpdate()?

ancient mirage Dec 26, 2021, 4:59 PM

#

Ok ill do that

#

it still doesn't work

#

is it possible that the line shown with DrawLine does not match the raycast being fired?

round wedge Dec 26, 2021, 5:07 PM

#

Maybe. Try this :

private bool IsObstructed()
    {   
        Vector3 DirToTarget = (PlayerObject.transform.position - transform.position).normalized;
        float DistToTarget = Vector3.Distance(transform.position, PlayerObject.transform.position);
        Ray rayToCast = new Ray(transform.position, DirToTarget);
        Debug.DrawRay(ray.origin, ray.direction  * DistToTarget,  Color.red);
        if(! Physics.Raycast(ray, DistToTarget, TerrainMask)
          return true;
        return false;
    }

ancient mirage Dec 26, 2021, 5:11 PM

#

I'm just trying your code now

#

why do you multiply direction by distance?

round wedge Dec 26, 2021, 5:14 PM

#

Debug.DrawRay needs that. It draws the ray from the ray.origin point to ray.origin + the second parameter

#

ref : https://docs.unity3d.com/ScriptReference/Debug.DrawRay.html

ancient mirage Dec 26, 2021, 5:15 PM

#

I fixed it!!!

#

I was using transform.position instead of OldPosition.position in my logic

round wedge Dec 26, 2021, 5:15 PM

#

oh my god

ancient mirage Dec 26, 2021, 5:15 PM

#

that is why the raycast was not matching the drawn line

round wedge Dec 26, 2021, 5:15 PM

#

Why did I not see that

ancient mirage Dec 26, 2021, 5:16 PM

#

still, its always helpful to explain your code to someone else as it helps you spot the error

#

In that way you were a huge help for me

round wedge Dec 26, 2021, 5:16 PM

#

Glad that you figured it out! 🍀

ancient mirage Dec 26, 2021, 5:17 PM

#

how would I move the camera smoothly between the two points?

round wedge Dec 26, 2021, 5:17 PM

#

Lerping

ancient mirage Dec 26, 2021, 5:18 PM

#

I tried lerp before but I don't fully understand it

round wedge Dec 26, 2021, 5:18 PM

#

Cinemachine has other fancy techniques which do that (same thing internally). Although I'm not familiar enough with those

round wedge Dec 26, 2021, 5:19 PM

#

ancient mirage I tried lerp before but I don't fully understand it

Which part did you not understand?

ancient mirage Dec 26, 2021, 5:19 PM

#

I could use two different virtual cameras instead of setting the position, that way cinemachine will handle the transition for me

#

the lerp made the camera move to a completely different place

round wedge Dec 26, 2021, 5:19 PM

#

How were you using it?

ancient mirage Dec 26, 2021, 5:20 PM

#

I dont remember because I deleted the lerp code

#

I dont know what to put in the float t part of lerp

#

I did 1 * time.deltatime and that screwed me up I think

#

also should the lerp be inside the update method or should it be a separate routine?

round wedge Dec 26, 2021, 5:22 PM

#

Lerp is a basic math equation

#

t is the normalized % value between a & b which you want

#

So, when lerping, you increase t from 0 to 1 at a fixed rate

#

var lerpedValue = (lerpStart, lerpEnd, t)

#

So, lerpedValue goes from lerpStart to lerpEnd at a constant rate

round wedge Dec 26, 2021, 5:25 PM

#

ancient mirage also should the lerp be inside the update method or should it be a separate rout...

It can be either. Making it in a separate coroutine will help you understand it much better, since update timers can get a bit hard to track

round wedge Dec 26, 2021, 5:25 PM

#

ancient mirage I could use two different virtual cameras instead of setting the position, that ...

tbh, I'd just use this unless you want a fancy(ier)transition

round wedge Dec 26, 2021, 5:27 PM

#

round wedge ```var lerpedValue = (lerpStart, lerpEnd, t)```

Example :

float lerpedValue = (0,1,t);

If you increase t in a coroutine or Update from 0-1, by adding Time.deltaTime each frame to it, lerpedValue will go from 0-1 in an interval of 1 second

ancient mirage Dec 26, 2021, 5:28 PM

#

does lerp need to be called once or does it move the vector by a small amout every time it is called?

round wedge Dec 26, 2021, 5:28 PM

#

Lerp is a single frame operation

#

It will give you the same value each frame

#

Unless you change its parameters

ancient mirage Dec 26, 2021, 5:29 PM

#

so calling lerp every frame is not good?

round wedge Dec 26, 2021, 5:29 PM

#

Wait, I'll give you an example of how to use lerp

#

private float progress = 0f;
private Vector3 startPos;
private Vector3 endPos;
private float timeNeededForTravel = 2f;
private bool isLerping = true;
private void Start()
{
  startPos = transform.position;
  endPos = transform.position + new Vector3.one * 10;
}
private void Update()
{
  if(isLerping)
  {
      progress += Time.deltaTime;
      transform.position = Vector3.Lerp(startPos, endPos, progress / timeNeededForTravel);
  }
}```

#

This lerps the object from its inital position to [initial position + (10,10,10)] in 2 seconds

#

Does that make sense?

ancient mirage Dec 26, 2021, 5:35 PM

#

I undertand it now

#

but when is progress reset?

round wedge Dec 26, 2021, 5:36 PM

#

It is not reset in the above code. You can do so yourself however

#

when progress / timeNeededForTravel == 1

#

(Approximately equal since this is a float!)

ancient mirage Dec 26, 2021, 6:10 PM

#

I like the lerp code but I'm just going to use two Vcams instead

#

the priority system lets me easily change to fixed cameras in certain areas too

#

Everything works properly now so I will close the thread

#Camera obstruction check